* [PATCH v3] Input: bcm5974 - Driver cleanup by replacing dprintk with dev_dbg
@ 2025-09-03 8:55 Bhanu Seshu Kumar Valluri
2025-09-15 14:14 ` bhanuseshukumar
2025-10-09 17:34 ` Bhanu Seshu Kumar Valluri
0 siblings, 2 replies; 3+ messages in thread
From: Bhanu Seshu Kumar Valluri @ 2025-09-03 8:55 UTC (permalink / raw)
To: rydberg, dmitry.torokhov
Cc: linux-input, skhan, linux-kernel, linux-kernel-mentees,
bhanuseshukumar
Debug printk messages are converted to dev_dbg based logs
for better control over debug messages using dynamic logging.
Signed-off-by: Bhanu Seshu Kumar Valluri <bhanuseshukumar@gmail.com>
---
Changes in V3
1. Name in the from tag & signed-off tag are matched.
Note: This patch is tested for compilation.
v1 patch : https://lore.kernel.org/all/20250902164351.36828-1-bhanuseshukumar@gmail.com/
v2 patch : https://lore.kernel.org/all/20250903061908.41910-1-bhanuseshukumar@gmail.com/
drivers/input/mouse/bcm5974.c | 18 +++++-------------
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c
index dfdfb59cc8b5..03e112666c2e 100644
--- a/drivers/input/mouse/bcm5974.c
+++ b/drivers/input/mouse/bcm5974.c
@@ -156,13 +156,6 @@ MODULE_AUTHOR("Henrik Rydberg");
MODULE_DESCRIPTION("Apple USB BCM5974 multitouch driver");
MODULE_LICENSE("GPL");
-#define dprintk(level, format, a...)\
- { if (debug >= level) printk(KERN_DEBUG format, ##a); }
-
-static int debug = 1;
-module_param(debug, int, 0644);
-MODULE_PARM_DESC(debug, "Activate debugging output");
-
/* button data structure */
struct bt_data {
u8 unknown1; /* constant */
@@ -550,8 +543,7 @@ static int report_bt_state(struct bcm5974 *dev, int size)
if (size != sizeof(struct bt_data))
return -EIO;
- dprintk(7,
- "bcm5974: button data: %x %x %x %x\n",
+ dev_dbg(&dev->intf->dev, "button data: %x %x %x %x\n",
dev->bt_data->unknown1, dev->bt_data->button,
dev->bt_data->rel_x, dev->bt_data->rel_y);
@@ -688,7 +680,7 @@ static int bcm5974_wellspring_mode(struct bcm5974 *dev, bool on)
goto out;
}
- dprintk(2, "bcm5974: switched to %s mode.\n",
+ dev_dbg(&dev->intf->dev, "switched to %s mode.\n",
on ? "wellspring" : "normal");
out:
@@ -718,7 +710,7 @@ static void bcm5974_irq_button(struct urb *urb)
}
if (report_bt_state(dev, dev->bt_urb->actual_length))
- dprintk(1, "bcm5974: bad button package, length: %d\n",
+ dev_dbg(&intf->dev, "bad button package, length: %d\n",
dev->bt_urb->actual_length);
exit:
@@ -753,7 +745,7 @@ static void bcm5974_irq_trackpad(struct urb *urb)
goto exit;
if (report_tp_state(dev, dev->tp_urb->actual_length))
- dprintk(1, "bcm5974: bad trackpad package, length: %d\n",
+ dev_dbg(&intf->dev, "bad trackpad package, length: %d\n",
dev->tp_urb->actual_length);
exit:
@@ -786,7 +778,7 @@ static int bcm5974_start_traffic(struct bcm5974 *dev)
error = bcm5974_wellspring_mode(dev, true);
if (error) {
- dprintk(1, "bcm5974: mode switch failed\n");
+ dev_dbg(&dev->intf->dev, "mode switch failed\n");
goto err_out;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v3] Input: bcm5974 - Driver cleanup by replacing dprintk with dev_dbg
2025-09-03 8:55 [PATCH v3] Input: bcm5974 - Driver cleanup by replacing dprintk with dev_dbg Bhanu Seshu Kumar Valluri
@ 2025-09-15 14:14 ` bhanuseshukumar
2025-10-09 17:34 ` Bhanu Seshu Kumar Valluri
1 sibling, 0 replies; 3+ messages in thread
From: bhanuseshukumar @ 2025-09-15 14:14 UTC (permalink / raw)
To: rydberg, dmitry.torokhov
Cc: linux-input, skhan, linux-kernel, linux-kernel-mentees
On 03/09/25 14:25, Bhanu Seshu Kumar Valluri wrote:
> Debug printk messages are converted to dev_dbg based logs
> for better control over debug messages using dynamic logging.
>
> Signed-off-by: Bhanu Seshu Kumar Valluri <bhanuseshukumar@gmail.com>
> ---
> Changes in V3
> 1. Name in the from tag & signed-off tag are matched.
>
> Note: This patch is tested for compilation.
> v1 patch : https://lore.kernel.org/all/20250902164351.36828-1-bhanuseshukumar@gmail.com/
> v2 patch : https://lore.kernel.org/all/20250903061908.41910-1-bhanuseshukumar@gmail.com/
>
> drivers/input/mouse/bcm5974.c | 18 +++++-------------
> 1 file changed, 5 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c
> index dfdfb59cc8b5..03e112666c2e 100644
> --- a/drivers/input/mouse/bcm5974.c
> +++ b/drivers/input/mouse/bcm5974.c
> @@ -156,13 +156,6 @@ MODULE_AUTHOR("Henrik Rydberg");
> MODULE_DESCRIPTION("Apple USB BCM5974 multitouch driver");
> MODULE_LICENSE("GPL");
>
> -#define dprintk(level, format, a...)\
> - { if (debug >= level) printk(KERN_DEBUG format, ##a); }
> -
> -static int debug = 1;
> -module_param(debug, int, 0644);
> -MODULE_PARM_DESC(debug, "Activate debugging output");
> -
> /* button data structure */
> struct bt_data {
> u8 unknown1; /* constant */
> @@ -550,8 +543,7 @@ static int report_bt_state(struct bcm5974 *dev, int size)
> if (size != sizeof(struct bt_data))
> return -EIO;
>
> - dprintk(7,
> - "bcm5974: button data: %x %x %x %x\n",
> + dev_dbg(&dev->intf->dev, "button data: %x %x %x %x\n",
> dev->bt_data->unknown1, dev->bt_data->button,
> dev->bt_data->rel_x, dev->bt_data->rel_y);
>
> @@ -688,7 +680,7 @@ static int bcm5974_wellspring_mode(struct bcm5974 *dev, bool on)
> goto out;
> }
>
> - dprintk(2, "bcm5974: switched to %s mode.\n",
> + dev_dbg(&dev->intf->dev, "switched to %s mode.\n",
> on ? "wellspring" : "normal");
>
> out:
> @@ -718,7 +710,7 @@ static void bcm5974_irq_button(struct urb *urb)
> }
>
> if (report_bt_state(dev, dev->bt_urb->actual_length))
> - dprintk(1, "bcm5974: bad button package, length: %d\n",
> + dev_dbg(&intf->dev, "bad button package, length: %d\n",
> dev->bt_urb->actual_length);
>
> exit:
> @@ -753,7 +745,7 @@ static void bcm5974_irq_trackpad(struct urb *urb)
> goto exit;
>
> if (report_tp_state(dev, dev->tp_urb->actual_length))
> - dprintk(1, "bcm5974: bad trackpad package, length: %d\n",
> + dev_dbg(&intf->dev, "bad trackpad package, length: %d\n",
> dev->tp_urb->actual_length);
>
> exit:
> @@ -786,7 +778,7 @@ static int bcm5974_start_traffic(struct bcm5974 *dev)
>
> error = bcm5974_wellspring_mode(dev, true);
> if (error) {
> - dprintk(1, "bcm5974: mode switch failed\n");
> + dev_dbg(&dev->intf->dev, "mode switch failed\n");
> goto err_out;
> }
>
Just want to know the status of this patch. Let me know if any further modifications needed.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3] Input: bcm5974 - Driver cleanup by replacing dprintk with dev_dbg
2025-09-03 8:55 [PATCH v3] Input: bcm5974 - Driver cleanup by replacing dprintk with dev_dbg Bhanu Seshu Kumar Valluri
2025-09-15 14:14 ` bhanuseshukumar
@ 2025-10-09 17:34 ` Bhanu Seshu Kumar Valluri
1 sibling, 0 replies; 3+ messages in thread
From: Bhanu Seshu Kumar Valluri @ 2025-10-09 17:34 UTC (permalink / raw)
To: rydberg, dmitry.torokhov
Cc: linux-input, skhan, linux-kernel, linux-kernel-mentees,
bhanuseshukumar
On 03/09/25 14:25, Bhanu Seshu Kumar Valluri wrote:
> Debug printk messages are converted to dev_dbg based logs
> for better control over debug messages using dynamic logging.
>
> Signed-off-by: Bhanu Seshu Kumar Valluri <bhanuseshukumar@gmail.com>
> ---
> Changes in V3
> 1. Name in the from tag & signed-off tag are matched.
>
> Note: This patch is tested for compilation.
> v1 patch : https://lore.kernel.org/all/20250902164351.36828-1-bhanuseshukumar@gmail.com/
> v2 patch : https://lore.kernel.org/all/20250903061908.41910-1-bhanuseshukumar@gmail.com/
>
> drivers/input/mouse/bcm5974.c | 18 +++++-------------
> 1 file changed, 5 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c
> index dfdfb59cc8b5..03e112666c2e 100644
> --- a/drivers/input/mouse/bcm5974.c
> +++ b/drivers/input/mouse/bcm5974.c
> @@ -156,13 +156,6 @@ MODULE_AUTHOR("Henrik Rydberg");
> MODULE_DESCRIPTION("Apple USB BCM5974 multitouch driver");
> MODULE_LICENSE("GPL");
>
> -#define dprintk(level, format, a...)\
> - { if (debug >= level) printk(KERN_DEBUG format, ##a); }
> -
> -static int debug = 1;
> -module_param(debug, int, 0644);
> -MODULE_PARM_DESC(debug, "Activate debugging output");
> -
> /* button data structure */
> struct bt_data {
> u8 unknown1; /* constant */
> @@ -550,8 +543,7 @@ static int report_bt_state(struct bcm5974 *dev, int size)
> if (size != sizeof(struct bt_data))
> return -EIO;
>
> - dprintk(7,
> - "bcm5974: button data: %x %x %x %x\n",
> + dev_dbg(&dev->intf->dev, "button data: %x %x %x %x\n",
> dev->bt_data->unknown1, dev->bt_data->button,
> dev->bt_data->rel_x, dev->bt_data->rel_y);
>
> @@ -688,7 +680,7 @@ static int bcm5974_wellspring_mode(struct bcm5974 *dev, bool on)
> goto out;
> }
>
> - dprintk(2, "bcm5974: switched to %s mode.\n",
> + dev_dbg(&dev->intf->dev, "switched to %s mode.\n",
> on ? "wellspring" : "normal");
>
> out:
> @@ -718,7 +710,7 @@ static void bcm5974_irq_button(struct urb *urb)
> }
>
> if (report_bt_state(dev, dev->bt_urb->actual_length))
> - dprintk(1, "bcm5974: bad button package, length: %d\n",
> + dev_dbg(&intf->dev, "bad button package, length: %d\n",
> dev->bt_urb->actual_length);
>
> exit:
> @@ -753,7 +745,7 @@ static void bcm5974_irq_trackpad(struct urb *urb)
> goto exit;
>
> if (report_tp_state(dev, dev->tp_urb->actual_length))
> - dprintk(1, "bcm5974: bad trackpad package, length: %d\n",
> + dev_dbg(&intf->dev, "bad trackpad package, length: %d\n",
> dev->tp_urb->actual_length);
>
> exit:
> @@ -786,7 +778,7 @@ static int bcm5974_start_traffic(struct bcm5974 *dev)
>
> error = bcm5974_wellspring_mode(dev, true);
> if (error) {
> - dprintk(1, "bcm5974: mode switch failed\n");
> + dev_dbg(&dev->intf->dev, "mode switch failed\n");
> goto err_out;
> }
>
Hi,
I just wanted to check if you had a chance to review it or if any changes are needed from my side.
Regards,
Bhanu Seshu Kumar Valluri
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-09 17:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-03 8:55 [PATCH v3] Input: bcm5974 - Driver cleanup by replacing dprintk with dev_dbg Bhanu Seshu Kumar Valluri
2025-09-15 14:14 ` bhanuseshukumar
2025-10-09 17:34 ` Bhanu Seshu Kumar Valluri
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.