All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Sarthak Garg <quic_sartgarg@quicinc.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	quic_nguyenb@quicinc.com, quic_rampraka@quicinc.com,
	quic_pragalla@quicinc.com, quic_sayalil@quicinc.com,
	quic_nitirawa@quicinc.com, quic_bhaskarv@quicinc.com,
	kernel@oss.qualcomm.com
Subject: Re: [PATCH V5 2/4] dt-bindings: mmc: controller: Add max-sd-hs-frequency property
Date: Wed, 3 Sep 2025 15:39:28 -0500	[thread overview]
Message-ID: <20250903203928.GA2663015-robh@kernel.org> (raw)
In-Reply-To: <20250903080404.3260135-3-quic_sartgarg@quicinc.com>

On Wed, Sep 03, 2025 at 01:34:02PM +0530, Sarthak Garg wrote:
> Some platforms may require limiting the maximum frequency used in SD
> High-Speed (HS) mode due to board-level hardware constraints. For
> example, certain boards may include level shifters or other components
> that cannot reliably operate at the default 50 MHz HS frequency.
> 
> Introduce a new optional device tree property max-sd-hs-frequency to
> limit the maximum frequency (in Hz) used for SD cards operating in
> High-Speed (HS) mode.
> 
> Signed-off-by: Sarthak Garg <quic_sartgarg@quicinc.com>
> ---
>  .../devicetree/bindings/mmc/mmc-controller-common.yaml    | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml
> index 9a7235439759..d6b785cb2bd9 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml
> @@ -93,6 +93,14 @@ properties:
>      minimum: 400000
>      maximum: 384000000
>  
> +  max-sd-hs-hz:
> +    description: |
> +      Maximum frequency (in Hz) to be used for SD cards operating in
> +      High-Speed (HS) mode. This is useful for board-specific limitations,
> +      such as level shifters or others where the card cannot reliably
> +      operate at the default 50 MHz HS frequency.
> +    default: 50000000

Why doesn't max-frequency work for you? I would think frequency limits 
wouldn't really depend on the mode.

> +
>    disable-wp:
>      $ref: /schemas/types.yaml#/definitions/flag
>      description:
> -- 
> 2.34.1
> 

  parent reply	other threads:[~2025-09-03 20:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-03  8:04 [PATCH V5 0/4] Add level shifter support for qualcomm SOC's Sarthak Garg
2025-09-03  8:04 ` [PATCH V5 1/4] mmc: sdhci-msm: Enable tuning for SDR50 mode for SD card Sarthak Garg
2025-09-03  8:04 ` [PATCH V5 2/4] dt-bindings: mmc: controller: Add max-sd-hs-frequency property Sarthak Garg
2025-09-03  8:22   ` Krzysztof Kozlowski
2025-09-04  8:07     ` Sarthak Garg
2025-09-03 20:39   ` Rob Herring [this message]
2025-09-04  8:15     ` Sarthak Garg
2025-09-03  8:04 ` [PATCH V5 3/4] mmc: core: Introduce a new flag max-sd-hs-hz Sarthak Garg
2025-09-03  8:04 ` [PATCH V5 4/4] arm64: dts: qcom: sm8550: Add max-sd-hs-hz property Sarthak Garg
2025-09-03  8:21   ` Krzysztof Kozlowski
2025-09-04  8:36     ` Konrad Dybcio
2025-09-04 10:51       ` Krzysztof Kozlowski
2025-09-04 10:52         ` Krzysztof Kozlowski
2025-09-04 12:27           ` Konrad Dybcio
2025-09-04 13:07             ` Krzysztof Kozlowski
2025-09-04 14:50               ` Konrad Dybcio
2025-09-05 10:13                 ` Sarthak Garg
2025-09-03  8:24 ` [PATCH V5 0/4] Add level shifter support for qualcomm SOC's Dragan Simic
2025-09-03 20:42   ` Rob Herring
2025-09-04  5:28     ` Dragan Simic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250903203928.GA2663015-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=quic_bhaskarv@quicinc.com \
    --cc=quic_nguyenb@quicinc.com \
    --cc=quic_nitirawa@quicinc.com \
    --cc=quic_pragalla@quicinc.com \
    --cc=quic_rampraka@quicinc.com \
    --cc=quic_sartgarg@quicinc.com \
    --cc=quic_sayalil@quicinc.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.