From: Rob Herring <robh@kernel.org>
To: Dragan Simic <dsimic@manjaro.org>
Cc: Sarthak Garg <quic_sartgarg@quicinc.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
quic_nguyenb@quicinc.com, quic_rampraka@quicinc.com,
quic_pragalla@quicinc.com, quic_sayalil@quicinc.com,
quic_nitirawa@quicinc.com, quic_bhaskarv@quicinc.com,
kernel@oss.qualcomm.com
Subject: Re: [PATCH V5 0/4] Add level shifter support for qualcomm SOC's
Date: Wed, 3 Sep 2025 15:42:58 -0500 [thread overview]
Message-ID: <20250903204258.GB2663015-robh@kernel.org> (raw)
In-Reply-To: <3453985c13aa51d068c0174e51e378fb@manjaro.org>
On Wed, Sep 03, 2025 at 10:24:55AM +0200, Dragan Simic wrote:
> Hello Sarthak and Krzysztof,
>
> On 2025-09-03 10:04, Sarthak Garg wrote:
> > Add level shifter support for qualcomm SOC's.
> >
> > - Changed from v4
> > - As suggested by Krzysztof Kozlowski Renamed the property from
> > `max-sd-hs-frequency` to `max-sd-hs-hz` for clarity.
>
> I just spotted this series, so I'm sorry for jumping in late. To me,
> "max-sd-hs-frequency" was actually a better choice, because it goes
> together with the already existing "max-frequency" property.
>
> Yes, "max-sd-hs-hz" is obviously more clear, but to me, consistency
> is more important. Just my $.02.
It's about defining the property units as 'frequency' could be kHz, MHz,
etc. Unfortunately 'max-frequency' existed before standardizing with
units.
Rob
next prev parent reply other threads:[~2025-09-03 20:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 8:04 [PATCH V5 0/4] Add level shifter support for qualcomm SOC's Sarthak Garg
2025-09-03 8:04 ` [PATCH V5 1/4] mmc: sdhci-msm: Enable tuning for SDR50 mode for SD card Sarthak Garg
2025-09-03 8:04 ` [PATCH V5 2/4] dt-bindings: mmc: controller: Add max-sd-hs-frequency property Sarthak Garg
2025-09-03 8:22 ` Krzysztof Kozlowski
2025-09-04 8:07 ` Sarthak Garg
2025-09-03 20:39 ` Rob Herring
2025-09-04 8:15 ` Sarthak Garg
2025-09-03 8:04 ` [PATCH V5 3/4] mmc: core: Introduce a new flag max-sd-hs-hz Sarthak Garg
2025-09-03 8:04 ` [PATCH V5 4/4] arm64: dts: qcom: sm8550: Add max-sd-hs-hz property Sarthak Garg
2025-09-03 8:21 ` Krzysztof Kozlowski
2025-09-04 8:36 ` Konrad Dybcio
2025-09-04 10:51 ` Krzysztof Kozlowski
2025-09-04 10:52 ` Krzysztof Kozlowski
2025-09-04 12:27 ` Konrad Dybcio
2025-09-04 13:07 ` Krzysztof Kozlowski
2025-09-04 14:50 ` Konrad Dybcio
2025-09-05 10:13 ` Sarthak Garg
2025-09-03 8:24 ` [PATCH V5 0/4] Add level shifter support for qualcomm SOC's Dragan Simic
2025-09-03 20:42 ` Rob Herring [this message]
2025-09-04 5:28 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903204258.GB2663015-robh@kernel.org \
--to=robh@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=kernel@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=quic_bhaskarv@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_pragalla@quicinc.com \
--cc=quic_rampraka@quicinc.com \
--cc=quic_sartgarg@quicinc.com \
--cc=quic_sayalil@quicinc.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.