All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Philip Molloy <philip@philipmolloy.com>
Cc: buildroot@buildroot.org,
	Michael Hennerich <michael.hennerich@analog.com>,
	Philip Molloy <philip.molloy@analog.com>,
	Eric Le Bihan <eric.le.bihan.dev@free.fr>
Subject: Re: [Buildroot] [PATCH v2 1/2] package/adsp-ldr: new package
Date: Wed, 3 Sep 2025 21:30:26 +0200	[thread overview]
Message-ID: <20250903213026.063200a4@windsurf> (raw)
In-Reply-To: <20250903135005.1803497-2-philip@philipmolloy.com>

Hello Philip,

Thanks for this new iteration! This looks a LOT nicer! I actually only
have one comment below.

On Wed, 03 Sep 2025 13:50:09 +0000
Philip Molloy <philip@philipmolloy.com> wrote:

> +define HOST_ADSP_LDR_INSTALL_CMDS
> +	# The U-Boot Makefile expects ldr to be installed as part of the toolchain
> +	# shipped with the CrossCore Embedded Studio SDK

I asked to have a comment here, so I appreciate the fact that you added
one. But nobody knows what CrossCore Embedded Studio SDK is. And
actually the reason is not really that. It is "just" that U-Boot
expects the ldr tool to be prefixed with the $(CROSS_COMPILE) value.
From the U-Boot Makefile:

Makefile:LDR            = $(CROSS_COMPILE)ldr

So, the comment should be just:

# The U-Boot Makefile expects ldr to be prefixed by $(CROSS_COMPILE),
# hence the rename to $(TARGET_CROSS)ldr

I guess this can be fixed when applying.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-09-03 19:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-03 13:50 [Buildroot] [PATCH v2 0/2] Generate ADI ADSP boot streams Philip Molloy
2025-09-03 13:50 ` [Buildroot] [PATCH v2 1/2] package/adsp-ldr: new package Philip Molloy
2025-09-03 19:30   ` Thomas Petazzoni via buildroot [this message]
2025-09-03 13:50 ` [Buildroot] [PATCH v2 2/2] boot/uboot: add ADSP LDR binary format Philip Molloy
2025-09-03 19:32   ` Thomas Petazzoni via buildroot
2025-09-08 11:51     ` Philip Molloy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250903213026.063200a4@windsurf \
    --to=buildroot@buildroot.org \
    --cc=eric.le.bihan.dev@free.fr \
    --cc=michael.hennerich@analog.com \
    --cc=philip.molloy@analog.com \
    --cc=philip@philipmolloy.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.