From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Philip Molloy <philip@philipmolloy.com>
Cc: buildroot@buildroot.org,
Michael Hennerich <michael.hennerich@analog.com>,
Philip Molloy <philip.molloy@analog.com>
Subject: Re: [Buildroot] [PATCH v2 2/2] boot/uboot: add ADSP LDR binary format
Date: Wed, 3 Sep 2025 21:32:13 +0200 [thread overview]
Message-ID: <20250903213213.15ac10fa@windsurf> (raw)
In-Reply-To: <20250903135005.1803497-3-philip@philipmolloy.com>
Hello Philip,
Thanks for this v2, we're getting there!
On Wed, 03 Sep 2025 13:50:19 +0000
Philip Molloy <philip@philipmolloy.com> wrote:
> From: Philip Molloy <philip.molloy@analog.com>
>
> Signed-off-by: Philip Molloy <philip.molloy@analog.com>
> ---
> boot/uboot/Config.in | 4 ++++
> boot/uboot/uboot.mk | 8 ++++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
> index a2301b7747..813a29828d 100644
> --- a/boot/uboot/Config.in
> +++ b/boot/uboot/Config.in
> @@ -479,6 +479,10 @@ config BR2_TARGET_UBOOT_FORMAT_QSPI_BIN
> file for flashing by combining the spl/boot.bin and
> u-boot.itb files into a unified binary.
>
> +config BR2_TARGET_UBOOT_FORMAT_ADSP_LDR
> + bool "u-boot.ldr"
> + depends on BR2_arm || BR2_aarch64
A little help text here would be nice, indicating on which platforms
this is relevant.
> +ifeq ($(BR2_TARGET_UBOOT_FORMAT_ADSP_LDR),y)
> +UBOOT_BINS += u-boot.ldr
> +endif
> +
> ifeq ($(BR2_TARGET_UBOOT_INITIAL_ENV),y)
> UBOOT_MAKE_TARGET += u-boot-initial-env
> define UBOOT_INSTALL_UBOOT_INITIAL_ENV
> @@ -257,6 +261,10 @@ UBOOT_MAKE_OPTS += TEE=$(BINARIES_DIR)/$(notdir $(ROCKCHIP_RKBIN_TEE_FILENAME))
> endif
> endif
>
> +ifeq ($(BR2_TARGET_UBOOT_FORMAT_ADSP_LDR),y)
> +UBOOT_DEPENDENCIES += host-adsp-ldr
> +endif
These two should be factored into one condition.
Like we have:
ifeq ($(BR2_TARGET_UBOOT_FORMAT_NAND),y)
UBOOT_BINS += u-boot.nand
UBOOT_MAKE_TARGET += u-boot.sb
UBOOT_DEPENDENCIES += host-elftosb host-openssl
endif
Just do:
ifeq ($(BR2_TARGET_UBOOT_FORMAT_ADSP_LDR),y)
UBOOT_BINS += u-boot.ldr
UBOOT_DEPENDENCIES += host-adsp-ldr
endif
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-09-03 19:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 13:50 [Buildroot] [PATCH v2 0/2] Generate ADI ADSP boot streams Philip Molloy
2025-09-03 13:50 ` [Buildroot] [PATCH v2 1/2] package/adsp-ldr: new package Philip Molloy
2025-09-03 19:30 ` Thomas Petazzoni via buildroot
2025-09-03 13:50 ` [Buildroot] [PATCH v2 2/2] boot/uboot: add ADSP LDR binary format Philip Molloy
2025-09-03 19:32 ` Thomas Petazzoni via buildroot [this message]
2025-09-08 11:51 ` Philip Molloy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903213213.15ac10fa@windsurf \
--to=buildroot@buildroot.org \
--cc=michael.hennerich@analog.com \
--cc=philip.molloy@analog.com \
--cc=philip@philipmolloy.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.