All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Fix ADI driver header dependencies
@ 2025-09-03 23:42 Greg Malysa
  2025-09-03 23:42 ` [PATCH 1/2] net: dwc_eth_qos_adi: Add missing header Greg Malysa
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Greg Malysa @ 2025-09-03 23:42 UTC (permalink / raw)
  To: u-boot
  Cc: philip.molloy, adsp-linux, Greg Malysa, Arturs Artamonovs,
	Ian Roberts, Jaehoon Chung, Joe Hershberger,
	Nathan Barrett-Morrison, Peng Fan, Ramon Fried, Tom Rini,
	Utsav Agarwal, Vasileios Bimpikas

Between 2025.07 and 2025.10 many header dependency chains were improved,
but this exposed implicit header usage in several of our drivers. This
wasn't discovered before or included in the original fixes because our
drivers are not yet used by any mainline-supported boards, so build
tests did not find them. This series addresses the two build failures
I've encountered while rebasing our work onto 2025.10 and continuing to
prepare the next submission of our board files.


Greg Malysa (2):
  net: dwc_eth_qos_adi: Add missing header
  mmc: adi_sdhci: Update headers

 drivers/mmc/adi_sdhci.c       | 1 +
 drivers/net/dwc_eth_qos_adi.c | 1 +
 2 files changed, 2 insertions(+)

-- 
2.45.2

base-commit: 76b8edbc732e327d1e56f08c641f51fdefdbff06
branch: dev/uboot2025.10-fixes

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] net: dwc_eth_qos_adi: Add missing header
  2025-09-03 23:42 [PATCH 0/2] Fix ADI driver header dependencies Greg Malysa
@ 2025-09-03 23:42 ` Greg Malysa
  2025-09-03 23:42 ` [PATCH 2/2] mmc: adi_sdhci: Update headers Greg Malysa
  2025-09-16 22:06 ` [PATCH 0/2] Fix ADI driver header dependencies Tom Rini
  2 siblings, 0 replies; 5+ messages in thread
From: Greg Malysa @ 2025-09-03 23:42 UTC (permalink / raw)
  To: u-boot
  Cc: philip.molloy, adsp-linux, Greg Malysa, Arturs Artamonovs,
	Ian Roberts, Joe Hershberger, Nathan Barrett-Morrison,
	Ramon Fried, Tom Rini, Utsav Agarwal, Vasileios Bimpikas

Following header dependency cleanups, an implicit dependence on env.h
was exposed in dwc_eth_qos_adi. However because this driver is not (yet)
enabled in any defconfigs, build tests did not identify the missing
header. This adds the missing #include so that the driver builds
correctly when enabled.

Signed-off-by: Greg Malysa <malysagreg@gmail.com>

---


---
 drivers/net/dwc_eth_qos_adi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/dwc_eth_qos_adi.c b/drivers/net/dwc_eth_qos_adi.c
index 0e6a901e303..fee50a88156 100644
--- a/drivers/net/dwc_eth_qos_adi.c
+++ b/drivers/net/dwc_eth_qos_adi.c
@@ -10,6 +10,7 @@
 
 #include <clk.h>
 #include <dm.h>
+#include <env.h>
 #include <net.h>
 #include <phy.h>
 #include <reset.h>
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] mmc: adi_sdhci: Update headers
  2025-09-03 23:42 [PATCH 0/2] Fix ADI driver header dependencies Greg Malysa
  2025-09-03 23:42 ` [PATCH 1/2] net: dwc_eth_qos_adi: Add missing header Greg Malysa
@ 2025-09-03 23:42 ` Greg Malysa
  2025-09-04  1:57   ` Peng Fan
  2025-09-16 22:06 ` [PATCH 0/2] Fix ADI driver header dependencies Tom Rini
  2 siblings, 1 reply; 5+ messages in thread
From: Greg Malysa @ 2025-09-03 23:42 UTC (permalink / raw)
  To: u-boot
  Cc: philip.molloy, adsp-linux, Greg Malysa, Arturs Artamonovs,
	Ian Roberts, Jaehoon Chung, Nathan Barrett-Morrison, Peng Fan,
	Tom Rini, Utsav Agarwal, Vasileios Bimpikas

As part of the header dependency cleanup between 2025.07 and 2025.10, an
implicit route to obtain SZ_128M from linux/sizes.h was removed. This
adds an explicit reference to linux/sizes.h to fix build failures for
this driver.

Signed-off-by: Greg Malysa <malysagreg@gmail.com>
---

 drivers/mmc/adi_sdhci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/adi_sdhci.c b/drivers/mmc/adi_sdhci.c
index 65a22cefb71..f58897b5218 100644
--- a/drivers/mmc/adi_sdhci.c
+++ b/drivers/mmc/adi_sdhci.c
@@ -15,6 +15,7 @@
 #include <malloc.h>
 #include <sdhci.h>
 #include <asm/cache.h>
+#include <linux/sizes.h>
 
 /* 400KHz is max freq for card ID etc. Use that as min */
 #define EMMC_MIN_FREQ	400000
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* RE: [PATCH 2/2] mmc: adi_sdhci: Update headers
  2025-09-03 23:42 ` [PATCH 2/2] mmc: adi_sdhci: Update headers Greg Malysa
@ 2025-09-04  1:57   ` Peng Fan
  0 siblings, 0 replies; 5+ messages in thread
From: Peng Fan @ 2025-09-04  1:57 UTC (permalink / raw)
  To: Greg Malysa, u-boot@lists.denx.de
  Cc: philip.molloy@analog.com, adsp-linux@analog.com,
	Arturs Artamonovs, Ian Roberts, Jaehoon Chung,
	Nathan Barrett-Morrison, Tom Rini, Utsav Agarwal,
	Vasileios Bimpikas

> Subject: [PATCH 2/2] mmc: adi_sdhci: Update headers
> 
> As part of the header dependency cleanup between 2025.07 and
> 2025.10, an implicit route to obtain SZ_128M from linux/sizes.h was
> removed. This adds an explicit reference to linux/sizes.h to fix build
> failures for this driver.
> 
> Signed-off-by: Greg Malysa <malysagreg@gmail.com>
> ---
> 
>  drivers/mmc/adi_sdhci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/adi_sdhci.c b/drivers/mmc/adi_sdhci.c index
> 65a22cefb71..f58897b5218 100644
> --- a/drivers/mmc/adi_sdhci.c
> +++ b/drivers/mmc/adi_sdhci.c
> @@ -15,6 +15,7 @@
>  #include <malloc.h>
>  #include <sdhci.h>
>  #include <asm/cache.h>
> +#include <linux/sizes.h>
> 

Reviewed-by: Peng Fan <peng.fan@nxp.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] Fix ADI driver header dependencies
  2025-09-03 23:42 [PATCH 0/2] Fix ADI driver header dependencies Greg Malysa
  2025-09-03 23:42 ` [PATCH 1/2] net: dwc_eth_qos_adi: Add missing header Greg Malysa
  2025-09-03 23:42 ` [PATCH 2/2] mmc: adi_sdhci: Update headers Greg Malysa
@ 2025-09-16 22:06 ` Tom Rini
  2 siblings, 0 replies; 5+ messages in thread
From: Tom Rini @ 2025-09-16 22:06 UTC (permalink / raw)
  To: u-boot, Greg Malysa
  Cc: philip.molloy, adsp-linux, Arturs Artamonovs, Ian Roberts,
	Jaehoon Chung, Joe Hershberger, Nathan Barrett-Morrison, Peng Fan,
	Ramon Fried, Utsav Agarwal, Vasileios Bimpikas

On Wed, 03 Sep 2025 19:42:00 -0400, Greg Malysa wrote:

> Between 2025.07 and 2025.10 many header dependency chains were improved,
> but this exposed implicit header usage in several of our drivers. This
> wasn't discovered before or included in the original fixes because our
> drivers are not yet used by any mainline-supported boards, so build
> tests did not find them. This series addresses the two build failures
> I've encountered while rebasing our work onto 2025.10 and continuing to
> prepare the next submission of our board files.
> 
> [...]

Applied to u-boot/next, thanks!

[1/2] net: dwc_eth_qos_adi: Add missing header
      commit: 56aa947c2ad6cbdf4e7a4281e83689ac3fbc8498
[2/2] mmc: adi_sdhci: Update headers
      commit: 2941e4c0476c69ef10e0900a8d9cac40a6dcc831
-- 
Tom



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-09-16 22:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-03 23:42 [PATCH 0/2] Fix ADI driver header dependencies Greg Malysa
2025-09-03 23:42 ` [PATCH 1/2] net: dwc_eth_qos_adi: Add missing header Greg Malysa
2025-09-03 23:42 ` [PATCH 2/2] mmc: adi_sdhci: Update headers Greg Malysa
2025-09-04  1:57   ` Peng Fan
2025-09-16 22:06 ` [PATCH 0/2] Fix ADI driver header dependencies Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.