From: Eric Biggers <ebiggers@kernel.org>
To: Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>,
linux-nfs@vger.kernel.org
Cc: NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Subject: Re: [PATCH] nfsd: Don't force CRYPTO_LIB_SHA256 to be built-in
Date: Wed, 3 Sep 2025 19:29:15 -0700 [thread overview]
Message-ID: <20250904022915.GA1345@sol> (raw)
In-Reply-To: <20250803212130.105700-1-ebiggers@kernel.org>
On Sun, Aug 03, 2025 at 02:21:30PM -0700, Eric Biggers wrote:
> Now that nfsd is accessing SHA-256 via the library API instead of via
> crypto_shash, there is a direct symbol dependency on the SHA-256 code
> and there is no benefit to be gained from forcing it to be built-in.
> Therefore, select CRYPTO_LIB_SHA256 from NFSD (conditional on NFSD_V4)
> instead of from NFSD_V4, so that it can be 'm' if NFSD is 'm'.
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
> fs/nfsd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Looks like this patch hasn't been applied yet. Could it be taken
through the nfs tree? Thanks,
- Eric
next prev parent reply other threads:[~2025-09-04 2:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-03 21:21 [PATCH] nfsd: Don't force CRYPTO_LIB_SHA256 to be built-in Eric Biggers
2025-08-04 11:54 ` Jeff Layton
2025-09-04 2:29 ` Eric Biggers [this message]
2025-09-04 13:21 ` Chuck Lever
2025-09-05 14:28 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250904022915.GA1345@sol \
--to=ebiggers@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.