From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Andreas Kemnade <akemnade@kernel.org>,
Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alistair Francis <alistair@alistair23.me>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Andreas Kemnade <akemnade@kernel.org>
Subject: Re: [PATCH 3/4] regulator: sy7636a: add gpios and input regulator
Date: Sun, 7 Sep 2025 14:26:24 +0300 [thread overview]
Message-ID: <202509071141.TSai6ltk-lkp@intel.com> (raw)
In-Reply-To: <20250906-sy7636-rsrc-v1-3-e2886a9763a7@kernel.org>
Hi Andreas,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Andreas-Kemnade/dt-bindings-mfd-sy7636a-Add-missing-gpio-pins-and-supply/20250906-171133
base: 1b237f190eb3d36f52dffe07a40b5eb210280e00
patch link: https://lore.kernel.org/r/20250906-sy7636-rsrc-v1-3-e2886a9763a7%40kernel.org
patch subject: [PATCH 3/4] regulator: sy7636a: add gpios and input regulator
config: x86_64-randconfig-161-20250907 (https://download.01.org/0day-ci/archive/20250907/202509071141.TSai6ltk-lkp@intel.com/config)
compiler: gcc-13 (Debian 13.3.0-16) 13.3.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202509071141.TSai6ltk-lkp@intel.com/
smatch warnings:
drivers/regulator/sy7636a-regulator.c:121 sy7636a_regulator_probe() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +121 drivers/regulator/sy7636a-regulator.c
8c485bedfb7852 Alistair Francis 2021-06-15 77 static int sy7636a_regulator_probe(struct platform_device *pdev)
8c485bedfb7852 Alistair Francis 2021-06-15 78 {
cb17820ef71ed7 Alistair Francis 2021-10-15 79 struct regmap *regmap = dev_get_regmap(pdev->dev.parent, NULL);
8c485bedfb7852 Alistair Francis 2021-06-15 80 struct regulator_config config = { };
8c485bedfb7852 Alistair Francis 2021-06-15 81 struct regulator_dev *rdev;
8c485bedfb7852 Alistair Francis 2021-06-15 82 struct gpio_desc *gdp;
d38d49b140043b Alistair Francis 2021-08-03 83 struct sy7636a_data *data;
8c485bedfb7852 Alistair Francis 2021-06-15 84 int ret;
8c485bedfb7852 Alistair Francis 2021-06-15 85
27fdd3bbb7a138 Alistair Francis 2021-08-06 86 if (!regmap)
8c485bedfb7852 Alistair Francis 2021-06-15 87 return -EPROBE_DEFER;
8c485bedfb7852 Alistair Francis 2021-06-15 88
07678e530d8eab Andreas Kemnade 2025-09-06 89 device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent);
07678e530d8eab Andreas Kemnade 2025-09-06 90
07678e530d8eab Andreas Kemnade 2025-09-06 91 gdp = devm_gpiod_get(&pdev->dev, "epd-pwr-good", GPIOD_IN);
8c485bedfb7852 Alistair Francis 2021-06-15 92 if (IS_ERR(gdp)) {
07678e530d8eab Andreas Kemnade 2025-09-06 93 dev_err(&pdev->dev, "Power good GPIO fault %ld\n", PTR_ERR(gdp));
8c485bedfb7852 Alistair Francis 2021-06-15 94 return PTR_ERR(gdp);
8c485bedfb7852 Alistair Francis 2021-06-15 95 }
8c485bedfb7852 Alistair Francis 2021-06-15 96
d38d49b140043b Alistair Francis 2021-08-03 97 data = devm_kzalloc(&pdev->dev, sizeof(struct sy7636a_data), GFP_KERNEL);
d38d49b140043b Alistair Francis 2021-08-03 98 if (!data)
d38d49b140043b Alistair Francis 2021-08-03 99 return -ENOMEM;
d38d49b140043b Alistair Francis 2021-08-03 100
27fdd3bbb7a138 Alistair Francis 2021-08-06 101 data->regmap = regmap;
d38d49b140043b Alistair Francis 2021-08-03 102 data->pgood_gpio = gdp;
d38d49b140043b Alistair Francis 2021-08-03 103
327603c2e83590 Andreas Kemnade 2025-09-06 104 ret = devm_regulator_get_enable_optional(&pdev->dev, "vin");
327603c2e83590 Andreas Kemnade 2025-09-06 105 if (ret)
327603c2e83590 Andreas Kemnade 2025-09-06 106 return dev_err_probe(&pdev->dev, ret,
327603c2e83590 Andreas Kemnade 2025-09-06 107 "failed to get vin regulator\n");
327603c2e83590 Andreas Kemnade 2025-09-06 108
327603c2e83590 Andreas Kemnade 2025-09-06 109 data->en_gpio = devm_gpiod_get_optional(&pdev->dev, "en",
327603c2e83590 Andreas Kemnade 2025-09-06 110 GPIOD_OUT_HIGH);
327603c2e83590 Andreas Kemnade 2025-09-06 111 if (IS_ERR(data->en_gpio))
327603c2e83590 Andreas Kemnade 2025-09-06 112 return dev_err_probe(&pdev->dev,
327603c2e83590 Andreas Kemnade 2025-09-06 113 PTR_ERR(data->en_gpio),
327603c2e83590 Andreas Kemnade 2025-09-06 114 "failed to get en gpio\n");
327603c2e83590 Andreas Kemnade 2025-09-06 115
327603c2e83590 Andreas Kemnade 2025-09-06 116 /* Let VCOM just follow the default power on sequence */
327603c2e83590 Andreas Kemnade 2025-09-06 117 data->vcom_en_gpio = devm_gpiod_get_optional(&pdev->dev,
327603c2e83590 Andreas Kemnade 2025-09-06 118 "vcom-en", GPIOD_OUT_LOW);
327603c2e83590 Andreas Kemnade 2025-09-06 119 if (IS_ERR(data->vcom_en_gpio))
327603c2e83590 Andreas Kemnade 2025-09-06 120 return dev_err_probe(&pdev->dev,
327603c2e83590 Andreas Kemnade 2025-09-06 @121 PTR_ERR(data->en_gpio),
^^^^^^^^^^^^^
s/data->en_gpio/data->vcom_en_gpio/
327603c2e83590 Andreas Kemnade 2025-09-06 122 "failed to get en gpio\n");
327603c2e83590 Andreas Kemnade 2025-09-06 123
327603c2e83590 Andreas Kemnade 2025-09-06 124 if (data->en_gpio)
327603c2e83590 Andreas Kemnade 2025-09-06 125 usleep_range(2500, 4000);
327603c2e83590 Andreas Kemnade 2025-09-06 126
d38d49b140043b Alistair Francis 2021-08-03 127 platform_set_drvdata(pdev, data);
8c485bedfb7852 Alistair Francis 2021-06-15 128
27fdd3bbb7a138 Alistair Francis 2021-08-06 129 ret = regmap_write(regmap, SY7636A_REG_POWER_ON_DELAY_TIME, 0x0);
8c485bedfb7852 Alistair Francis 2021-06-15 130 if (ret) {
4cafe1aeb5fb4e Alistair Francis 2021-08-03 131 dev_err(pdev->dev.parent, "Failed to initialize regulator: %d\n", ret);
8c485bedfb7852 Alistair Francis 2021-06-15 132 return ret;
8c485bedfb7852 Alistair Francis 2021-06-15 133 }
8c485bedfb7852 Alistair Francis 2021-06-15 134
8c485bedfb7852 Alistair Francis 2021-06-15 135 config.dev = &pdev->dev;
27fdd3bbb7a138 Alistair Francis 2021-08-06 136 config.regmap = regmap;
8c485bedfb7852 Alistair Francis 2021-06-15 137
8c485bedfb7852 Alistair Francis 2021-06-15 138 rdev = devm_regulator_register(&pdev->dev, &desc, &config);
8c485bedfb7852 Alistair Francis 2021-06-15 139 if (IS_ERR(rdev)) {
4cafe1aeb5fb4e Alistair Francis 2021-08-03 140 dev_err(pdev->dev.parent, "Failed to register %s regulator\n",
8c485bedfb7852 Alistair Francis 2021-06-15 141 pdev->name);
8c485bedfb7852 Alistair Francis 2021-06-15 142 return PTR_ERR(rdev);
8c485bedfb7852 Alistair Francis 2021-06-15 143 }
8c485bedfb7852 Alistair Francis 2021-06-15 144
8c485bedfb7852 Alistair Francis 2021-06-15 145 return 0;
8c485bedfb7852 Alistair Francis 2021-06-15 146 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH 3/4] regulator: sy7636a: add gpios and input regulator
Date: Sun, 7 Sep 2025 11:50:20 +0800 [thread overview]
Message-ID: <202509071141.TSai6ltk-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250906-sy7636-rsrc-v1-3-e2886a9763a7@kernel.org>
References: <20250906-sy7636-rsrc-v1-3-e2886a9763a7@kernel.org>
TO: Andreas Kemnade <akemnade@kernel.org>
TO: Lee Jones <lee@kernel.org>
TO: Rob Herring <robh@kernel.org>
TO: Krzysztof Kozlowski <krzk@kernel.org>
TO: Conor Dooley <conor+dt@kernel.org>
TO: Alistair Francis <alistair@alistair23.me>
TO: Liam Girdwood <lgirdwood@gmail.com>
TO: Mark Brown <broonie@kernel.org>
TO: Shawn Guo <shawnguo@kernel.org>
TO: Sascha Hauer <s.hauer@pengutronix.de>
TO: Pengutronix Kernel Team <kernel@pengutronix.de>
TO: Fabio Estevam <festevam@gmail.com>
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: imx@lists.linux.dev
CC: linux-arm-kernel@lists.infradead.org
CC: Andreas Kemnade <akemnade@kernel.org>
Hi Andreas,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 1b237f190eb3d36f52dffe07a40b5eb210280e00]
url: https://github.com/intel-lab-lkp/linux/commits/Andreas-Kemnade/dt-bindings-mfd-sy7636a-Add-missing-gpio-pins-and-supply/20250906-171133
base: 1b237f190eb3d36f52dffe07a40b5eb210280e00
patch link: https://lore.kernel.org/r/20250906-sy7636-rsrc-v1-3-e2886a9763a7%40kernel.org
patch subject: [PATCH 3/4] regulator: sy7636a: add gpios and input regulator
:::::: branch date: 18 hours ago
:::::: commit date: 18 hours ago
config: x86_64-randconfig-161-20250907 (https://download.01.org/0day-ci/archive/20250907/202509071141.TSai6ltk-lkp@intel.com/config)
compiler: gcc-13 (Debian 13.3.0-16) 13.3.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202509071141.TSai6ltk-lkp@intel.com/
smatch warnings:
drivers/regulator/sy7636a-regulator.c:121 sy7636a_regulator_probe() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +121 drivers/regulator/sy7636a-regulator.c
8c485bedfb7852 Alistair Francis 2021-06-15 76
8c485bedfb7852 Alistair Francis 2021-06-15 77 static int sy7636a_regulator_probe(struct platform_device *pdev)
8c485bedfb7852 Alistair Francis 2021-06-15 78 {
cb17820ef71ed7 Alistair Francis 2021-10-15 79 struct regmap *regmap = dev_get_regmap(pdev->dev.parent, NULL);
8c485bedfb7852 Alistair Francis 2021-06-15 80 struct regulator_config config = { };
8c485bedfb7852 Alistair Francis 2021-06-15 81 struct regulator_dev *rdev;
8c485bedfb7852 Alistair Francis 2021-06-15 82 struct gpio_desc *gdp;
d38d49b140043b Alistair Francis 2021-08-03 83 struct sy7636a_data *data;
8c485bedfb7852 Alistair Francis 2021-06-15 84 int ret;
8c485bedfb7852 Alistair Francis 2021-06-15 85
27fdd3bbb7a138 Alistair Francis 2021-08-06 86 if (!regmap)
8c485bedfb7852 Alistair Francis 2021-06-15 87 return -EPROBE_DEFER;
8c485bedfb7852 Alistair Francis 2021-06-15 88
07678e530d8eab Andreas Kemnade 2025-09-06 89 device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent);
07678e530d8eab Andreas Kemnade 2025-09-06 90
07678e530d8eab Andreas Kemnade 2025-09-06 91 gdp = devm_gpiod_get(&pdev->dev, "epd-pwr-good", GPIOD_IN);
8c485bedfb7852 Alistair Francis 2021-06-15 92 if (IS_ERR(gdp)) {
07678e530d8eab Andreas Kemnade 2025-09-06 93 dev_err(&pdev->dev, "Power good GPIO fault %ld\n", PTR_ERR(gdp));
8c485bedfb7852 Alistair Francis 2021-06-15 94 return PTR_ERR(gdp);
8c485bedfb7852 Alistair Francis 2021-06-15 95 }
8c485bedfb7852 Alistair Francis 2021-06-15 96
d38d49b140043b Alistair Francis 2021-08-03 97 data = devm_kzalloc(&pdev->dev, sizeof(struct sy7636a_data), GFP_KERNEL);
d38d49b140043b Alistair Francis 2021-08-03 98 if (!data)
d38d49b140043b Alistair Francis 2021-08-03 99 return -ENOMEM;
d38d49b140043b Alistair Francis 2021-08-03 100
27fdd3bbb7a138 Alistair Francis 2021-08-06 101 data->regmap = regmap;
d38d49b140043b Alistair Francis 2021-08-03 102 data->pgood_gpio = gdp;
d38d49b140043b Alistair Francis 2021-08-03 103
327603c2e83590 Andreas Kemnade 2025-09-06 104 ret = devm_regulator_get_enable_optional(&pdev->dev, "vin");
327603c2e83590 Andreas Kemnade 2025-09-06 105 if (ret)
327603c2e83590 Andreas Kemnade 2025-09-06 106 return dev_err_probe(&pdev->dev, ret,
327603c2e83590 Andreas Kemnade 2025-09-06 107 "failed to get vin regulator\n");
327603c2e83590 Andreas Kemnade 2025-09-06 108
327603c2e83590 Andreas Kemnade 2025-09-06 109 data->en_gpio = devm_gpiod_get_optional(&pdev->dev, "en",
327603c2e83590 Andreas Kemnade 2025-09-06 110 GPIOD_OUT_HIGH);
327603c2e83590 Andreas Kemnade 2025-09-06 111 if (IS_ERR(data->en_gpio))
327603c2e83590 Andreas Kemnade 2025-09-06 112 return dev_err_probe(&pdev->dev,
327603c2e83590 Andreas Kemnade 2025-09-06 113 PTR_ERR(data->en_gpio),
327603c2e83590 Andreas Kemnade 2025-09-06 114 "failed to get en gpio\n");
327603c2e83590 Andreas Kemnade 2025-09-06 115
327603c2e83590 Andreas Kemnade 2025-09-06 116 /* Let VCOM just follow the default power on sequence */
327603c2e83590 Andreas Kemnade 2025-09-06 117 data->vcom_en_gpio = devm_gpiod_get_optional(&pdev->dev,
327603c2e83590 Andreas Kemnade 2025-09-06 118 "vcom-en", GPIOD_OUT_LOW);
327603c2e83590 Andreas Kemnade 2025-09-06 119 if (IS_ERR(data->vcom_en_gpio))
327603c2e83590 Andreas Kemnade 2025-09-06 120 return dev_err_probe(&pdev->dev,
327603c2e83590 Andreas Kemnade 2025-09-06 @121 PTR_ERR(data->en_gpio),
327603c2e83590 Andreas Kemnade 2025-09-06 122 "failed to get en gpio\n");
327603c2e83590 Andreas Kemnade 2025-09-06 123
327603c2e83590 Andreas Kemnade 2025-09-06 124 if (data->en_gpio)
327603c2e83590 Andreas Kemnade 2025-09-06 125 usleep_range(2500, 4000);
327603c2e83590 Andreas Kemnade 2025-09-06 126
d38d49b140043b Alistair Francis 2021-08-03 127 platform_set_drvdata(pdev, data);
8c485bedfb7852 Alistair Francis 2021-06-15 128
27fdd3bbb7a138 Alistair Francis 2021-08-06 129 ret = regmap_write(regmap, SY7636A_REG_POWER_ON_DELAY_TIME, 0x0);
8c485bedfb7852 Alistair Francis 2021-06-15 130 if (ret) {
4cafe1aeb5fb4e Alistair Francis 2021-08-03 131 dev_err(pdev->dev.parent, "Failed to initialize regulator: %d\n", ret);
8c485bedfb7852 Alistair Francis 2021-06-15 132 return ret;
8c485bedfb7852 Alistair Francis 2021-06-15 133 }
8c485bedfb7852 Alistair Francis 2021-06-15 134
8c485bedfb7852 Alistair Francis 2021-06-15 135 config.dev = &pdev->dev;
27fdd3bbb7a138 Alistair Francis 2021-08-06 136 config.regmap = regmap;
8c485bedfb7852 Alistair Francis 2021-06-15 137
8c485bedfb7852 Alistair Francis 2021-06-15 138 rdev = devm_regulator_register(&pdev->dev, &desc, &config);
8c485bedfb7852 Alistair Francis 2021-06-15 139 if (IS_ERR(rdev)) {
4cafe1aeb5fb4e Alistair Francis 2021-08-03 140 dev_err(pdev->dev.parent, "Failed to register %s regulator\n",
8c485bedfb7852 Alistair Francis 2021-06-15 141 pdev->name);
8c485bedfb7852 Alistair Francis 2021-06-15 142 return PTR_ERR(rdev);
8c485bedfb7852 Alistair Francis 2021-06-15 143 }
8c485bedfb7852 Alistair Francis 2021-06-15 144
8c485bedfb7852 Alistair Francis 2021-06-15 145 return 0;
8c485bedfb7852 Alistair Francis 2021-06-15 146 }
8c485bedfb7852 Alistair Francis 2021-06-15 147
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next parent reply other threads:[~2025-09-07 11:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-07 3:50 kernel test robot [this message]
2025-09-07 11:26 ` [PATCH 3/4] regulator: sy7636a: add gpios and input regulator Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2025-09-06 9:09 [PATCH 0/4] regulator: sy7636a: define and init all resources needed Andreas Kemnade
2025-09-06 9:09 ` [PATCH 1/4] dt-bindings: mfd: sy7636a: Add missing gpio pins and supply Andreas Kemnade
2025-09-06 12:01 ` Krzysztof Kozlowski
2025-09-08 10:54 ` Andreas Kemnade
2025-09-08 14:34 ` Mark Brown
2025-09-09 0:44 ` Rob Herring
2025-09-09 7:13 ` Andreas Kemnade
2025-09-06 9:09 ` [PATCH 2/4] regulator: sy7636a: fix lifecycle of power good gpio Andreas Kemnade
2025-09-06 14:35 ` Peng Fan
2025-09-08 8:00 ` Alistair
2025-09-06 9:09 ` [PATCH 3/4] regulator: sy7636a: add gpios and input regulator Andreas Kemnade
2025-09-06 14:32 ` Peng Fan
2025-09-06 9:09 ` [PATCH 4/4] ARM: dts: imx: e70k02: add sy7636 Andreas Kemnade
2025-09-08 8:07 ` Alistair
2025-09-09 13:34 ` (subset) [PATCH 0/4] regulator: sy7636a: define and init all resources needed Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202509071141.TSai6ltk-lkp@intel.com \
--to=dan.carpenter@linaro.org \
--cc=akemnade@kernel.org \
--cc=alistair@alistair23.me \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.