All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-arago][master][PATCH v2 0/3] opencl-clhpp v2.0.16 ->  v2024.05.08
@ 2025-09-05 23:38 a-christidis
  2025-09-05 23:38 ` [meta-arago][master][PATCH v2 1/3] meta-arago-test: recipes-extended: Cmake support for opencl-headers a-christidis
                   ` (4 more replies)
  0 siblings, 5 replies; 9+ messages in thread
From: a-christidis @ 2025-09-05 23:38 UTC (permalink / raw)
  To: meta-arago, reatmon

From: Antonios Christidis <a-christidis@ti.com> 

Dear all, 

The C OpenCL Headers are on version 2024.05.08, however the C++ are lagging
behind. With this patch series, I am bumping the C++ OpenCL headers also to
version 2024.05.08. 

The C++ headers, depend on cmake files from the C headers. The current
package was not providing them. I made some changes to correct this. 

This series is a v2 to the following: 
https://patchwork.yoctoproject.org/project/arago/list/?series=34239&state=*

Kind Regards,
Antonios


Antonios Christidis (3): meta-arago-test: recipes-extended: Cmake support
for opencl-headers meta-arago-test: recipes-extended: Specify correct PV
for ocl headers meta-arago-test: recipes-extended: opencl-clhpp v2.0.16 ->
v2024.05.08

 .../opencl/opencl-clhpp_%.bbappend               |  4 ++++
.../recipes-extended/opencl/opencl_clhpp-ti.inc  |  7 +++++++
.../opencl/opencl_headers-ti.inc                 | 16 ++++++++++++++++ 3
files changed, 27 insertions(+) create mode 100644
meta-arago-test/recipes-extended/opencl/opencl-clhpp_%.bbappend create mode
100644 meta-arago-test/recipes-extended/opencl/opencl_clhpp-ti.inc

-- 2.34.1



^ permalink raw reply	[flat|nested] 9+ messages in thread

* [meta-arago][master][PATCH v2 1/3] meta-arago-test: recipes-extended: Cmake support for opencl-headers
  2025-09-05 23:38 [meta-arago][master][PATCH v2 0/3] opencl-clhpp v2.0.16 -> v2024.05.08 a-christidis
@ 2025-09-05 23:38 ` a-christidis
  2025-09-05 23:38 ` [meta-arago][master][PATCH v2 2/3] meta-arago-test: recipes-extended: Specify correct PV for OCL C headers a-christidis
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 9+ messages in thread
From: a-christidis @ 2025-09-05 23:38 UTC (permalink / raw)
  To: meta-arago, reatmon

From: Antonios Christidis <a-christidis@ti.com>

In the meta-oe recipe, where the bbappend links from, the recipe does
not use cmake. It explicitly disabled do_configure and do_compile
tasks. While setting up a custom do_install task.

Since cmake support exists, use it. It will automatically
configure, build and install the header files, as well as cmake files.

Such cmake files are a dependency, for the c++ opencl headers.

Signed-off-by: Antonios Christidis <a-christidis@ti.com>
---

v2:
- Implemented the changes in a yocto compliant way, not by creating a new recipe outright

 .../recipes-extended/opencl/opencl_headers-ti.inc | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc b/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc
index 4dff02d9..48335204 100644
--- a/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc
+++ b/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc
@@ -1 +1,16 @@
+inherit cmake
+
 SRCREV = "8275634cf9ec31b6484c2e6be756237cb583999d"
+
+EXTRA_OECMAKE = "-DBUILD_TESTING=OFF"
+
+python() {
+    # Delete the noexec flags for the following tasks.
+    # Ensuring the tasks run.
+    d.delVarFlag("do_configure", "noexec")
+    d.delVarFlag("do_compile", "noexec")
+}
+
+do_install() {
+	cmake_do_install
+}
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [meta-arago][master][PATCH v2 2/3] meta-arago-test: recipes-extended: Specify correct PV for OCL C headers
  2025-09-05 23:38 [meta-arago][master][PATCH v2 0/3] opencl-clhpp v2.0.16 -> v2024.05.08 a-christidis
  2025-09-05 23:38 ` [meta-arago][master][PATCH v2 1/3] meta-arago-test: recipes-extended: Cmake support for opencl-headers a-christidis
@ 2025-09-05 23:38 ` a-christidis
  2025-09-08 15:21   ` Denys Dmytriyenko
  2025-09-05 23:38 ` [meta-arago][master][PATCH v2 3/3] meta-arago-test: recipes-extended: opencl-clhpp v2.0.16 -> v2024.05.08 a-christidis
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 9+ messages in thread
From: a-christidis @ 2025-09-05 23:38 UTC (permalink / raw)
  To: meta-arago, reatmon

From: Antonios Christidis <a-christidis@ti.com>

With the .bbappend and .inc file, the version of the headers is
increased. So, specify the correct PV of the headers.

Signed-off-by: Antonios Christidis <a-christidis@ti.com>
---
 meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc b/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc
index 48335204..1216adf5 100644
--- a/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc
+++ b/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc
@@ -1,6 +1,7 @@
 inherit cmake
 
 SRCREV = "8275634cf9ec31b6484c2e6be756237cb583999d"
+PV = "2024.05.08"
 
 EXTRA_OECMAKE = "-DBUILD_TESTING=OFF"
 
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [meta-arago][master][PATCH v2 3/3] meta-arago-test: recipes-extended: opencl-clhpp v2.0.16 -> v2024.05.08
  2025-09-05 23:38 [meta-arago][master][PATCH v2 0/3] opencl-clhpp v2.0.16 -> v2024.05.08 a-christidis
  2025-09-05 23:38 ` [meta-arago][master][PATCH v2 1/3] meta-arago-test: recipes-extended: Cmake support for opencl-headers a-christidis
  2025-09-05 23:38 ` [meta-arago][master][PATCH v2 2/3] meta-arago-test: recipes-extended: Specify correct PV for OCL C headers a-christidis
@ 2025-09-05 23:38 ` a-christidis
  2025-09-05 23:40 ` [meta-arago][master][PATCH v2 0/3] " PRC Automation
  2025-09-06  1:34 ` Andrew Davis
  4 siblings, 0 replies; 9+ messages in thread
From: a-christidis @ 2025-09-05 23:38 UTC (permalink / raw)
  To: meta-arago, reatmon

From: Antonios Christidis <a-christidis@ti.com>

Increase the version of the opencl c++ headers to v2024.05.08. This way
both c and c++ headers will be the same version.

Signed-off-by: Antonios Christidis <a-christidis@ti.com>
---

v2:
- Implemented the changes in a yocto compliant way, not by creating a new recipe outright

 .../recipes-extended/opencl/opencl-clhpp_%.bbappend        | 4 ++++
 .../recipes-extended/opencl/opencl_clhpp-ti.inc            | 7 +++++++
 2 files changed, 11 insertions(+)
 create mode 100644 meta-arago-test/recipes-extended/opencl/opencl-clhpp_%.bbappend
 create mode 100644 meta-arago-test/recipes-extended/opencl/opencl_clhpp-ti.inc

diff --git a/meta-arago-test/recipes-extended/opencl/opencl-clhpp_%.bbappend b/meta-arago-test/recipes-extended/opencl/opencl-clhpp_%.bbappend
new file mode 100644
index 00000000..6e486f4c
--- /dev/null
+++ b/meta-arago-test/recipes-extended/opencl/opencl-clhpp_%.bbappend
@@ -0,0 +1,4 @@
+OPENCL_HEADERS_TI = ""
+OPENCL_HEADERS_TI:ti-soc = "opencl_clhpp-ti.inc"
+
+require ${OPENCL_HEADERS_TI}
diff --git a/meta-arago-test/recipes-extended/opencl/opencl_clhpp-ti.inc b/meta-arago-test/recipes-extended/opencl/opencl_clhpp-ti.inc
new file mode 100644
index 00000000..ed43170c
--- /dev/null
+++ b/meta-arago-test/recipes-extended/opencl/opencl_clhpp-ti.inc
@@ -0,0 +1,7 @@
+SRCREV  = "0bdbbfe5ecda42cff50c96cc5e33527f42fcbd45"
+PV = "2024.05.08"
+
+DEPENDS = "opencl-headers"
+
+EXTRA_OECMAKE:append = " -DOPENCL_CLHPP_BUILD_TESTING=OFF \
+			 -DBUILD_TESTING=OFF"
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [meta-arago][master][PATCH v2 0/3] opencl-clhpp v2.0.16 ->  v2024.05.08
  2025-09-05 23:38 [meta-arago][master][PATCH v2 0/3] opencl-clhpp v2.0.16 -> v2024.05.08 a-christidis
                   ` (2 preceding siblings ...)
  2025-09-05 23:38 ` [meta-arago][master][PATCH v2 3/3] meta-arago-test: recipes-extended: opencl-clhpp v2.0.16 -> v2024.05.08 a-christidis
@ 2025-09-05 23:40 ` PRC Automation
  2025-09-06  1:34 ` Andrew Davis
  4 siblings, 0 replies; 9+ messages in thread
From: PRC Automation @ 2025-09-05 23:40 UTC (permalink / raw)
  To: Antonios Christidis; +Cc: meta-arago, reatmon

meta-arago / na / 20250905233849.2506703-1-a-christidis

PRC Results: FAIL

=========================================================
  check-yocto-patches: PASS
=========================================================
Patches
----------------------------------------
All patches passed



=========================================================
  apply-yocto-patch: FAIL
=========================================================
master
=====================
Summary:
- Patch Series: [meta-arago][master][PATCH v2 0/3] opencl-clhpp v2.0.16 ->  v2024.05.08
- Submitter: From: <a-christidis@ti.com>
From: Antonios Christidis <a-christidis@ti.com> 
- Date: Date: Fri, 5 Sep 2025 18:38:46 -0500
- Num Patches: 3
- Mailing List (public inbox) Commit SHA: 93b8b15fea3dafa11a204a71fc932cfa8521a8c5

Applied to:
- Repository: lcpd-prc-meta-arago
- Base Branch: master
- Commit Author: LCPD Automation Script <lcpdbld@list.ti.com>
- Commit Subject: CI/CD Auto-Merger: cicd.master.202508250100
- Commit SHA: 24d17d9be7261e4d78fa74d3f0e90c228a875519

Patches
----------------------------------------
FAIL - [meta-arago][master][PATCH v2 1/3] meta-arago-test: recipes-extended: Cmake support for opencl-headers
    error: meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc: does not exist in index
    Applying: meta-arago-test: recipes-extended: Cmake support for opencl-headers
    Patch failed at 0001 meta-arago-test: recipes-extended: Cmake support for opencl-headers





^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [meta-arago][master][PATCH v2 0/3] opencl-clhpp v2.0.16 -> v2024.05.08
  2025-09-05 23:38 [meta-arago][master][PATCH v2 0/3] opencl-clhpp v2.0.16 -> v2024.05.08 a-christidis
                   ` (3 preceding siblings ...)
  2025-09-05 23:40 ` [meta-arago][master][PATCH v2 0/3] " PRC Automation
@ 2025-09-06  1:34 ` Andrew Davis
  2025-09-08 13:47   ` Antonios Christidis
  4 siblings, 1 reply; 9+ messages in thread
From: Andrew Davis @ 2025-09-06  1:34 UTC (permalink / raw)
  To: a-christidis, meta-arago, reatmon

On 9/5/25 6:38 PM, Antonios Christidis via lists.yoctoproject.org wrote:
> From: Antonios Christidis <a-christidis@ti.com>
> 
> Dear all,
> 
> The C OpenCL Headers are on version 2024.05.08, however the C++ are lagging
> behind. With this patch series, I am bumping the C++ OpenCL headers also to
> version 2024.05.08.

I was going to suggest just updating these in meta-oe upstream, but looks
like the latest master branch has both the C and C++ headers at 2025.07.22
now, do you still need this at all on our master branch?

Andrew

> 
> The C++ headers, depend on cmake files from the C headers. The current
> package was not providing them. I made some changes to correct this.
> 
> This series is a v2 to the following:
> https://patchwork.yoctoproject.org/project/arago/list/?series=34239&state=*
> 
> Kind Regards,
> Antonios
> 
> 
> Antonios Christidis (3): meta-arago-test: recipes-extended: Cmake support
> for opencl-headers meta-arago-test: recipes-extended: Specify correct PV
> for ocl headers meta-arago-test: recipes-extended: opencl-clhpp v2.0.16 ->
> v2024.05.08
> 
>   .../opencl/opencl-clhpp_%.bbappend               |  4 ++++
> .../recipes-extended/opencl/opencl_clhpp-ti.inc  |  7 +++++++
> .../opencl/opencl_headers-ti.inc                 | 16 ++++++++++++++++ 3
> files changed, 27 insertions(+) create mode 100644
> meta-arago-test/recipes-extended/opencl/opencl-clhpp_%.bbappend create mode
> 100644 meta-arago-test/recipes-extended/opencl/opencl_clhpp-ti.inc
> 
> -- 2.34.1
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#16537): https://lists.yoctoproject.org/g/meta-arago/message/16537
> Mute This Topic: https://lists.yoctoproject.org/mt/115092087/3619733
> Group Owner: meta-arago+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-arago/unsub [afd@ti.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 
> 



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [meta-arago][master][PATCH v2 0/3] opencl-clhpp v2.0.16 -> v2024.05.08
  2025-09-06  1:34 ` Andrew Davis
@ 2025-09-08 13:47   ` Antonios Christidis
  0 siblings, 0 replies; 9+ messages in thread
From: Antonios Christidis @ 2025-09-08 13:47 UTC (permalink / raw)
  To: Andrew Davis, meta-arago, reatmon

Dear Andrew,


Mistake on my end, this series is meant for scarthgap not master.

Sorry !


Kind Regards,

Antonios

On 9/5/25 8:34 PM, Andrew Davis wrote:
> On 9/5/25 6:38 PM, Antonios Christidis via lists.yoctoproject.org wrote:
>> From: Antonios Christidis <a-christidis@ti.com>
>>
>> Dear all,
>>
>> The C OpenCL Headers are on version 2024.05.08, however the C++ are 
>> lagging
>> behind. With this patch series, I am bumping the C++ OpenCL headers 
>> also to
>> version 2024.05.08.
>
> I was going to suggest just updating these in meta-oe upstream, but looks
> like the latest master branch has both the C and C++ headers at 
> 2025.07.22
> now, do you still need this at all on our master branch?
>
> Andrew
>
>>
>> The C++ headers, depend on cmake files from the C headers. The current
>> package was not providing them. I made some changes to correct this.
>>
>> This series is a v2 to the following:
>> https://patchwork.yoctoproject.org/project/arago/list/?series=34239&state=* 
>>
>>
>> Kind Regards,
>> Antonios
>>
>>
>> Antonios Christidis (3): meta-arago-test: recipes-extended: Cmake 
>> support
>> for opencl-headers meta-arago-test: recipes-extended: Specify correct PV
>> for ocl headers meta-arago-test: recipes-extended: opencl-clhpp 
>> v2.0.16 ->
>> v2024.05.08
>>
>>   .../opencl/opencl-clhpp_%.bbappend               |  4 ++++
>> .../recipes-extended/opencl/opencl_clhpp-ti.inc  |  7 +++++++
>> .../opencl/opencl_headers-ti.inc                 | 16 ++++++++++++++++ 3
>> files changed, 27 insertions(+) create mode 100644
>> meta-arago-test/recipes-extended/opencl/opencl-clhpp_%.bbappend 
>> create mode
>> 100644 meta-arago-test/recipes-extended/opencl/opencl_clhpp-ti.inc
>>
>> -- 2.34.1
>>
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#16537): 
>> https://lists.yoctoproject.org/g/meta-arago/message/16537
>> Mute This Topic: https://lists.yoctoproject.org/mt/115092087/3619733
>> Group Owner: meta-arago+owner@lists.yoctoproject.org
>> Unsubscribe: https://lists.yoctoproject.org/g/meta-arago/unsub 
>> [afd@ti.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
>>
>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [meta-arago][master][PATCH v2 2/3] meta-arago-test: recipes-extended: Specify correct PV for OCL C headers
  2025-09-05 23:38 ` [meta-arago][master][PATCH v2 2/3] meta-arago-test: recipes-extended: Specify correct PV for OCL C headers a-christidis
@ 2025-09-08 15:21   ` Denys Dmytriyenko
  2025-09-08 16:02     ` Ryan Eatmon
  0 siblings, 1 reply; 9+ messages in thread
From: Denys Dmytriyenko @ 2025-09-08 15:21 UTC (permalink / raw)
  To: a-christidis; +Cc: meta-arago, reatmon

Please don't use "meta-arago-test: recipes-extended:" prefix in the commit 
summary (Subject) - it's very high level and absolutely useless.

The convention that OE layers use is to specify the "area:", which is usually 
the name of the recipe for a single change, or a common name for multiple 
changes in the same commit, e.g. "conf/machine:" or even "opencl:" here.

So, this would change current subject

"meta-arago-test: recipes-extended: Specify correct PV for OCL C headers"

into

"opencl-headers: specify correct PV"

And for #3:

"opencl-clhpp: update v2.0.16 -> v2024.05.08"

In other words, instead of doing this:

"blah: blah: blah: do foo for bar"

do this:

"bar: do foo"


On Fri, Sep 05, 2025 at 06:38:48PM -0500, Antonios Christidis via lists.yoctoproject.org wrote:
> From: Antonios Christidis <a-christidis@ti.com>
> 
> With the .bbappend and .inc file, the version of the headers is
> increased. So, specify the correct PV of the headers.
> 
> Signed-off-by: Antonios Christidis <a-christidis@ti.com>
> ---
>  meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc b/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc
> index 48335204..1216adf5 100644
> --- a/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc
> +++ b/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc
> @@ -1,6 +1,7 @@
>  inherit cmake
>  
>  SRCREV = "8275634cf9ec31b6484c2e6be756237cb583999d"
> +PV = "2024.05.08"
>  
>  EXTRA_OECMAKE = "-DBUILD_TESTING=OFF"
>  
> -- 
> 2.34.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [meta-arago][master][PATCH v2 2/3] meta-arago-test: recipes-extended: Specify correct PV for OCL C headers
  2025-09-08 15:21   ` Denys Dmytriyenko
@ 2025-09-08 16:02     ` Ryan Eatmon
  0 siblings, 0 replies; 9+ messages in thread
From: Ryan Eatmon @ 2025-09-08 16:02 UTC (permalink / raw)
  To: Denys Dmytriyenko, a-christidis; +Cc: meta-arago



On 9/8/2025 10:21 AM, Denys Dmytriyenko wrote:
> Please don't use "meta-arago-test: recipes-extended:" prefix in the commit
> summary (Subject) - it's very high level and absolutely useless.
> 
> The convention that OE layers use is to specify the "area:", which is usually
> the name of the recipe for a single change, or a common name for multiple
> changes in the same commit, e.g. "conf/machine:" or even "opencl:" here.
> 
> So, this would change current subject
> 
> "meta-arago-test: recipes-extended: Specify correct PV for OCL C headers"
> 
> into
> 
> "opencl-headers: specify correct PV"
> 
> And for #3:
> 
> "opencl-clhpp: update v2.0.16 -> v2024.05.08"
> 
> In other words, instead of doing this:
> 
> "blah: blah: blah: do foo for bar"
> 
> do this:
> 
> "bar: do foo"

I need to add a check to the PRC to flag this kind of thing.  I agree 
this level of subject tagging is not needed or desired.


> 
> On Fri, Sep 05, 2025 at 06:38:48PM -0500, Antonios Christidis via lists.yoctoproject.org wrote:
>> From: Antonios Christidis <a-christidis@ti.com>
>>
>> With the .bbappend and .inc file, the version of the headers is
>> increased. So, specify the correct PV of the headers.
>>
>> Signed-off-by: Antonios Christidis <a-christidis@ti.com>
>> ---
>>   meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc b/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc
>> index 48335204..1216adf5 100644
>> --- a/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc
>> +++ b/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc
>> @@ -1,6 +1,7 @@
>>   inherit cmake
>>   
>>   SRCREV = "8275634cf9ec31b6484c2e6be756237cb583999d"
>> +PV = "2024.05.08"
>>   
>>   EXTRA_OECMAKE = "-DBUILD_TESTING=OFF"
>>   
>> -- 
>> 2.34.1

-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2025-09-08 16:02 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-05 23:38 [meta-arago][master][PATCH v2 0/3] opencl-clhpp v2.0.16 -> v2024.05.08 a-christidis
2025-09-05 23:38 ` [meta-arago][master][PATCH v2 1/3] meta-arago-test: recipes-extended: Cmake support for opencl-headers a-christidis
2025-09-05 23:38 ` [meta-arago][master][PATCH v2 2/3] meta-arago-test: recipes-extended: Specify correct PV for OCL C headers a-christidis
2025-09-08 15:21   ` Denys Dmytriyenko
2025-09-08 16:02     ` Ryan Eatmon
2025-09-05 23:38 ` [meta-arago][master][PATCH v2 3/3] meta-arago-test: recipes-extended: opencl-clhpp v2.0.16 -> v2024.05.08 a-christidis
2025-09-05 23:40 ` [meta-arago][master][PATCH v2 0/3] " PRC Automation
2025-09-06  1:34 ` Andrew Davis
2025-09-08 13:47   ` Antonios Christidis

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.