From: Jakub Kicinski <kuba@kernel.org>
To: Kamal Heib <kheib@redhat.com>
Cc: netdev@vger.kernel.org, Veerasenareddy Burru <vburru@marvell.com>,
Sathesh Edara <sedara@marvell.com>,
Shinas Rasheed <srasheed@marvell.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Subject: Re: [PATCH net v2] octeon_ep: Validate the VF ID
Date: Wed, 10 Sep 2025 19:26:58 -0700 [thread overview]
Message-ID: <20250910192658.55383c60@kernel.org> (raw)
In-Reply-To: <20250909131020.1397422-1-kheib@redhat.com>
On Tue, 9 Sep 2025 09:10:20 -0400 Kamal Heib wrote:
> +static bool octep_is_vf_valid(struct octep_device *oct, int vf)
> +{
> + if (vf >= CFG_GET_ACTIVE_VFS(oct->conf)) {
> + dev_err(&oct->pdev->dev, "Invalid VF ID %d\n", vf);
> + return false;
perhaps a nit, but why did you choose dev_err() over netdev_err()?
The incoming handle is a netdev.
--
pw-bot: cr
next prev parent reply other threads:[~2025-09-11 2:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 13:10 [PATCH net v2] octeon_ep: Validate the VF ID Kamal Heib
2025-09-09 18:51 ` Simon Horman
2025-09-11 2:26 ` Jakub Kicinski [this message]
2025-09-11 16:57 ` Kamal Heib
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250910192658.55383c60@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=kheib@redhat.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=vburru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.