All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kamal Heib <kheib@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Veerasenareddy Burru <vburru@marvell.com>,
	Sathesh Edara <sedara@marvell.com>,
	Shinas Rasheed <srasheed@marvell.com>,
	"David S. Miller" <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>,
	Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Subject: Re: [PATCH net v2] octeon_ep: Validate the VF ID
Date: Thu, 11 Sep 2025 12:57:15 -0400	[thread overview]
Message-ID: <aML_a9kUmuv48r6H@lima-fedora> (raw)
In-Reply-To: <20250910192658.55383c60@kernel.org>

On Wed, Sep 10, 2025 at 07:26:58PM -0700, Jakub Kicinski wrote:
> On Tue,  9 Sep 2025 09:10:20 -0400 Kamal Heib wrote:
> > +static bool octep_is_vf_valid(struct octep_device *oct, int vf)
> > +{
> > +	if (vf >= CFG_GET_ACTIVE_VFS(oct->conf)) {
> > +		dev_err(&oct->pdev->dev, "Invalid VF ID %d\n", vf);
> > +		return false;
> 
> perhaps a nit, but why did you choose dev_err() over netdev_err()?
> The incoming handle is a netdev.

Thanks for your review.

I believe I saw one of the ethernet drivers using dev_err() instead of
netdev_err(), but I agree with you. I'll change it to netdev_err().


      reply	other threads:[~2025-09-11 16:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09 13:10 [PATCH net v2] octeon_ep: Validate the VF ID Kamal Heib
2025-09-09 18:51 ` Simon Horman
2025-09-11  2:26 ` Jakub Kicinski
2025-09-11 16:57   ` Kamal Heib [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aML_a9kUmuv48r6H@lima-fedora \
    --to=kheib@redhat.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=michal.swiatkowski@linux.intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sedara@marvell.com \
    --cc=srasheed@marvell.com \
    --cc=vburru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.