All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <cel@kernel.org>
To: <kdevops@lists.linux.dev>
Cc: Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v1 3/8] gen_hosts: Get the "separate kernel builder" workflow working again
Date: Wed, 10 Sep 2025 15:38:43 -0400	[thread overview]
Message-ID: <20250910193849.779453-4-cel@kernel.org> (raw)
In-Reply-To: <20250910193849.779453-1-cel@kernel.org>

From: Chuck Lever <chuck.lever@oracle.com>

The [all] group contained the wrong host name. This causes
"-m wait_for_connection -i all" to hang indefinitely.

The [dev] group was missing, resulting in needless warnings.

The only thing the linux workflow does is run a separate kernel
builder node. The separate logic for nixos and the service hosts
isn't needed, AFAICT.

Let's start over with a simple template.

Fixes: 40df5ef72d19 ("gen_hosts: use kdevops_workflow_name directly for template selection")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 .../gen_hosts/templates/workflows/linux.j2    | 97 +------------------
 1 file changed, 3 insertions(+), 94 deletions(-)

diff --git a/playbooks/roles/gen_hosts/templates/workflows/linux.j2 b/playbooks/roles/gen_hosts/templates/workflows/linux.j2
index 5d9ebb67e900..6a1459d873ae 100644
--- a/playbooks/roles/gen_hosts/templates/workflows/linux.j2
+++ b/playbooks/roles/gen_hosts/templates/workflows/linux.j2
@@ -1,110 +1,19 @@
-{# Template for Linux custom kernel workflow #}
+{# Template for the kernel builder workflow #}
 [all]
 localhost ansible_connection=local
-{% if kdevops_enable_nixos|default(false) %}
-{{ kdevops_host_prefix }} ansible_python_interpreter=/run/current-system/sw/bin/python3
-{% else %}
-{{ kdevops_host_prefix }}
-{% endif %}
-{% if kdevops_baseline_and_dev == True %}
-{% if kdevops_enable_nixos|default(false) %}
-{{ kdevops_host_prefix }}-dev ansible_python_interpreter=/run/current-system/sw/bin/python3
-{% else %}
-{{ kdevops_host_prefix }}-dev
-{% endif %}
-{% endif %}
-{% if kdevops_enable_iscsi %}
-{{ kdevops_host_prefix }}-iscsi
-{% endif %}
-{% if kdevops_nfsd_enable %}
-{{ kdevops_host_prefix }}-nfsd
-{% endif %}
-{% if kdevops_smbd_enable|default(false) %}
-{{ kdevops_host_prefix }}-smbd
-{% endif %}
-{% if kdevops_krb5kdc_enable|default(false) %}
-{{ kdevops_host_prefix }}-kdc
-{% endif %}
-
+{{ kdevops_hosts_prefix }}-builder
 [all:vars]
 ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
 
 [baseline]
-{% if kdevops_enable_nixos|default(false) %}
-{{ kdevops_host_prefix }} ansible_python_interpreter=/run/current-system/sw/bin/python3
-{% else %}
-{{ kdevops_host_prefix }}
-{% endif %}
-
+{{ kdevops_hosts_prefix }}-builder
 [baseline:vars]
 ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
 
-{% if kdevops_baseline_and_dev %}
 [dev]
-{% if kdevops_enable_nixos|default(false) %}
-{{ kdevops_host_prefix }}-dev ansible_python_interpreter=/run/current-system/sw/bin/python3
-{% else %}
-{{ kdevops_host_prefix }}-dev
-{% endif %}
-
 [dev:vars]
 ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
-{% endif %}
-
-[linux]
-{{ kdevops_host_prefix }}
-{% if kdevops_baseline_and_dev == True %}
-{{ kdevops_host_prefix }}-dev
-{% endif %}
-
-[linux:vars]
-ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
-
-{% if kdevops_enable_iscsi %}
-[iscsi]
-{{ kdevops_host_prefix }}-iscsi
-
-[iscsi:vars]
-ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
-{% endif %}
-
-{% if kdevops_nfsd_enable %}
-[nfsd]
-{{ kdevops_host_prefix }}-nfsd
-
-[nfsd:vars]
-ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
-{% endif %}
-
-{% if kdevops_smbd_enable|default(false) %}
-[smbd]
-{{ kdevops_host_prefix }}-smbd
-
-[smbd:vars]
-ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
-{% endif %}
-
-{% if kdevops_krb5kdc_enable|default(false) %}
-[kdc]
-{{ kdevops_host_prefix }}-kdc
-
-[kdc:vars]
-ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
-{% endif %}
 
 [service]
-{% if kdevops_enable_iscsi %}
-{{ kdevops_host_prefix }}-iscsi
-{% endif %}
-{% if kdevops_nfsd_enable %}
-{{ kdevops_host_prefix }}-nfsd
-{% endif %}
-{% if kdevops_smbd_enable|default(false) %}
-{{ kdevops_host_prefix }}-smbd
-{% endif %}
-{% if kdevops_krb5kdc_enable|default(false) %}
-{{ kdevops_host_prefix }}-kdc
-{% endif %}
-
 [service:vars]
 ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
-- 
2.51.0


  parent reply	other threads:[~2025-09-10 19:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-10 19:38 [PATCH v1 0/8] Fixes for recent commits Chuck Lever
2025-09-10 19:38 ` [PATCH v1 1/8] gen_nodes: Re-title the playbook Chuck Lever
2025-09-10 19:38 ` [PATCH v1 2/8] devconfig: Remove "dnf update" optimizations for terraform hosts Chuck Lever
2025-09-10 19:38 ` Chuck Lever [this message]
2025-09-10 19:38 ` [PATCH v1 4/8] gen_hosts: Restore missing groups to the fstests hosts template Chuck Lever
2025-09-10 19:38 ` [PATCH v1 5/8] gen_hosts: Restore missing groups to the gitr " Chuck Lever
2025-09-10 19:38 ` [PATCH v1 6/8] gen_hosts: Restore missing groups to the ltp " Chuck Lever
2025-09-10 19:38 ` [PATCH v1 7/8] gen_hosts: Restore missing groups to the nfstest " Chuck Lever
2025-09-10 19:38 ` [PATCH v1 8/8] gen_hosts: Replace pynfs " Chuck Lever
2025-09-10 19:51 ` [PATCH v1 0/8] Fixes for recent commits Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250910193849.779453-4-cel@kernel.org \
    --to=cel@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=kdevops@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.