[PATCH net] Revert "net: usb: asix: ax88772: drop phylink use in PM to avoid MDIO runtime PM wakeups"

[PATCH net] Revert "net: usb: asix: ax88772: drop phylink use in PM to avoid MDIO runtime PM wakeups"

[Paolo Abeni]

This reverts commit 5537a4679403 ("net: usb: asix: ax88772: drop
phylink use in PM to avoid MDIO runtime PM wakeups"), it breaks
operation of asix ethernet usb dongle after system suspend-resume
cycle.

Link: https://lore.kernel.org/all/b5ea8296-f981-445d-a09a-2f389d7f6fdd@samsung.com/
Fixes: 5537a4679403 ("net: usb: asix: ax88772: drop phylink use in PM to avoid MDIO runtime PM wakeups")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
Since we have the net PR waiting for this one, I'll apply it very soon
unless someone screams very loudly in just a few mins :)
---
 drivers/net/usb/asix_devices.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
index 1e8f7089f5e8..792ddda1ad49 100644
--- a/drivers/net/usb/asix_devices.c
+++ b/drivers/net/usb/asix_devices.c
@@ -607,8 +607,15 @@ static const struct net_device_ops ax88772_netdev_ops = {
 
 static void ax88772_suspend(struct usbnet *dev)
 {
+	struct asix_common_private *priv = dev->driver_priv;
 	u16 medium;
 
+	if (netif_running(dev->net)) {
+		rtnl_lock();
+		phylink_suspend(priv->phylink, false);
+		rtnl_unlock();
+	}
+
 	/* Stop MAC operation */
 	medium = asix_read_medium_status(dev, 1);
 	medium &= ~AX_MEDIUM_RE;
@@ -637,6 +644,12 @@ static void ax88772_resume(struct usbnet *dev)
 	for (i = 0; i < 3; i++)
 		if (!priv->reset(dev, 1))
 			break;
+
+	if (netif_running(dev->net)) {
+		rtnl_lock();
+		phylink_resume(priv->phylink);
+		rtnl_unlock();
+	}
 }
 
 static int asix_resume(struct usb_interface *intf)
-- 
2.51.0

Re: [PATCH net] Revert "net: usb: asix: ax88772: drop phylink use in PM to avoid MDIO runtime PM wakeups"

[Jakub Kicinski]

On Thu, 11 Sep 2025 16:33:31 +0200 Paolo Abeni wrote:
> This reverts commit 5537a4679403 ("net: usb: asix: ax88772: drop
> phylink use in PM to avoid MDIO runtime PM wakeups"), it breaks
> operation of asix ethernet usb dongle after system suspend-resume
> cycle.
> 
> Link: https://lore.kernel.org/all/b5ea8296-f981-445d-a09a-2f389d7f6fdd@samsung.com/
> Fixes: 5537a4679403 ("net: usb: asix: ax88772: drop phylink use in PM to avoid MDIO runtime PM wakeups")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>

Acked-by: Jakub Kicinski <kuba@kernel.org>

Re: [PATCH net] Revert "net: usb: asix: ax88772: drop phylink use in PM to avoid MDIO runtime PM wakeups"

[Jakub Kicinski]

On Thu, 11 Sep 2025 07:38:58 -0700 Jakub Kicinski wrote:
> On Thu, 11 Sep 2025 16:33:31 +0200 Paolo Abeni wrote:
> > This reverts commit 5537a4679403 ("net: usb: asix: ax88772: drop
> > phylink use in PM to avoid MDIO runtime PM wakeups"), it breaks
> > operation of asix ethernet usb dongle after system suspend-resume
> > cycle.
> > 
> > Link: https://lore.kernel.org/all/b5ea8296-f981-445d-a09a-2f389d7f6fdd@samsung.com/
> > Fixes: 5537a4679403 ("net: usb: asix: ax88772: drop phylink use in PM to avoid MDIO runtime PM wakeups")
> > Signed-off-by: Paolo Abeni <pabeni@redhat.com>  
> 
> Acked-by: Jakub Kicinski <kuba@kernel.org>

Ah, missing:

Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>

Re: [PATCH net] Revert "net: usb: asix: ax88772: drop phylink use in PM to avoid MDIO runtime PM wakeups"

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Thu, 11 Sep 2025 16:33:31 +0200 you wrote:
> This reverts commit 5537a4679403 ("net: usb: asix: ax88772: drop
> phylink use in PM to avoid MDIO runtime PM wakeups"), it breaks
> operation of asix ethernet usb dongle after system suspend-resume
> cycle.
> 
> Link: https://lore.kernel.org/all/b5ea8296-f981-445d-a09a-2f389d7f6fdd@samsung.com/
> Fixes: 5537a4679403 ("net: usb: asix: ax88772: drop phylink use in PM to avoid MDIO runtime PM wakeups")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> 
> [...]

Here is the summary with links:
  - [net] Revert "net: usb: asix: ax88772: drop phylink use in PM to avoid MDIO runtime PM wakeups"
    https://git.kernel.org/netdev/net/c/63a796558bc2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html