[PATCH mptcp-next] Squash to "selftests: mptcp: userspace pm: validate deny-join-id0 flag"

[PATCH mptcp-next] Squash to "selftests: mptcp: userspace pm: validate deny-join-id0 flag"

[Matthieu Baerts (NGI0)]

Set net.mptcp.allow_join_initial_addr_port=0 on the client side, so it
also validates "mptcp: set remote_deny_join_id0 on SYN recv" commit.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
 tools/testing/selftests/net/mptcp/userspace_pm.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/net/mptcp/userspace_pm.sh b/tools/testing/selftests/net/mptcp/userspace_pm.sh
index 0801d57a9710..3d45991f24ed 100755
--- a/tools/testing/selftests/net/mptcp/userspace_pm.sh
+++ b/tools/testing/selftests/net/mptcp/userspace_pm.sh
@@ -201,8 +201,8 @@ make_connection()
 		is_v6="v4"
 	fi
 
-	# set this on the server side only: will not affect the rest
-	ip netns exec "$ns1" sysctl -q net.mptcp.allow_join_initial_addr_port=0
+	# set this on the client side only: will not affect the rest
+	ip netns exec "$ns2" sysctl -q net.mptcp.allow_join_initial_addr_port=0
 
 	:>"$client_evts"
 	:>"$server_evts"
@@ -242,7 +242,7 @@ make_connection()
 	print_test "Established IP${is_v6} MPTCP Connection ns2 => ns1"
 	if [ "${client_token}" != "" ] && [ "${server_token}" != "" ] &&
 	   [ "${client_serverside}" = 0 ] && [ "${server_serverside}" = 1 ] &&
-	   [ "${client_nojoin:-0}" = 1 ] && [ "${server_nojoin:-0}" = 0 ]
+	   [ "${client_nojoin:-0}" = 0 ] && [ "${server_nojoin:-0}" = 1 ]
 	then
 		test_pass
 		print_title "Connection info: ${client_addr}:${client_port} -> ${connect_addr}:${app_port}"
-- 
2.51.0

Re: [PATCH mptcp-next] Squash to "selftests: mptcp: userspace pm: validate deny-join-id0 flag"

[Matthieu Baerts]

Hello,

On 12/09/2025 14:38, Matthieu Baerts (NGI0) wrote:
> Set net.mptcp.allow_join_initial_addr_port=0 on the client side, so it
> also validates "mptcp: set remote_deny_join_id0 on SYN recv" commit.

No need to review this minor modification (I think). I then applied it:

New patches for t/upstream:
- aba32baed5b8: "squashed" in "selftests: mptcp: userspace pm: validate
deny-join-id0 flag"
- 0e19c6685422: conflict in
t/mptcp-pm-netlink-only-add-server-side-attr-when-true
- Results: 21725db7a7a9..01d3ba86f43b (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/26610d587d2eda62362ffdbf85c268a809c040a0/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.