From: Jakub Kicinski <kuba@kernel.org>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: netdev@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,
Simon Horman <horms@kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>,
intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-next 2/9] ice: move service task start out of ice_init_pf()
Date: Fri, 12 Sep 2025 16:19:38 -0700 [thread overview]
Message-ID: <20250912161938.1647096b@kernel.org> (raw)
In-Reply-To: <20250912130627.5015-3-przemyslaw.kitszel@intel.com>
On Fri, 12 Sep 2025 15:06:20 +0200 Przemek Kitszel wrote:
> + timer_setup(&pf->serv_tmr, ice_service_timer, 0);
> + pf->serv_tmr_period = HZ;
> + INIT_WORK(&pf->serv_task, ice_service_task);
> + clear_bit(ICE_SERVICE_SCHED, pf->state);
I should just read the code, but this looks like an open-coded
deferred_work ?
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: intel-wired-lan@lists.osuosl.org,
Tony Nguyen <anthony.l.nguyen@intel.com>,
netdev@vger.kernel.org, Michal Schmidt <mschmidt@redhat.com>,
Petr Oros <poros@redhat.com>, Simon Horman <horms@kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [PATCH iwl-next 2/9] ice: move service task start out of ice_init_pf()
Date: Fri, 12 Sep 2025 16:19:38 -0700 [thread overview]
Message-ID: <20250912161938.1647096b@kernel.org> (raw)
In-Reply-To: <20250912130627.5015-3-przemyslaw.kitszel@intel.com>
On Fri, 12 Sep 2025 15:06:20 +0200 Przemek Kitszel wrote:
> + timer_setup(&pf->serv_tmr, ice_service_timer, 0);
> + pf->serv_tmr_period = HZ;
> + INIT_WORK(&pf->serv_task, ice_service_task);
> + clear_bit(ICE_SERVICE_SCHED, pf->state);
I should just read the code, but this looks like an open-coded
deferred_work ?
next prev parent reply other threads:[~2025-09-12 23:28 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 13:06 [Intel-wired-lan] [PATCH iwl-next 0/9] ice: pospone service task disabling Przemek Kitszel
2025-09-12 13:06 ` Przemek Kitszel
2025-09-12 13:06 ` [Intel-wired-lan] [PATCH iwl-next 1/9] ice: enforce RTNL assumption of queue NAPI manipulation Przemek Kitszel
2025-09-12 13:06 ` Przemek Kitszel
2025-09-12 13:37 ` [Intel-wired-lan] " Paul Menzel
2025-09-15 10:00 ` Przemek Kitszel
2025-09-15 6:30 ` Loktionov, Aleksandr
2025-09-15 6:30 ` Loktionov, Aleksandr
2025-09-29 12:13 ` Rinitha, SX
2025-09-29 12:13 ` Rinitha, SX
2025-09-12 13:06 ` [Intel-wired-lan] [PATCH iwl-next 2/9] ice: move service task start out of ice_init_pf() Przemek Kitszel
2025-09-12 13:06 ` Przemek Kitszel
2025-09-12 23:19 ` Jakub Kicinski [this message]
2025-09-12 23:19 ` Jakub Kicinski
2025-09-15 11:01 ` [Intel-wired-lan] " Przemek Kitszel
2025-09-15 11:01 ` Przemek Kitszel
2025-09-15 15:19 ` [Intel-wired-lan] " Jakub Kicinski
2025-09-15 15:19 ` Jakub Kicinski
2025-09-29 12:17 ` [Intel-wired-lan] " Rinitha, SX
2025-09-29 12:17 ` Rinitha, SX
2025-09-12 13:06 ` [Intel-wired-lan] [PATCH iwl-next 3/9] ice: move ice_init_interrupt_scheme() prior ice_init_pf() Przemek Kitszel
2025-09-12 13:06 ` Przemek Kitszel
2025-09-15 6:31 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-09-15 6:31 ` Loktionov, Aleksandr
2025-09-29 12:25 ` Rinitha, SX
2025-09-29 12:25 ` Rinitha, SX
2025-09-12 13:06 ` [Intel-wired-lan] [PATCH iwl-next 4/9] ice: ice_init_pf: destroy mutexes and xarrays on memory alloc failure Przemek Kitszel
2025-09-12 13:06 ` Przemek Kitszel
2025-09-15 6:32 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-09-15 6:32 ` Loktionov, Aleksandr
2025-09-29 12:26 ` Rinitha, SX
2025-09-29 12:26 ` Rinitha, SX
2025-09-12 13:06 ` [Intel-wired-lan] [PATCH iwl-next 5/9] ice: move udp_tunnel_nic and misc IRQ setup into ice_init_pf() Przemek Kitszel
2025-09-12 13:06 ` Przemek Kitszel
2025-09-15 6:33 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-09-15 6:33 ` Loktionov, Aleksandr
2025-09-29 12:26 ` Rinitha, SX
2025-09-29 12:26 ` Rinitha, SX
2025-09-12 13:06 ` [Intel-wired-lan] [PATCH iwl-next 6/9] ice: move ice_init_pf() out of ice_init_dev() Przemek Kitszel
2025-09-12 13:06 ` Przemek Kitszel
2025-09-15 6:35 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-09-15 6:35 ` Loktionov, Aleksandr
2025-09-29 12:31 ` Rinitha, SX
2025-09-29 12:31 ` Rinitha, SX
2025-09-12 13:06 ` [Intel-wired-lan] [PATCH iwl-next 7/9] ice: extract ice_init_dev() from ice_init() Przemek Kitszel
2025-09-12 13:06 ` Przemek Kitszel
2025-09-15 6:36 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-09-15 6:36 ` Loktionov, Aleksandr
2025-09-29 12:31 ` Rinitha, SX
2025-09-29 12:31 ` Rinitha, SX
2025-09-12 13:06 ` [Intel-wired-lan] [PATCH iwl-next 8/9] ice: move ice_deinit_dev() to the end of deinit paths Przemek Kitszel
2025-09-12 13:06 ` Przemek Kitszel
2025-09-15 6:36 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-09-15 6:36 ` Loktionov, Aleksandr
2025-09-29 12:31 ` Rinitha, SX
2025-09-29 12:31 ` Rinitha, SX
2025-09-12 13:06 ` [Intel-wired-lan] [PATCH iwl-next 9/9] ice: remove duplicate call to ice_deinit_hw() on error paths Przemek Kitszel
2025-09-12 13:06 ` Przemek Kitszel
2025-09-15 6:37 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-09-15 6:37 ` Loktionov, Aleksandr
2025-09-29 12:32 ` Rinitha, SX
2025-09-29 12:32 ` Rinitha, SX
2025-09-12 13:37 ` [Intel-wired-lan] [PATCH iwl-next 0/9] ice: pospone service task disabling Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250912161938.1647096b@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.