From: Simon Horman <horms@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Jesse Brandeburg <jbrandeburg@cloudflare.com>,
Jakub Kicinski <kuba@kernel.org>,
Hariprasad Kelam <hkelam@marvell.com>,
Marcin Szycik <marcin.szycik@linux.intel.com>,
Rahul Rameshbabu <rrameshbabu@nvidia.com>,
netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
linux-doc@vger.kernel.org, corbet@lwn.net,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH v3 5/5] ice: refactor to use helpers
Date: Sat, 13 Sep 2025 10:07:10 +0100 [thread overview]
Message-ID: <20250913090710.GJ224143@horms.kernel.org> (raw)
In-Reply-To: <20250911-resend-jbrandeb-ice-standard-stats-v3-5-1bcffd157aa5@intel.com>
On Thu, Sep 11, 2025 at 04:40:41PM -0700, Jacob Keller wrote:
> From: Jesse Brandeburg <jesse.brandeburg@intel.com>
>
> Use the ice_netdev_to_pf() helper in more places and remove a bunch of
> boilerplate code. Not every instance could be replaced due to use of the
> netdev_priv() output or the vsi variable within a bunch of functions.
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 48 ++++++++------------------
> drivers/net/ethernet/intel/ice/ice_flex_pipe.c | 8 ++---
> drivers/net/ethernet/intel/ice/ice_lag.c | 3 +-
> drivers/net/ethernet/intel/ice/ice_main.c | 10 ++----
> drivers/net/ethernet/intel/ice/ice_ptp.c | 6 ++--
> drivers/net/ethernet/intel/ice/ice_sriov.c | 3 +-
> 6 files changed, 24 insertions(+), 54 deletions(-)
Less is more :)
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Jesse Brandeburg <jbrandeburg@cloudflare.com>,
Jakub Kicinski <kuba@kernel.org>,
Hariprasad Kelam <hkelam@marvell.com>,
Marcin Szycik <marcin.szycik@linux.intel.com>,
Rahul Rameshbabu <rrameshbabu@nvidia.com>,
netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
linux-doc@vger.kernel.org, corbet@lwn.net,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [PATCH v3 5/5] ice: refactor to use helpers
Date: Sat, 13 Sep 2025 10:07:10 +0100 [thread overview]
Message-ID: <20250913090710.GJ224143@horms.kernel.org> (raw)
In-Reply-To: <20250911-resend-jbrandeb-ice-standard-stats-v3-5-1bcffd157aa5@intel.com>
On Thu, Sep 11, 2025 at 04:40:41PM -0700, Jacob Keller wrote:
> From: Jesse Brandeburg <jesse.brandeburg@intel.com>
>
> Use the ice_netdev_to_pf() helper in more places and remove a bunch of
> boilerplate code. Not every instance could be replaced due to use of the
> netdev_priv() output or the vsi variable within a bunch of functions.
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 48 ++++++++------------------
> drivers/net/ethernet/intel/ice/ice_flex_pipe.c | 8 ++---
> drivers/net/ethernet/intel/ice/ice_lag.c | 3 +-
> drivers/net/ethernet/intel/ice/ice_main.c | 10 ++----
> drivers/net/ethernet/intel/ice/ice_ptp.c | 6 ++--
> drivers/net/ethernet/intel/ice/ice_sriov.c | 3 +-
> 6 files changed, 24 insertions(+), 54 deletions(-)
Less is more :)
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-09-13 9:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 23:40 [Intel-wired-lan] [PATCH v3 0/5] ice: add standard stats Jacob Keller
2025-09-11 23:40 ` Jacob Keller
2025-09-11 23:40 ` [Intel-wired-lan] [PATCH v3 1/5] net: docs: add missing features that can have stats Jacob Keller
2025-09-11 23:40 ` Jacob Keller
2025-09-11 23:40 ` [Intel-wired-lan] [PATCH v3 2/5] ice: implement ethtool standard stats Jacob Keller
2025-09-11 23:40 ` Jacob Keller
2025-10-09 8:56 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-10-09 8:56 ` Loktionov, Aleksandr
2025-09-11 23:40 ` [Intel-wired-lan] [PATCH v3 3/5] ice: add tracking of good transmit timestamps Jacob Keller
2025-09-11 23:40 ` Jacob Keller
2025-10-09 8:52 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-10-09 8:52 ` Loktionov, Aleksandr
2025-09-11 23:40 ` [Intel-wired-lan] [PATCH v3 4/5] ice: implement transmit hardware timestamp statistics Jacob Keller
2025-09-11 23:40 ` Jacob Keller
2025-09-11 23:40 ` [Intel-wired-lan] [PATCH v3 5/5] ice: refactor to use helpers Jacob Keller
2025-09-11 23:40 ` Jacob Keller
2025-09-12 7:46 ` [Intel-wired-lan] " Przemek Kitszel
2025-09-15 22:26 ` Jacob Keller
2025-09-13 9:07 ` Simon Horman [this message]
2025-09-13 9:07 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250913090710.GJ224143@horms.kernel.org \
--to=horms@kernel.org \
--cc=corbet@lwn.net \
--cc=hkelam@marvell.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jbrandeburg@cloudflare.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=marcin.szycik@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=rrameshbabu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.