[PATCH v2 0/2] dt-bindings: mmc: ti,omap2430-sdhci: Add json schema for the text binding

[PATCH v2 0/2] dt-bindings: mmc: ti,omap2430-sdhci: Add json schema for the text binding

[Charan Pedumuru]

Create a YAML binding for ti,omap2430-sdhci and drop unnecessary or
unused properties from the DTS.

Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
---
Changes in v2:
- Changed MAINTAINERS to "Kishon Vijay Abraham".
- Renamed the YAML file name to "ti,omap2430-sdhci.yaml" from
  "sdhci-omap.yaml".
- Dropped unnecessary or unused properties from DTS and made these
  changes as a seperate commit as there is no user of it.
- Removed previously defined properties like ti,needs-special-reset,
  ti,needs-special-hs-handling and cap-mmc-dual-data-rate from the YAML.
- Changed the commit message to elaborate the reasons for modifications.
- Removed the pattern property for pinctrl and redefined it in a regular format.
- Modified the description of the property "clock-frequency".
- Changed the subject line for the binding patch.
- Link to v1: https://lore.kernel.org/r/20250523-ti-sdhci-omap-v1-1-695c6eeac778@gmail.com

---
Charan Pedumuru (2):
      arm: dts: ti: omap: Drop unnecessary or unused properties
      dt-bindings: mmc: sdhci-omap: convert to DT schema

 .../devicetree/bindings/mmc/sdhci-omap.txt         |  43 ------
 .../devicetree/bindings/mmc/ti,omap2430-sdhci.yaml | 152 +++++++++++++++++++++
 .../ti/omap/am335x-sancloud-bbe-extended-wifi.dts  |   1 -
 arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi           |   2 -
 arch/arm/boot/dts/ti/omap/am33xx.dtsi              |   1 -
 arch/arm/boot/dts/ti/omap/am4372.dtsi              |   1 -
 arch/arm/boot/dts/ti/omap/am437x-l4.dtsi           |   2 -
 arch/arm/boot/dts/ti/omap/am5729-beagleboneai.dts  |   2 -
 arch/arm/boot/dts/ti/omap/am57xx-cl-som-am57x.dts  |   1 -
 arch/arm/boot/dts/ti/omap/omap4-l4.dtsi            |   5 -
 arch/arm/boot/dts/ti/omap/omap5-l4.dtsi            |   5 -
 11 files changed, 152 insertions(+), 63 deletions(-)
---
base-commit: ed61cb3d78d585209ec775933078e268544fe9a4
change-id: 20250519-ti-sdhci-omap-907f847f7530

Best regards,
-- 
Charan Pedumuru <charan.pedumuru@gmail.com>

[PATCH v2 1/2] arm: dts: ti: omap: Drop unnecessary or unused properties

[Charan Pedumuru]

Remove unnecessary properties like ti,needs-special-reset,
ti,needs-special-hs-handling and cap-mmc-dual-data-rate from the DTS
files as there is no user of them.

Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
---
 arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts | 1 -
 arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi                        | 2 --
 arch/arm/boot/dts/ti/omap/am33xx.dtsi                           | 1 -
 arch/arm/boot/dts/ti/omap/am4372.dtsi                           | 1 -
 arch/arm/boot/dts/ti/omap/am437x-l4.dtsi                        | 2 --
 arch/arm/boot/dts/ti/omap/am5729-beagleboneai.dts               | 2 --
 arch/arm/boot/dts/ti/omap/am57xx-cl-som-am57x.dts               | 1 -
 arch/arm/boot/dts/ti/omap/omap4-l4.dtsi                         | 5 -----
 arch/arm/boot/dts/ti/omap/omap5-l4.dtsi                         | 5 -----
 9 files changed, 20 deletions(-)

diff --git a/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts b/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts
index 7c9f65126c636178a5bee305480ed503ba40a5b6..8b47f45a9959c683cb821dd639ab7e17ffdda838 100644
--- a/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts
+++ b/arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts
@@ -87,7 +87,6 @@ &mmc3 {
 	bus-width = <4>;
 	non-removable;
 	cap-power-off-card;
-	ti,needs-special-hs-handling;
 	keep-power-in-suspend;
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc3_pins>;
diff --git a/arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi b/arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi
index d6a143abae5f6bec8041e27d5469727d641a0a1d..39278667a5a456613d0545f7e18438f73c8a3cf9 100644
--- a/arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi
+++ b/arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi
@@ -1501,7 +1501,6 @@ SYSC_OMAP2_SOFTRESET |
 
 			mmc1: mmc@0 {
 				compatible = "ti,am335-sdhci";
-				ti,needs-special-reset;
 				dmas = <&edma 24 0>, <&edma 25 0>;
 				dma-names = "tx", "rx";
 				interrupts = <64>;
@@ -1987,7 +1986,6 @@ SYSC_OMAP2_SOFTRESET |
 
 			mmc2: mmc@0 {
 				compatible = "ti,am335-sdhci";
-				ti,needs-special-reset;
 				dmas = <&edma 2 0
 					&edma 3 0>;
 				dma-names = "tx", "rx";
diff --git a/arch/arm/boot/dts/ti/omap/am33xx.dtsi b/arch/arm/boot/dts/ti/omap/am33xx.dtsi
index 0614ffdc1578f9a288683c59e4807e6adcab9466..f35f6b56e8f5a60741fd9a3e55933538814bb599 100644
--- a/arch/arm/boot/dts/ti/omap/am33xx.dtsi
+++ b/arch/arm/boot/dts/ti/omap/am33xx.dtsi
@@ -338,7 +338,6 @@ SYSC_OMAP2_SOFTRESET |
 
 			mmc3: mmc@0 {
 				compatible = "ti,am335-sdhci";
-				ti,needs-special-reset;
 				interrupts = <29>;
 				reg = <0x0 0x1000>;
 				status = "disabled";
diff --git a/arch/arm/boot/dts/ti/omap/am4372.dtsi b/arch/arm/boot/dts/ti/omap/am4372.dtsi
index 0a1df30f2818b2619d510773b95c773a97fe973e..504fa6b57d39bebee7140b4c7e3b475f69e2de81 100644
--- a/arch/arm/boot/dts/ti/omap/am4372.dtsi
+++ b/arch/arm/boot/dts/ti/omap/am4372.dtsi
@@ -321,7 +321,6 @@ SYSC_OMAP2_SOFTRESET |
 
 			mmc3: mmc@0 {
 				compatible = "ti,am437-sdhci";
-				ti,needs-special-reset;
 				interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
 				reg = <0x0 0x1000>;
 				status = "disabled";
diff --git a/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi b/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi
index fd4634f8c629370447425f3d5b9102802a753a76..e08f356e71cb0cf54830c3517209ede2acf11ab0 100644
--- a/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi
+++ b/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi
@@ -1103,7 +1103,6 @@ SYSC_OMAP2_SOFTRESET |
 			mmc1: mmc@0 {
 				compatible = "ti,am437-sdhci";
 				reg = <0x0 0x1000>;
-				ti,needs-special-reset;
 				dmas = <&edma 24 0>,
 					<&edma 25 0>;
 				dma-names = "tx", "rx";
@@ -1620,7 +1619,6 @@ SYSC_OMAP2_SOFTRESET |
 			mmc2: mmc@0 {
 				compatible = "ti,am437-sdhci";
 				reg = <0x0 0x1000>;
-				ti,needs-special-reset;
 				dmas = <&edma 2 0>,
 					<&edma 3 0>;
 				dma-names = "tx", "rx";
diff --git a/arch/arm/boot/dts/ti/omap/am5729-beagleboneai.dts b/arch/arm/boot/dts/ti/omap/am5729-beagleboneai.dts
index e6a18954e449e4b665bfb9ad8c67761347a93204..43cf4ade950b648408060cd8d1dd20c755b5ca06 100644
--- a/arch/arm/boot/dts/ti/omap/am5729-beagleboneai.dts
+++ b/arch/arm/boot/dts/ti/omap/am5729-beagleboneai.dts
@@ -545,7 +545,6 @@ &mmc2 {
 	non-removable;
 	mmc-pwrseq = <&emmc_pwrseq>;
 
-	ti,needs-special-reset;
 	dmas = <&sdma_xbar 47>, <&sdma_xbar 48>;
 	dma-names = "tx", "rx";
 
@@ -561,7 +560,6 @@ &mmc4 {
 	/* DDR50: DDR up to 50 MHz (1.8 V signaling). */
 	status = "okay";
 
-	ti,needs-special-reset;
 	vmmc-supply = <&vdd_3v3>;
 	cap-power-off-card;
 	keep-power-in-suspend;
diff --git a/arch/arm/boot/dts/ti/omap/am57xx-cl-som-am57x.dts b/arch/arm/boot/dts/ti/omap/am57xx-cl-som-am57x.dts
index 3dd898955e767ea506b85648224812454b2b1045..77c9fbb3bfbd82c3ed74be6b5222b1c94c074bdd 100644
--- a/arch/arm/boot/dts/ti/omap/am57xx-cl-som-am57x.dts
+++ b/arch/arm/boot/dts/ti/omap/am57xx-cl-som-am57x.dts
@@ -481,7 +481,6 @@ &mmc2 {
 	vmmc-supply = <&vdd_3v3>;
 	bus-width = <8>;
 	ti,non-removable;
-	cap-mmc-dual-data-rate;
 };
 
 &qspi {
diff --git a/arch/arm/boot/dts/ti/omap/omap4-l4.dtsi b/arch/arm/boot/dts/ti/omap/omap4-l4.dtsi
index 150dd84c9e0f749585de5fd4edb3bc673a8209ea..6a09166843694292cd4c37edd081ea89c28e1003 100644
--- a/arch/arm/boot/dts/ti/omap/omap4-l4.dtsi
+++ b/arch/arm/boot/dts/ti/omap/omap4-l4.dtsi
@@ -2153,7 +2153,6 @@ mmc1: mmc@0 {
 				reg = <0x0 0x400>;
 				interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
 				ti,dual-volt;
-				ti,needs-special-reset;
 				dmas = <&sdma 61>, <&sdma 62>;
 				dma-names = "tx", "rx";
 				pbias-supply = <&pbias_mmc_reg>;
@@ -2248,7 +2247,6 @@ mmc3: mmc@0 {
 				compatible = "ti,omap4-hsmmc";
 				reg = <0x0 0x400>;
 				interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
-				ti,needs-special-reset;
 				dmas = <&sdma 77>, <&sdma 78>;
 				dma-names = "tx", "rx";
 			};
@@ -2312,7 +2310,6 @@ mmc2: mmc@0 {
 				compatible = "ti,omap4-hsmmc";
 				reg = <0x0 0x400>;
 				interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
-				ti,needs-special-reset;
 				dmas = <&sdma 47>, <&sdma 48>;
 				dma-names = "tx", "rx";
 			};
@@ -2404,7 +2401,6 @@ mmc4: mmc@0 {
 				compatible = "ti,omap4-hsmmc";
 				reg = <0x0 0x400>;
 				interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
-				ti,needs-special-reset;
 				dmas = <&sdma 57>, <&sdma 58>;
 				dma-names = "tx", "rx";
 			};
@@ -2436,7 +2432,6 @@ mmc5: mmc@0 {
 				compatible = "ti,omap4-hsmmc";
 				reg = <0x0 0x400>;
 				interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
-				ti,needs-special-reset;
 				dmas = <&sdma 59>, <&sdma 60>;
 				dma-names = "tx", "rx";
 			};
diff --git a/arch/arm/boot/dts/ti/omap/omap5-l4.dtsi b/arch/arm/boot/dts/ti/omap/omap5-l4.dtsi
index 3b505fe415ed9e0f27f27080ddfec561be7eadc4..5a32296abdb925f651cab532e890f8659ef1b55c 100644
--- a/arch/arm/boot/dts/ti/omap/omap5-l4.dtsi
+++ b/arch/arm/boot/dts/ti/omap/omap5-l4.dtsi
@@ -1916,7 +1916,6 @@ mmc1: mmc@0 {
 				reg = <0x0 0x400>;
 				interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
 				ti,dual-volt;
-				ti,needs-special-reset;
 				dmas = <&sdma 61>, <&sdma 62>;
 				dma-names = "tx", "rx";
 				pbias-supply = <&pbias_mmc_reg>;
@@ -2004,7 +2003,6 @@ mmc3: mmc@0 {
 				compatible = "ti,omap4-hsmmc";
 				reg = <0x0 0x400>;
 				interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
-				ti,needs-special-reset;
 				dmas = <&sdma 77>, <&sdma 78>;
 				dma-names = "tx", "rx";
 			};
@@ -2044,7 +2042,6 @@ mmc2: mmc@0 {
 				compatible = "ti,omap4-hsmmc";
 				reg = <0x0 0x400>;
 				interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
-				ti,needs-special-reset;
 				dmas = <&sdma 47>, <&sdma 48>;
 				dma-names = "tx", "rx";
 			};
@@ -2136,7 +2133,6 @@ mmc4: mmc@0 {
 				compatible = "ti,omap4-hsmmc";
 				reg = <0x0 0x400>;
 				interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
-				ti,needs-special-reset;
 				dmas = <&sdma 57>, <&sdma 58>;
 				dma-names = "tx", "rx";
 			};
@@ -2168,7 +2164,6 @@ mmc5: mmc@0 {
 				compatible = "ti,omap4-hsmmc";
 				reg = <0x0 0x400>;
 				interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
-				ti,needs-special-reset;
 				dmas = <&sdma 59>, <&sdma 60>;
 				dma-names = "tx", "rx";
 			};

-- 
2.51.0

[PATCH v2 2/2] dt-bindings: mmc: sdhci-omap: convert to DT schema

[Charan Pedumuru]

Convert TI OMAP SDHCI Controller binding to YAML format.
Changes during Conversion:
- Define new properties like "clock-frequency"
  and "pbias-supply" to resolve errors detected by DTB_CHECK.
- Remove "ti,hwmods", "pinctrl-names" and "pinctrl-<n>"
  from required as they are not necessary for all DTS files and the
  text binding is misleading.
- Add missing strings like "default-rev11", "sdr12-rev11", "sdr25-rev11",
  "hs-rev11", "sdr25-rev11" and "sleep" to pinctrl-names string array.

Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
---
 .../devicetree/bindings/mmc/sdhci-omap.txt         |  43 ------
 .../devicetree/bindings/mmc/ti,omap2430-sdhci.yaml | 152 +++++++++++++++++++++
 2 files changed, 152 insertions(+), 43 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/sdhci-omap.txt b/Documentation/devicetree/bindings/mmc/sdhci-omap.txt
deleted file mode 100644
index f91e341e6b36c410275e6f993dd08400be3fc1f8..0000000000000000000000000000000000000000
--- a/Documentation/devicetree/bindings/mmc/sdhci-omap.txt
+++ /dev/null
@@ -1,43 +0,0 @@
-* TI OMAP SDHCI Controller
-
-Refer to mmc.txt for standard MMC bindings.
-
-For UHS devices which require tuning, the device tree should have a "cpu_thermal" node which maps to the appropriate thermal zone. This is used to get the temperature of the zone during tuning.
-
-Required properties:
-- compatible: Should be "ti,omap2430-sdhci" for omap2430 controllers
-	      Should be "ti,omap3-sdhci" for omap3 controllers
-	      Should be "ti,omap4-sdhci" for omap4 and ti81 controllers
-	      Should be "ti,omap5-sdhci" for omap5 controllers
-	      Should be "ti,dra7-sdhci" for DRA7 and DRA72 controllers
-	      Should be "ti,k2g-sdhci" for K2G
-	      Should be "ti,am335-sdhci" for am335x controllers
-	      Should be "ti,am437-sdhci" for am437x controllers
-- ti,hwmods: Must be "mmc<n>", <n> is controller instance starting 1
-	     (Not required for K2G).
-- pinctrl-names: Should be subset of "default", "hs", "sdr12", "sdr25", "sdr50",
-		 "ddr50-rev11", "sdr104-rev11", "ddr50", "sdr104",
-		 "ddr_1_8v-rev11", "ddr_1_8v" or "ddr_3_3v", "hs200_1_8v-rev11",
-		 "hs200_1_8v",
-- pinctrl-<n> : Pinctrl states as described in bindings/pinctrl/pinctrl-bindings.txt
-
-Optional properties:
-- dmas:		List of DMA specifiers with the controller specific format as described
-		in the generic DMA client binding. A tx and rx specifier is required.
-- dma-names:	List of DMA request names. These strings correspond 1:1 with the
-		DMA specifiers listed in dmas. The string naming is to be "tx"
-		and "rx" for TX and RX DMA requests, respectively.
-
-Deprecated properties:
-- ti,non-removable: Compatible with the generic non-removable property
-
-Example:
-	mmc1: mmc@4809c000 {
-		compatible = "ti,dra7-sdhci";
-		reg = <0x4809c000 0x400>;
-		ti,hwmods = "mmc1";
-		bus-width = <4>;
-		vmmc-supply = <&vmmc>; /* phandle to regulator node */
-		dmas = <&sdma 61 &sdma 62>;
-		dma-names = "tx", "rx";
-	};
diff --git a/Documentation/devicetree/bindings/mmc/ti,omap2430-sdhci.yaml b/Documentation/devicetree/bindings/mmc/ti,omap2430-sdhci.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..2c8be3b0986755579e0f4d3f36554f378af914d3
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/ti,omap2430-sdhci.yaml
@@ -0,0 +1,152 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mmc/ti,omap2430-sdhci.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI OMAP SDHCI Controller
+
+maintainers:
+  - Kishon Vijay Abraham I <kishon@ti.com>
+
+description:
+  For UHS devices which require tuning, the device tree should have a
+  cpu_thermal node which maps to the appropriate thermal zone. This
+  is used to get the temperature of the zone during tuning.
+
+allOf:
+  - $ref: sdhci-common.yaml#
+
+properties:
+  compatible:
+    enum:
+      - ti,omap2430-sdhci
+      - ti,omap3-sdhci
+      - ti,omap4-sdhci
+      - ti,omap5-sdhci
+      - ti,dra7-sdhci
+      - ti,k2g-sdhci
+      - ti,am335-sdhci
+      - ti,am437-sdhci
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  pinctrl-names:
+    $ref: /schemas/types.yaml#/definitions/string-array
+    minItems: 1
+    maxItems: 19
+    items:
+      enum:
+        - default
+        - default-rev11
+        - hs
+        - sdr12
+        - sdr12-rev11
+        - sdr25
+        - sdr25-rev11
+        - sdr50
+        - ddr50-rev11
+        - sdr104-rev11
+        - ddr50
+        - sdr104
+        - ddr_1_8v-rev11
+        - ddr_1_8v
+        - ddr_3_3v
+        - hs-rev11
+        - hs200_1_8v-rev11
+        - hs200_1_8v
+        - sleep
+
+  pinctrl-0:
+    maxItems: 1
+
+  pinctrl-1:
+    maxItems: 1
+
+  pinctrl-2:
+    maxItems: 1
+
+  pinctrl-3:
+    maxItems: 1
+
+  pinctrl-4:
+    maxItems: 1
+
+  pinctrl-5:
+    maxItems: 1
+
+  pinctrl-6:
+    maxItems: 1
+
+  pinctrl-7:
+    maxItems: 1
+
+  pinctrl-8:
+    maxItems: 1
+
+  dmas:
+    maxItems: 2
+
+  dma-names:
+    items:
+      - const: tx
+      - const: rx
+
+  ti,hwmods:
+    $ref: /schemas/types.yaml#/definitions/string
+    description:
+      This field is used to fetch the information such as
+      address range, irq lines, dma lines, interconnect, PRCM register,
+      clock domain, input clocks associated with MMC.
+    pattern: "^mmc[0-9]+$"
+
+  pbias-supply:
+    description:
+      It is used to specify the voltage regulator that provides the bias
+      voltage for certain analog or I/O pads.
+
+  ti,non-removable:
+    description:
+      It indicates that a component is not meant to be easily removed or
+      replaced by the user, such as an embedded battery or a non-removable
+      storage slot like eMMC.
+    type: boolean
+    deprecated: true
+
+  vmmmc-supply:
+    description:
+      It is used to specify the power supply (regulator) for the MMC/SD card's
+      main operating voltage (VCC/VDD).
+
+  clock-frequency:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      It represents the speed at which a clock signal associated with a device
+      or bus operates, measured in Hertz (Hz). This value is crucial for configuring
+      hardware components that require a specific clock speed.
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    mmc@4809c000 {
+        compatible = "ti,omap2430-sdhci";
+        reg = <0x4809c000 0x400>;
+        interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>;
+        ti,hwmods = "mmc1";
+        bus-width = <4>;
+        vmmc-supply = <&vmmc>; /* phandle to regulator node */
+        dmas = <&sdma 61>, <&sdma 62>;
+        dma-names = "tx", "rx";
+    };
+...

-- 
2.51.0

Re: [PATCH v2 1/2] arm: dts: ti: omap: Drop unnecessary or unused properties

[Andreas Kemnade]

Am Mon, 08 Sep 2025 16:17:12 +0000
schrieb Charan Pedumuru <charan.pedumuru@gmail.com>:

> Remove unnecessary properties like ti,needs-special-reset,
> ti,needs-special-hs-handling and cap-mmc-dual-data-rate from the DTS
> files as there is no user of them.
> 
> Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>

Nack. At least ti,needs-special-reset and ti,needs-special-hs-handling
are used by the drivers/mmc/host/omap_hsmmc.c and you remove it from
nodes using compatibles of that driver. So at least restrict that to
sdhci-omap stuff.

Regards,
Andreas

Re: [PATCH v2 1/2] arm: dts: ti: omap: Drop unnecessary or unused properties

[Krzysztof Kozlowski]

On Mon, Sep 08, 2025 at 04:17:12PM +0000, Charan Pedumuru wrote:
> Remove unnecessary properties like ti,needs-special-reset,
> ti,needs-special-hs-handling and cap-mmc-dual-data-rate from the DTS
> files as there is no user of them.

No user? That's not true:

git grep ti,needs-special-reset

Best regards,
Krzysztof

Re: [PATCH v2 1/2] arm: dts: ti: omap: Drop unnecessary or unused properties

[Charan Pedumuru]

On 09-09-2025 12:50, Krzysztof Kozlowski wrote:
> On Mon, Sep 08, 2025 at 04:17:12PM +0000, Charan Pedumuru wrote:
>> Remove unnecessary properties like ti,needs-special-reset,
>> ti,needs-special-hs-handling and cap-mmc-dual-data-rate from the DTS
>> files as there is no user of them.
> 
> No user? That's not true:
> 
> git grep ti,needs-special-reset

Yes, my bad, I removed them from the whole node. I will revert these changes for the next revision.

> 
> Best regards,
> Krzysztof
> 

-- 
Best Regards,
Charan.

Re: [PATCH v2 1/2] arm: dts: ti: omap: Drop unnecessary or unused properties

[Charan Pedumuru]

On 09-09-2025 12:50, Krzysztof Kozlowski wrote:
> On Mon, Sep 08, 2025 at 04:17:12PM +0000, Charan Pedumuru wrote:
>> Remove unnecessary properties like ti,needs-special-reset,
>> ti,needs-special-hs-handling and cap-mmc-dual-data-rate from the DTS
>> files as there is no user of them.
> 
> No user? That's not true:
> 
> git grep ti,needs-special-reset

Should I remove ti,needs-special-reset property for the compatibles "ti,am335-sdhci" and "ti,am437-sdhci" instead of removing for all mmc nodes? ti,needs-special-hs-handling and cap-mmc-dual-data-rate were defined for board specific, so these two properties should be defined in the YAML file to resolve dtb_check errors or can I remove those properties for those boards too?

> 
> Best regards,
> Krzysztof
> 

-- 
Best Regards,
Charan.

Re: [PATCH v2 1/2] arm: dts: ti: omap: Drop unnecessary or unused properties

[Rob Herring]

On Sun, Sep 14, 2025 at 12:19:15AM +0530, Charan Pedumuru wrote:
> 
> 
> On 09-09-2025 12:50, Krzysztof Kozlowski wrote:
> > On Mon, Sep 08, 2025 at 04:17:12PM +0000, Charan Pedumuru wrote:
> >> Remove unnecessary properties like ti,needs-special-reset,
> >> ti,needs-special-hs-handling and cap-mmc-dual-data-rate from the DTS
> >> files as there is no user of them.
> > 
> > No user? That's not true:
> > 
> > git grep ti,needs-special-reset
> 
> Should I remove ti,needs-special-reset property for the compatibles 
> "ti,am335-sdhci" and "ti,am437-sdhci" instead of removing for all mmc 
> nodes? ti,needs-special-hs-handling and cap-mmc-dual-data-rate were 
> defined for board specific, so these two properties should be defined 
> in the YAML file to resolve dtb_check errors or can I remove those 
> properties for those boards too?

If those 2 compatibles don't use the omap_hsmmc driver then, yes I think 
you can remove the properties from those nodes. Otherwise, shrug. Ask 
the TI folks if you can't figure it out.

Rob

Re: [PATCH v2 1/2] arm: dts: ti: omap: Drop unnecessary or unused properties

[Charan Pedumuru]

On 15-09-2025 03:53, Rob Herring wrote:
> On Sun, Sep 14, 2025 at 12:19:15AM +0530, Charan Pedumuru wrote:
>>
>>
>> On 09-09-2025 12:50, Krzysztof Kozlowski wrote:
>>> On Mon, Sep 08, 2025 at 04:17:12PM +0000, Charan Pedumuru wrote:
>>>> Remove unnecessary properties like ti,needs-special-reset,
>>>> ti,needs-special-hs-handling and cap-mmc-dual-data-rate from the DTS
>>>> files as there is no user of them.
>>>
>>> No user? That's not true:
>>>
>>> git grep ti,needs-special-reset
>>
>> Should I remove ti,needs-special-reset property for the compatibles 
>> "ti,am335-sdhci" and "ti,am437-sdhci" instead of removing for all mmc 
>> nodes? ti,needs-special-hs-handling and cap-mmc-dual-data-rate were 
>> defined for board specific, so these two properties should be defined 
>> in the YAML file to resolve dtb_check errors or can I remove those 
>> properties for those boards too?
> 
> If those 2 compatibles don't use the omap_hsmmc driver then, yes I think 
> you can remove the properties from those nodes. Otherwise, shrug. Ask 
> the TI folks if you can't figure it out.

Those compatibles use sdhci-omap driver not omap_hsmmc driver, then I will remove those properties for the nodes with those compatibles. For the properties which are board specific, I won't remove them.

> 
> Rob

-- 
Best Regards,
Charan.