* + mm-swap-use-a-single-page-for-swap-table-when-the-size-fits.patch added to mm-unstable branch
@ 2025-09-17 1:06 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2025-09-17 1:06 UTC (permalink / raw)
To: mm-commits, ziy, yosryahmed, ying.huang, willy, shikemeng,
oliver.sang, nphamcs, lorenzo.stoakes, hughd, hannes, david,
chrisl, bhe, baolin.wang, baohua, kasong, akpm
The patch titled
Subject: mm, swap: use a single page for swap table when the size fits
has been added to the -mm mm-unstable branch. Its filename is
mm-swap-use-a-single-page-for-swap-table-when-the-size-fits.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-swap-use-a-single-page-for-swap-table-when-the-size-fits.patch
This patch will later appear in the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Kairui Song <kasong@tencent.com>
Subject: mm, swap: use a single page for swap table when the size fits
Date: Wed, 17 Sep 2025 00:01:00 +0800
We have a cluster size of 512 slots. Each slot consumes 8 bytes in swap
table so the swap table size of each cluster is exactly one page (4K).
If that condition is true, allocate one page direct and disable the slab
cache to reduce the memory usage of swap table and avoid fragmentation.
Link: https://lkml.kernel.org/r/20250916160100.31545-16-ryncsn@gmail.com
Co-developed-by: Chris Li <chrisl@kernel.org>
Signed-off-by: Chris Li <chrisl@kernel.org>
Signed-off-by: Kairui Song <kasong@tencent.com>
Acked-by: Chris Li <chrisl@kernel.org>
Suggested-by: Chris Li <chrisl@kernel.org>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Baoquan He <bhe@redhat.com>
Cc: Barry Song <baohua@kernel.org>
Cc: David Hildenbrand <david@redhat.com>
Cc: "Huang, Ying" <ying.huang@linux.alibaba.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: kernel test robot <oliver.sang@intel.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Nhat Pham <nphamcs@gmail.com>
Cc: Yosry Ahmed <yosryahmed@google.com>
Cc: Zi Yan <ziy@nvidia.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/swap_table.h | 2 +
mm/swapfile.c | 51 ++++++++++++++++++++++++++++++++++++----------
2 files changed, 43 insertions(+), 10 deletions(-)
--- a/mm/swapfile.c~mm-swap-use-a-single-page-for-swap-table-when-the-size-fits
+++ a/mm/swapfile.c
@@ -434,6 +434,38 @@ static inline unsigned int cluster_offse
return cluster_index(si, ci) * SWAPFILE_CLUSTER;
}
+static struct swap_table *swap_table_alloc(gfp_t gfp)
+{
+ struct folio *folio;
+
+ if (!SWP_TABLE_USE_PAGE)
+ return kmem_cache_zalloc(swap_table_cachep, gfp);
+
+ folio = folio_alloc(gfp | __GFP_ZERO, 0);
+ if (folio)
+ return folio_address(folio);
+ return NULL;
+}
+
+static void swap_table_free_folio_rcu_cb(struct rcu_head *head)
+{
+ struct folio *folio;
+
+ folio = page_folio(container_of(head, struct page, rcu_head));
+ folio_put(folio);
+}
+
+static void swap_table_free(struct swap_table *table)
+{
+ if (!SWP_TABLE_USE_PAGE) {
+ kmem_cache_free(swap_table_cachep, table);
+ return;
+ }
+
+ call_rcu(&(folio_page(virt_to_folio(table), 0)->rcu_head),
+ swap_table_free_folio_rcu_cb);
+}
+
static void swap_cluster_free_table(struct swap_cluster_info *ci)
{
unsigned int ci_off;
@@ -447,7 +479,7 @@ static void swap_cluster_free_table(stru
table = (void *)rcu_dereference_protected(ci->table, true);
rcu_assign_pointer(ci->table, NULL);
- kmem_cache_free(swap_table_cachep, table);
+ swap_table_free(table);
}
/*
@@ -470,8 +502,7 @@ swap_cluster_alloc_table(struct swap_inf
/* The cluster must be free and was just isolated from the free list. */
VM_WARN_ON_ONCE(ci->flags || !cluster_is_empty(ci));
- table = kmem_cache_zalloc(swap_table_cachep,
- __GFP_HIGH | __GFP_NOMEMALLOC | __GFP_NOWARN);
+ table = swap_table_alloc(__GFP_HIGH | __GFP_NOMEMALLOC | __GFP_NOWARN);
if (table) {
rcu_assign_pointer(ci->table, table);
return ci;
@@ -487,8 +518,7 @@ swap_cluster_alloc_table(struct swap_inf
spin_unlock(&si->global_cluster_lock);
local_unlock(&percpu_swap_cluster.lock);
- table = kmem_cache_zalloc(swap_table_cachep,
- __GFP_HIGH | __GFP_NOMEMALLOC | GFP_KERNEL);
+ table = swap_table_alloc(__GFP_HIGH | __GFP_NOMEMALLOC | GFP_KERNEL);
/*
* Back to atomic context. We might have migrated to a new CPU with a
@@ -506,7 +536,7 @@ swap_cluster_alloc_table(struct swap_inf
/* Nothing except this helper should touch a dangling empty cluster. */
if (WARN_ON_ONCE(cluster_table_is_alloced(ci))) {
if (table)
- kmem_cache_free(swap_table_cachep, table);
+ swap_table_free(table);
return ci;
}
@@ -734,7 +764,7 @@ static int inc_cluster_info_page(struct
ci = cluster_info + idx;
if (!ci->table) {
- table = kmem_cache_zalloc(swap_table_cachep, GFP_KERNEL);
+ table = swap_table_alloc(GFP_KERNEL);
if (!table)
return -ENOMEM;
rcu_assign_pointer(ci->table, table);
@@ -4072,9 +4102,10 @@ static int __init swapfile_init(void)
* only, and all swap cache readers (swap_cache_*) verifies
* the content before use. So it's safe to use RCU slab here.
*/
- swap_table_cachep = kmem_cache_create("swap_table",
- sizeof(struct swap_table),
- 0, SLAB_PANIC | SLAB_TYPESAFE_BY_RCU, NULL);
+ if (!SWP_TABLE_USE_PAGE)
+ swap_table_cachep = kmem_cache_create("swap_table",
+ sizeof(struct swap_table),
+ 0, SLAB_PANIC | SLAB_TYPESAFE_BY_RCU, NULL);
#ifdef CONFIG_MIGRATION
if (swapfile_maximum_size >= (1UL << SWP_MIG_TOTAL_BITS))
--- a/mm/swap_table.h~mm-swap-use-a-single-page-for-swap-table-when-the-size-fits
+++ a/mm/swap_table.h
@@ -11,6 +11,8 @@ struct swap_table {
atomic_long_t entries[SWAPFILE_CLUSTER];
};
+#define SWP_TABLE_USE_PAGE (sizeof(struct swap_table) == PAGE_SIZE)
+
/*
* A swap table entry represents the status of a swap slot on a swap
* (physical or virtual) device. The swap table in each cluster is a
_
Patches currently in -mm which might be from kasong@tencent.com are
mm-swap-use-unified-helper-for-swap-cache-look-up.patch
mm-swap-fix-swap-cache-index-error-when-retrying-reclaim.patch
mm-swap-check-page-poison-flag-after-locking-it.patch
mm-swap-always-lock-and-check-the-swap-cache-folio-before-use.patch
mm-swap-rename-and-move-some-swap-cluster-definition-and-helpers.patch
mm-swap-tidy-up-swap-device-and-cluster-info-helpers.patch
mm-swap-cleanup-swap-cache-api-and-add-kerneldoc.patch
mm-shmem-swap-remove-redundant-error-handling-for-replacing-folio.patch
mm-swap-wrap-swap-cache-replacement-with-a-helper.patch
mm-swap-use-the-swap-table-for-the-swap-cache-and-switch-api.patch
mm-swap-mark-swap-address-space-ro-and-add-context-debug-check.patch
mm-swap-remove-contention-workaround-for-swap-cache.patch
mm-swap-implement-dynamic-allocation-of-swap-table.patch
mm-swap-use-a-single-page-for-swap-table-when-the-size-fits.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-09-17 1:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-17 1:06 + mm-swap-use-a-single-page-for-swap-table-when-the-size-fits.patch added to mm-unstable branch Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.