All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Martin Uecker <uecker@tugraz.at>
Cc: Qing Zhao <qing.zhao@oracle.com>,
	Andrew Pinski <pinskia@gmail.com>,
	Jakub Jelinek <jakub@redhat.com>,
	Richard Biener <rguenther@suse.de>,
	Joseph Myers <josmyers@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Jan Hubicka <hubicka@ucw.cz>,
	Richard Earnshaw <richard.earnshaw@arm.com>,
	Richard Sandiford <richard.sandiford@arm.com>,
	Marcus Shawcroft <marcus.shawcroft@arm.com>,
	Kyrylo Tkachov <kyrylo.tkachov@arm.com>,
	Kito Cheng <kito.cheng@gmail.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Andrew Waterman <andrew@sifive.com>,
	Jim Wilson <jim.wilson.gcc@gmail.com>,
	Dan Li <ashimida.1990@gmail.com>,
	Sami Tolvanen <samitolvanen@google.com>,
	Ramon de C Valle <rcvalle@google.com>,
	Joao Moreira <joao@overdrivepizza.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Bill Wendling <morbo@google.com>,
	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	"linux-hardening@vger.kernel.org"
	<linux-hardening@vger.kernel.org>
Subject: Re: [PATCH v3 1/7] typeinfo: Introduce KCFI typeinfo mangling API
Date: Thu, 18 Sep 2025 11:09:31 -0700	[thread overview]
Message-ID: <202509181009.CBFE970D@keescook> (raw)
In-Reply-To: <8d93c033c8060e79d2f0374a97827172f79ebdf8.camel@tugraz.at>

On Thu, Sep 18, 2025 at 09:20:52AM +0200, Martin Uecker wrote:
> Am Mittwoch, dem 17.09.2025 um 17:56 +0000 schrieb Qing Zhao:
> > Hi, 
> > 
> > > On Sep 13, 2025, at 19:23, Kees Cook <kees@kernel.org> wrote:
> > > 
> > > To support the KCFI typeid and future type-based allocators,
> 
> What I find problematic though is that this is not based on GNU / ISO C
> rules but on stricter Linux kernel rules.   I think such builtin should
> have two versions.  
> 
> So maybe
> 
> __builtin_typeinfo_hash_strict // strict
> __builtin_typeinfo_hash_canonical // standard
> 
> or similar, or maybe instead have a flag argument so that we can
> other options which may turn out to be important in the future
> (such as ignoring  qualifiers or supporting newer languag features).

Can you send me a patch to gcc/testsuite/gcc.dg/builtin-typeinfo.c
that shows what differences you mean? Because AFAICT, this C version
matches the C++ typeinfo implementation. There isn't a need for these
hashes to be comparable in a way that they could be used to, for
example, reimplement __builtin_types_compatible_p. It's called
"typeinfo" and that has a specific meaning currently...

Given:

    typedef int arr10[10];
    typedef int arr_unknown[];
    typedef int *arr;
    typedef struct named { int a; int b; } named_t;
    typedef struct { int a; int b; } nameless_t;
    typedef void (*func_arr10)(int[10]);
    typedef void (*func_arr_unknown)(int[]);
    typedef void (*func_ptr)(int*);
    typedef void (*func_named(named_t*);
    typedef void (*func_nameless(nameless_t*);

C++ typeinfo(...).name() shows:

  int[10]:		A10_i
  int[]:		A_i
  int *:		Pi
  named_t:		5named
  nameless_t:		10nameless_t
  void(*)(int[10]):	PFvPiE
  void(*)(int[]):	PFvPiE
  void(*)(int*):	PFvPiE
  void(*)(named_t*):	PFvP5namedE
  void(*)(nameless_t*):	PFvP10nameless_tE

This __builtin_typeinfo_name(...) shows:

  int[10]:		A10_i
  int[]:		A_i
  int *:		Pi
  __builtin_compatible_types_p(int[10], int[]): true
  __builtin_compatible_types_p(int[], int*):	false
  named_t:		5named
  nameless_t:		10nameless_t
  void(*)(int[10]):	PFvPiE
  void(*)(int[]):	PFvPiE
  void(*)(int*):	PFvPiE
  void(*)(named_t*):	PFvP5namedE
  void(*)(nameless_t*):	PFvP10nameless_tE

What would you want the "Strict ISO C" builtin to do instead?

-Kees

-- 
Kees Cook

  reply	other threads:[~2025-09-18 18:09 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-13 23:23 [PATCH v3 0/7] Introduce Kernel Control Flow Integrity ABI [PR107048] Kees Cook
2025-09-13 23:23 ` [PATCH v3 1/7] typeinfo: Introduce KCFI typeinfo mangling API Kees Cook
2025-09-17 17:56   ` Qing Zhao
2025-09-17 21:20     ` Kees Cook
2025-09-18  7:20     ` Martin Uecker
2025-09-18 18:09       ` Kees Cook [this message]
2025-09-18 18:40         ` Martin Uecker
2025-09-13 23:23 ` [PATCH v3 2/7] kcfi: Add core Kernel Control Flow Integrity infrastructure Kees Cook
2025-09-17 13:42   ` Qing Zhao
2025-09-17 21:09     ` Kees Cook
2025-09-18 16:59       ` Qing Zhao
2025-09-18 18:20         ` Kees Cook
2025-09-18 18:48           ` Qing Zhao
2025-09-18 19:20             ` Kees Cook
2025-09-18 19:39       ` Kees Cook
2025-09-18 20:14         ` Qing Zhao
2025-09-13 23:23 ` [PATCH v3 3/7] x86: Add x86_64 Kernel Control Flow Integrity implementation Kees Cook
2025-09-13 23:24 ` [PATCH v3 4/7] aarch64: Add AArch64 " Kees Cook
2025-09-13 23:43   ` Andrew Pinski
2025-09-14 19:45     ` Kees Cook
2025-09-14 19:52       ` Andrew Pinski
2025-09-17 20:01     ` Kees Cook
2025-09-13 23:24 ` [PATCH v3 5/7] arm: Add ARM 32-bit " Kees Cook
2025-09-13 23:24 ` [PATCH v3 6/7] riscv: Add RISC-V " Kees Cook
2025-09-13 23:24 ` [PATCH v3 7/7] kcfi: Add regression test suite Kees Cook
2025-09-13 23:51   ` Andrew Pinski
2025-09-17 19:51     ` Kees Cook
2025-09-13 23:58   ` Andrew Pinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202509181009.CBFE970D@keescook \
    --to=kees@kernel.org \
    --cc=andrew@sifive.com \
    --cc=ashimida.1990@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    --cc=jakub@redhat.com \
    --cc=jim.wilson.gcc@gmail.com \
    --cc=joao@overdrivepizza.com \
    --cc=josmyers@redhat.com \
    --cc=kito.cheng@gmail.com \
    --cc=kyrylo.tkachov@arm.com \
    --cc=linux-hardening@vger.kernel.org \
    --cc=marcus.shawcroft@arm.com \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=peterz@infradead.org \
    --cc=pinskia@gmail.com \
    --cc=qing.zhao@oracle.com \
    --cc=rcvalle@google.com \
    --cc=rguenther@suse.de \
    --cc=richard.earnshaw@arm.com \
    --cc=richard.sandiford@arm.com \
    --cc=samitolvanen@google.com \
    --cc=uecker@tugraz.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.