* [PATCH net-next] wan: framer: pef2256: use %pe in print format
@ 2025-09-18 13:46 Jakub Kicinski
2025-09-18 14:08 ` Herve Codina
2025-09-19 15:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jakub Kicinski @ 2025-09-18 13:46 UTC (permalink / raw)
To: davem
Cc: netdev, edumazet, pabeni, andrew+netdev, horms, Jakub Kicinski,
herve.codina
New cocci check complains:
drivers/net/wan/framer/pef2256/pef2256.c:733:3-10: WARNING: Consider using %pe to print PTR_ERR()
Link: https://lore.kernel.org/1758192227-701925-1-git-send-email-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: herve.codina@bootlin.com
---
drivers/net/wan/framer/pef2256/pef2256.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wan/framer/pef2256/pef2256.c b/drivers/net/wan/framer/pef2256/pef2256.c
index 1e4c8e85d598..2a25cbd3f13b 100644
--- a/drivers/net/wan/framer/pef2256/pef2256.c
+++ b/drivers/net/wan/framer/pef2256/pef2256.c
@@ -719,8 +719,8 @@ static int pef2256_probe(struct platform_device *pdev)
pef2256->regmap = devm_regmap_init_mmio(&pdev->dev, iomem,
&pef2256_regmap_config);
if (IS_ERR(pef2256->regmap)) {
- dev_err(&pdev->dev, "Failed to initialise Regmap (%ld)\n",
- PTR_ERR(pef2256->regmap));
+ dev_err(&pdev->dev, "Failed to initialise Regmap (%pe)\n",
+ pef2256->regmap);
return PTR_ERR(pef2256->regmap);
}
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] wan: framer: pef2256: use %pe in print format
2025-09-18 13:46 [PATCH net-next] wan: framer: pef2256: use %pe in print format Jakub Kicinski
@ 2025-09-18 14:08 ` Herve Codina
2025-09-19 15:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Herve Codina @ 2025-09-18 14:08 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, edumazet, pabeni, andrew+netdev, horms
Hi Jakub,
On Thu, 18 Sep 2025 06:46:37 -0700
Jakub Kicinski <kuba@kernel.org> wrote:
> New cocci check complains:
>
> drivers/net/wan/framer/pef2256/pef2256.c:733:3-10: WARNING: Consider using %pe to print PTR_ERR()
>
> Link: https://lore.kernel.org/1758192227-701925-1-git-send-email-tariqt@nvidia.com
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: herve.codina@bootlin.com
> ---
> drivers/net/wan/framer/pef2256/pef2256.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wan/framer/pef2256/pef2256.c b/drivers/net/wan/framer/pef2256/pef2256.c
> index 1e4c8e85d598..2a25cbd3f13b 100644
> --- a/drivers/net/wan/framer/pef2256/pef2256.c
> +++ b/drivers/net/wan/framer/pef2256/pef2256.c
> @@ -719,8 +719,8 @@ static int pef2256_probe(struct platform_device *pdev)
> pef2256->regmap = devm_regmap_init_mmio(&pdev->dev, iomem,
> &pef2256_regmap_config);
> if (IS_ERR(pef2256->regmap)) {
> - dev_err(&pdev->dev, "Failed to initialise Regmap (%ld)\n",
> - PTR_ERR(pef2256->regmap));
> + dev_err(&pdev->dev, "Failed to initialise Regmap (%pe)\n",
> + pef2256->regmap);
> return PTR_ERR(pef2256->regmap);
> }
>
Acked-by: Herve Codina <herve.codina@bootlin.com>
Best regards,
Hervé
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] wan: framer: pef2256: use %pe in print format
2025-09-18 13:46 [PATCH net-next] wan: framer: pef2256: use %pe in print format Jakub Kicinski
2025-09-18 14:08 ` Herve Codina
@ 2025-09-19 15:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-09-19 15:10 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, andrew+netdev, horms,
herve.codina
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 18 Sep 2025 06:46:37 -0700 you wrote:
> New cocci check complains:
>
> drivers/net/wan/framer/pef2256/pef2256.c:733:3-10: WARNING: Consider using %pe to print PTR_ERR()
>
> Link: https://lore.kernel.org/1758192227-701925-1-git-send-email-tariqt@nvidia.com
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> [...]
Here is the summary with links:
- [net-next] wan: framer: pef2256: use %pe in print format
https://git.kernel.org/netdev/net-next/c/3fb4f35a75e8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-19 15:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-18 13:46 [PATCH net-next] wan: framer: pef2256: use %pe in print format Jakub Kicinski
2025-09-18 14:08 ` Herve Codina
2025-09-19 15:10 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.