All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jones <ajones@ventanamicro.com>
To: iommu@lists.linux.dev, kvm-riscv@lists.infradead.org,
	kvm@vger.kernel.org, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: jgg@nvidia.com, zong.li@sifive.com, tjeznach@rivosinc.com,
	joro@8bytes.org, will@kernel.org, robin.murphy@arm.com,
	anup@brainfault.org, atish.patra@linux.dev, tglx@linutronix.de,
	alex.williamson@redhat.com, paul.walmsley@sifive.com,
	palmer@dabbelt.com, alex@ghiti.fr
Subject: [RFC PATCH v2 18/18] DO NOT UPSTREAM: RISC-V: KVM: Workaround kvm_riscv_gstage_ioremap() bug
Date: Sat, 20 Sep 2025 15:39:08 -0500	[thread overview]
Message-ID: <20250920203851.2205115-38-ajones@ventanamicro.com> (raw)
In-Reply-To: <20250920203851.2205115-20-ajones@ventanamicro.com>

Workaround a bug that breaks guest booting with device assignment that
was introduced with commit 9bca8be646e0 ("RISC-V: KVM: Fix pte settings
within kvm_riscv_gstage_ioremap()")
---
 arch/riscv/kvm/mmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/kvm/mmu.c b/arch/riscv/kvm/mmu.c
index 525fb5a330c0..994f18b92143 100644
--- a/arch/riscv/kvm/mmu.c
+++ b/arch/riscv/kvm/mmu.c
@@ -56,7 +56,7 @@ int kvm_riscv_mmu_ioremap(struct kvm *kvm, gpa_t gpa, phys_addr_t hpa,
 
 	end = (gpa + size + PAGE_SIZE - 1) & PAGE_MASK;
 	pfn = __phys_to_pfn(hpa);
-	prot = pgprot_noncached(PAGE_WRITE);
+	prot = pgprot_noncached(__pgprot(_PAGE_PRESENT | _PAGE_ACCESSED | _PAGE_READ | _PAGE_WRITE));
 
 	for (addr = gpa; addr < end; addr += PAGE_SIZE) {
 		map.addr = addr;
-- 
2.49.0


-- 
kvm-riscv mailing list
kvm-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kvm-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jones <ajones@ventanamicro.com>
To: iommu@lists.linux.dev, kvm-riscv@lists.infradead.org,
	kvm@vger.kernel.org, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: jgg@nvidia.com, zong.li@sifive.com, tjeznach@rivosinc.com,
	joro@8bytes.org, will@kernel.org, robin.murphy@arm.com,
	anup@brainfault.org, atish.patra@linux.dev, tglx@linutronix.de,
	alex.williamson@redhat.com, paul.walmsley@sifive.com,
	palmer@dabbelt.com, alex@ghiti.fr
Subject: [RFC PATCH v2 18/18] DO NOT UPSTREAM: RISC-V: KVM: Workaround kvm_riscv_gstage_ioremap() bug
Date: Sat, 20 Sep 2025 15:39:08 -0500	[thread overview]
Message-ID: <20250920203851.2205115-38-ajones@ventanamicro.com> (raw)
In-Reply-To: <20250920203851.2205115-20-ajones@ventanamicro.com>

Workaround a bug that breaks guest booting with device assignment that
was introduced with commit 9bca8be646e0 ("RISC-V: KVM: Fix pte settings
within kvm_riscv_gstage_ioremap()")
---
 arch/riscv/kvm/mmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/kvm/mmu.c b/arch/riscv/kvm/mmu.c
index 525fb5a330c0..994f18b92143 100644
--- a/arch/riscv/kvm/mmu.c
+++ b/arch/riscv/kvm/mmu.c
@@ -56,7 +56,7 @@ int kvm_riscv_mmu_ioremap(struct kvm *kvm, gpa_t gpa, phys_addr_t hpa,
 
 	end = (gpa + size + PAGE_SIZE - 1) & PAGE_MASK;
 	pfn = __phys_to_pfn(hpa);
-	prot = pgprot_noncached(PAGE_WRITE);
+	prot = pgprot_noncached(__pgprot(_PAGE_PRESENT | _PAGE_ACCESSED | _PAGE_READ | _PAGE_WRITE));
 
 	for (addr = gpa; addr < end; addr += PAGE_SIZE) {
 		map.addr = addr;
-- 
2.49.0


WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jones <ajones@ventanamicro.com>
To: iommu@lists.linux.dev, kvm-riscv@lists.infradead.org,
	kvm@vger.kernel.org, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: jgg@nvidia.com, zong.li@sifive.com, tjeznach@rivosinc.com,
	joro@8bytes.org, will@kernel.org, robin.murphy@arm.com,
	anup@brainfault.org, atish.patra@linux.dev, tglx@linutronix.de,
	alex.williamson@redhat.com, paul.walmsley@sifive.com,
	palmer@dabbelt.com, alex@ghiti.fr
Subject: [RFC PATCH v2 18/18] DO NOT UPSTREAM: RISC-V: KVM: Workaround kvm_riscv_gstage_ioremap() bug
Date: Sat, 20 Sep 2025 15:39:08 -0500	[thread overview]
Message-ID: <20250920203851.2205115-38-ajones@ventanamicro.com> (raw)
In-Reply-To: <20250920203851.2205115-20-ajones@ventanamicro.com>

Workaround a bug that breaks guest booting with device assignment that
was introduced with commit 9bca8be646e0 ("RISC-V: KVM: Fix pte settings
within kvm_riscv_gstage_ioremap()")
---
 arch/riscv/kvm/mmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/kvm/mmu.c b/arch/riscv/kvm/mmu.c
index 525fb5a330c0..994f18b92143 100644
--- a/arch/riscv/kvm/mmu.c
+++ b/arch/riscv/kvm/mmu.c
@@ -56,7 +56,7 @@ int kvm_riscv_mmu_ioremap(struct kvm *kvm, gpa_t gpa, phys_addr_t hpa,
 
 	end = (gpa + size + PAGE_SIZE - 1) & PAGE_MASK;
 	pfn = __phys_to_pfn(hpa);
-	prot = pgprot_noncached(PAGE_WRITE);
+	prot = pgprot_noncached(__pgprot(_PAGE_PRESENT | _PAGE_ACCESSED | _PAGE_READ | _PAGE_WRITE));
 
 	for (addr = gpa; addr < end; addr += PAGE_SIZE) {
 		map.addr = addr;
-- 
2.49.0


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2025-09-20 20:39 UTC|newest]

Thread overview: 159+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-20 20:38 [RFC PATCH v2 00/18] iommu/riscv: Add irqbypass support Andrew Jones
2025-09-20 20:38 ` Andrew Jones
2025-09-20 20:38 ` Andrew Jones
2025-09-20 20:38 ` [RFC PATCH v2 01/18] genirq/msi: Provide DOMAIN_BUS_MSI_REMAP Andrew Jones
2025-09-20 20:38   ` Andrew Jones
2025-09-20 20:38   ` Andrew Jones
2025-09-30  8:25   ` Nutty.Liu
2025-09-30  8:25     ` Nutty.Liu
2025-09-30  8:25     ` Nutty.Liu
2025-09-20 20:38 ` [RFC PATCH v2 02/18] iommu/riscv: Move struct riscv_iommu_domain and info to iommu.h Andrew Jones
2025-09-20 20:38   ` Andrew Jones
2025-09-20 20:38   ` Andrew Jones
2025-09-30  8:26   ` Nutty.Liu
2025-09-30  8:26     ` Nutty.Liu
2025-09-30  8:26     ` Nutty.Liu
2025-09-20 20:38 ` [RFC PATCH v2 03/18] iommu/riscv: Use data structure instead of individual values Andrew Jones
2025-09-20 20:38   ` Andrew Jones
2025-09-20 20:38   ` Andrew Jones
2025-09-24  3:25   ` Nutty.Liu
2025-09-24  3:25     ` Nutty.Liu
2025-09-24  3:25     ` Nutty.Liu
2025-09-24 13:31     ` Andrew Jones
2025-09-24 13:31       ` Andrew Jones
2025-09-24 13:31       ` Andrew Jones
2025-09-20 20:38 ` [RFC PATCH v2 04/18] iommu/riscv: Add IRQ domain for interrupt remapping Andrew Jones
2025-09-20 20:38   ` Andrew Jones
2025-09-20 20:38   ` Andrew Jones
2025-09-28  9:30   ` Nutty.Liu
2025-09-28  9:30     ` Nutty.Liu
2025-09-28  9:30     ` Nutty.Liu
2025-09-29 15:50     ` Andrew Jones
2025-09-29 15:50       ` Andrew Jones
2025-09-29 15:50       ` Andrew Jones
2025-09-20 20:38 ` [RFC PATCH v2 05/18] iommu/riscv: Prepare to use MSI table Andrew Jones
2025-09-20 20:38   ` Andrew Jones
2025-09-20 20:38   ` Andrew Jones
2025-10-05  8:30   ` Nutty.Liu
2025-10-05  8:30     ` Nutty.Liu
2025-10-05  8:30     ` Nutty.Liu
2025-09-20 20:38 ` [RFC PATCH v2 06/18] iommu/riscv: Implement MSI table management functions Andrew Jones
2025-09-20 20:38   ` Andrew Jones
2025-09-20 20:38   ` Andrew Jones
2025-10-05  8:28   ` Nutty.Liu
2025-10-05  8:28     ` Nutty.Liu
2025-10-05  8:28     ` Nutty.Liu
2025-09-20 20:38 ` [RFC PATCH v2 07/18] iommu/riscv: Export phys_to_ppn and ppn_to_phys Andrew Jones
2025-09-20 20:38   ` Andrew Jones
2025-09-20 20:38   ` Andrew Jones
2025-10-05  8:39   ` Nutty.Liu
2025-10-05  8:39     ` Nutty.Liu
2025-10-05  8:39     ` Nutty.Liu
2025-09-20 20:38 ` [RFC PATCH v2 08/18] iommu/riscv: Use MSI table to enable IMSIC access Andrew Jones
2025-09-20 20:38   ` Andrew Jones
2025-09-20 20:38   ` Andrew Jones
2025-09-22 18:43   ` Jason Gunthorpe
2025-09-22 18:43     ` Jason Gunthorpe
2025-09-22 18:43     ` Jason Gunthorpe
2025-09-22 21:20     ` Andrew Jones
2025-09-22 21:20       ` Andrew Jones
2025-09-22 21:20       ` Andrew Jones
2025-09-22 23:56       ` Jason Gunthorpe
2025-09-22 23:56         ` Jason Gunthorpe
2025-09-22 23:56         ` Jason Gunthorpe
2025-09-23 10:12         ` Thomas Gleixner
2025-09-23 10:12           ` Thomas Gleixner
2025-09-23 10:12           ` Thomas Gleixner
2025-09-23 14:06           ` Jason Gunthorpe
2025-09-23 14:06             ` Jason Gunthorpe
2025-09-23 14:06             ` Jason Gunthorpe
2025-09-23 15:12             ` Andrew Jones
2025-09-23 15:12               ` Andrew Jones
2025-09-23 15:12               ` Andrew Jones
2025-09-23 15:27               ` Jason Gunthorpe
2025-09-23 15:27                 ` Jason Gunthorpe
2025-09-23 15:27                 ` Jason Gunthorpe
2025-09-23 15:50                 ` Andrew Jones
2025-09-23 15:50                   ` Andrew Jones
2025-09-23 15:50                   ` Andrew Jones
2025-09-23 16:23                   ` Jason Gunthorpe
2025-09-23 16:23                     ` Jason Gunthorpe
2025-09-23 16:23                     ` Jason Gunthorpe
2025-09-23 16:33                     ` Andrew Jones
2025-09-23 16:33                       ` Andrew Jones
2025-09-23 16:33                       ` Andrew Jones
2026-03-24  9:12                       ` Vincent Chen
2026-03-24  9:12                         ` Vincent Chen
2026-03-24  9:12                         ` Vincent Chen
2026-03-26 17:31                         ` Andrew Jones
2026-03-26 17:31                           ` Andrew Jones
2026-03-26 17:31                           ` Andrew Jones
2025-09-23 14:37           ` Andrew Jones
2025-09-23 14:37             ` Andrew Jones
2025-09-23 14:37             ` Andrew Jones
2025-09-23 14:52             ` Jason Gunthorpe
2025-09-23 14:52               ` Jason Gunthorpe
2025-09-23 14:52               ` Jason Gunthorpe
2025-09-23 15:37               ` Andrew Jones
2025-09-23 15:37                 ` Andrew Jones
2025-09-23 15:37                 ` Andrew Jones
2025-10-23 13:47         ` Jinvas
2025-10-23 13:47           ` Jinvas
2025-10-23 13:47           ` Jinvas
2025-09-20 20:38 ` [RFC PATCH v2 09/18] iommu/dma: enable IOMMU_DMA for RISC-V Andrew Jones
2025-09-20 20:38   ` Andrew Jones
2025-09-20 20:38   ` Andrew Jones
2025-10-05  8:40   ` Nutty.Liu
2025-10-05  8:40     ` Nutty.Liu
2025-10-05  8:40     ` Nutty.Liu
2025-09-20 20:39 ` [RFC PATCH v2 10/18] RISC-V: Define irqbypass vcpu_info Andrew Jones
2025-09-20 20:39   ` Andrew Jones
2025-09-20 20:39   ` Andrew Jones
2025-10-05  8:41   ` Nutty.Liu
2025-10-05  8:41     ` Nutty.Liu
2025-10-05  8:41     ` Nutty.Liu
2025-09-20 20:39 ` [RFC PATCH v2 11/18] iommu/riscv: Maintain each irq msitbl index with chip data Andrew Jones
2025-09-20 20:39   ` Andrew Jones
2025-09-20 20:39   ` Andrew Jones
2025-09-20 20:39 ` [RFC PATCH v2 12/18] iommu/riscv: Add guest file irqbypass support Andrew Jones
2025-09-20 20:39   ` Andrew Jones
2025-09-20 20:39   ` Andrew Jones
2025-09-20 20:39 ` [RFC PATCH v2 13/18] iommu/riscv: report iommu capabilities Andrew Jones
2025-09-20 20:39   ` Andrew Jones
2025-09-20 20:39   ` Andrew Jones
2025-10-05  8:43   ` Nutty.Liu
2025-10-05  8:43     ` Nutty.Liu
2025-10-05  8:43     ` Nutty.Liu
2025-09-20 20:39 ` [RFC PATCH v2 14/18] RISC-V: KVM: Enable KVM_VFIO interfaces on RISC-V arch Andrew Jones
2025-09-20 20:39   ` Andrew Jones
2025-09-20 20:39   ` Andrew Jones
2025-10-05  8:44   ` Nutty.Liu
2025-10-05  8:44     ` Nutty.Liu
2025-10-05  8:44     ` Nutty.Liu
2025-09-20 20:39 ` [RFC PATCH v2 15/18] RISC-V: KVM: Add guest file irqbypass support Andrew Jones
2025-09-20 20:39   ` Andrew Jones
2025-09-20 20:39   ` Andrew Jones
2025-09-20 20:39 ` [RFC PATCH v2 16/18] vfio: enable IOMMU_TYPE1 for RISC-V Andrew Jones
2025-09-20 20:39   ` Andrew Jones
2025-09-20 20:39   ` Andrew Jones
2025-10-05  8:44   ` Nutty.Liu
2025-10-05  8:44     ` Nutty.Liu
2025-10-05  8:44     ` Nutty.Liu
2025-09-20 20:39 ` [RFC PATCH v2 17/18] RISC-V: defconfig: Add VFIO modules Andrew Jones
2025-09-20 20:39   ` Andrew Jones
2025-09-20 20:39   ` Andrew Jones
2025-10-05  8:47   ` Nutty.Liu
2025-10-05  8:47     ` Nutty.Liu
2025-10-05  8:47     ` Nutty.Liu
2025-09-20 20:39 ` Andrew Jones [this message]
2025-09-20 20:39   ` [RFC PATCH v2 18/18] DO NOT UPSTREAM: RISC-V: KVM: Workaround kvm_riscv_gstage_ioremap() bug Andrew Jones
2025-09-20 20:39   ` Andrew Jones
2025-10-20 13:12   ` fangyu.yu
2025-10-20 13:12     ` fangyu.yu
2025-10-20 13:12     ` fangyu.yu
2025-10-20 19:47     ` Daniel Henrique Barboza
2025-10-20 19:47       ` Daniel Henrique Barboza
2025-10-20 19:47       ` Daniel Henrique Barboza
2025-10-21  1:10   ` fangyu.yu
2025-10-21  1:10     ` fangyu.yu
2025-10-21  1:10     ` fangyu.yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250920203851.2205115-38-ajones@ventanamicro.com \
    --to=ajones@ventanamicro.com \
    --cc=alex.williamson@redhat.com \
    --cc=alex@ghiti.fr \
    --cc=anup@brainfault.org \
    --cc=atish.patra@linux.dev \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=kvm-riscv@lists.infradead.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robin.murphy@arm.com \
    --cc=tglx@linutronix.de \
    --cc=tjeznach@rivosinc.com \
    --cc=will@kernel.org \
    --cc=zong.li@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.