From: Jakub Kicinski <kuba@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Daniel Golle <daniel@makrotopia.org>,
netdev@vger.kernel.org, Hauke Mehrtens <hauke@hauke-m.de>,
Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net 0/2] lantiq_gswip fixes
Date: Mon, 22 Sep 2025 11:34:52 -0700 [thread overview]
Message-ID: <20250922113452.07844cd2@kernel.org> (raw)
In-Reply-To: <20250922110717.7n743dmxrcrokf4k@skbuf>
On Mon, 22 Sep 2025 14:07:17 +0300 Vladimir Oltean wrote:
> - I don't think your local_termination.sh exercises the bug fixed by
> patch "[1/2] net: dsa: lantiq_gswip: move gswip_add_single_port_br()
> call to port_setup()". The port has to be initially down before
> joining a bridge, and be brought up afterwards. This can be tested
> manually. In local_termination.sh, although bridge_create() runs
> "ip link set $h2 up" after "ip link set $h2 master br0", $h2 was
> already up due to "simple_if_init $h2".
Waiting for more testing..
> - If the vast majority of users make use of this driver through OpenWrt,
> and if backporting to the required trees is done by OpenWrt and the
> fixes' presence in linux-stable is not useful, I can offer to resend
> this set plus the remaining patches all together through the net-next
> tree, and avoid complications such as merge conflicts.
FWIW I don't even see a real conflict when merging this. git seems to
be figuring things out on its own.
next prev parent reply other threads:[~2025-09-22 18:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 7:21 [PATCH net 0/2] lantiq_gswip fixes Vladimir Oltean
2025-09-18 7:21 ` [PATCH net 1/2] net: dsa: lantiq_gswip: move gswip_add_single_port_br() call to port_setup() Vladimir Oltean
2025-09-18 7:21 ` [PATCH net 2/2] net: dsa: lantiq_gswip: suppress -EINVAL errors for bridge FDB entries added to the CPU port Vladimir Oltean
2025-09-19 23:50 ` [PATCH net 0/2] lantiq_gswip fixes Jakub Kicinski
2025-09-20 1:07 ` Daniel Golle
2025-09-22 11:07 ` Vladimir Oltean
2025-09-22 18:34 ` Jakub Kicinski [this message]
2025-09-24 4:18 ` Daniel Golle
2025-09-25 7:35 ` Paolo Abeni
2025-09-25 8:14 ` Vladimir Oltean
2025-09-25 8:27 ` Paolo Abeni
2025-09-25 8:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922113452.07844cd2@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hauke@hauke-m.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.