Re: [PATCH 1/5] dt-bindings: ufs: amd-versal2: Add support for AMD Versal Gen 2 UFS Host Controller

[Rob Herring <robh@kernel.org>]

On Fri, Sep 19, 2025 at 06:08:31PM +0530, Ajay Neeli wrote:
> From: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
> 
> Add devicetree document for AMD Versal Gen 2 UFS Host Controller.
> This includes clocks and clock-names as mandated by UFS common bindings.
> 
> Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
> Co-developed-by: Ajay Neeli <ajay.neeli@amd.com>
> Signed-off-by: Ajay Neeli <ajay.neeli@amd.com>
> ---
>  .../devicetree/bindings/ufs/amd,versal2-ufs.yaml   | 61 ++++++++++++++++++++++
>  1 file changed, 61 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/ufs/amd,versal2-ufs.yaml
> 
> diff --git a/Documentation/devicetree/bindings/ufs/amd,versal2-ufs.yaml b/Documentation/devicetree/bindings/ufs/amd,versal2-ufs.yaml
> new file mode 100644
> index 0000000..9f55949
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ufs/amd,versal2-ufs.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ufs/amd,versal2-ufs.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AMD Versal Gen 2 UFS Host Controller
> +
> +maintainers:
> +  - Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
> +
> +allOf:
> +  - $ref: ufs-common.yaml
> +
> +properties:
> +  compatible:
> +    const: amd,versal2-ufs

2 is versal2 or gen 2? I read it as the former, but everything else in 
this patchset says the latter. compatibles should be based on SoC names, 
not versions. Or does "gen 2" mean Gen 2 UFS specification (if there is 
such a thing)?

> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    items:
> +      - const: core
> +
> +  power-domains:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 2
> +
> +  reset-names:
> +    items:
> +      - const: ufshc
> +      - const: ufsphy

"ufs" part is redundant. Drop.

> +
> +required:
> +  - reg
> +  - clocks
> +  - clock-names
> +  - resets
> +  - reset-names
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    ufs@f10b0000 {
> +        compatible = "amd,versal2-ufs";
> +        reg = <0xf10b0000 0x1000>;
> +        clocks = <&ufs_core_clk>;
> +        clock-names = "core";
> +        resets = <&scmi_reset 4>, <&scmi_reset 35>;
> +        reset-names = "ufshc", "ufsphy";
> +        interrupts = <GIC_SPI 234 IRQ_TYPE_LEVEL_HIGH>;
> +        freq-table-hz = <0 0>;
> +    };
> -- 
> 1.8.3.1
>