All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Ajay Neeli <ajay.neeli@amd.com>,
	martin.petersen@oracle.com,
	James.Bottomley@HansenPartnership.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	pedrom.sousa@synopsys.com
Cc: alim.akhtar@samsung.com, avri.altman@wdc.com,
	linux-scsi@vger.kernel.org, devicetree@vger.kernel.org,
	git@amd.com, michal.simek@amd.com, srinivas.goud@amd.com,
	radhey.shyam.pandey@amd.com,
	Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
Subject: Re: [PATCH 5/5] ufs: amd-versal2: Add AMD Versal Gen 2 UFS support
Date: Fri, 19 Sep 2025 10:44:44 -0700	[thread overview]
Message-ID: <911ac2e9-2f3d-41d2-8a2f-74d2aebef21d@acm.org> (raw)
In-Reply-To: <20250919123835.17899-6-ajay.neeli@amd.com>

On 9/19/25 5:38 AM, Ajay Neeli wrote:
> +#include "ufshcd-dwc.h"
> +#include "ufshcd-pltfrm.h"
> +#include "ufshci-dwc.h"

The *-dwc.h header files are for Synopsys Designware UFS host
controllers only and hence should not be included in the implementation
of the AMD Versal UFS host controller.

> diff --git a/drivers/ufs/host/ufshcd-dwc.h b/drivers/ufs/host/ufshcd-dwc.h
> index ad91ea5..379f3cf 100644
> --- a/drivers/ufs/host/ufshcd-dwc.h
> +++ b/drivers/ufs/host/ufshcd-dwc.h
> @@ -12,6 +12,55 @@
>   
>   #include <ufs/ufshcd.h>
>   
> +/* PHY modes */
> +#define UFSHCD_DWC_PHY_MODE_ROM         0

Please do not modify header files from other controller vendors.

Thanks,

Bart.

  reply	other threads:[~2025-09-19 17:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-19 12:38 [PATCH 0/5] ufs: Add support for AMD Versal Gen2 UFS Ajay Neeli
2025-09-19 12:38 ` [PATCH 1/5] dt-bindings: ufs: amd-versal2: Add support for AMD Versal Gen 2 UFS Host Controller Ajay Neeli
2025-09-22 19:46   ` Rob Herring
2025-10-06 12:30     ` Neeli, Ajay
2025-09-19 12:38 ` [PATCH 2/5] firmware: xilinx: Add support for secure read/write ioctl interface Ajay Neeli
2025-09-19 12:38 ` [PATCH 3/5] firmware: xilinx: Add APIs for UFS PHY initialization Ajay Neeli
2025-09-19 12:38 ` [PATCH 4/5] ufs: core: Add vendor specific ops to handle interrupts Ajay Neeli
2025-09-19 17:34   ` Bart Van Assche
2025-10-06 12:30     ` Neeli, Ajay
2025-09-19 12:38 ` [PATCH 5/5] ufs: amd-versal2: Add AMD Versal Gen 2 UFS support Ajay Neeli
2025-09-19 17:44   ` Bart Van Assche [this message]
2025-10-06 12:45     ` Neeli, Ajay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=911ac2e9-2f3d-41d2-8a2f-74d2aebef21d@acm.org \
    --to=bvanassche@acm.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=ajay.neeli@amd.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=git@amd.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=michal.simek@amd.com \
    --cc=pedrom.sousa@synopsys.com \
    --cc=radhey.shyam.pandey@amd.com \
    --cc=robh@kernel.org \
    --cc=sai.krishna.potthuri@amd.com \
    --cc=srinivas.goud@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.