* [PATCH 0/2] ARM: dts: aspeed: ASRock Rack X470D4U BMC support @ 2025-09-19 18:56 Tan Siewert 2025-09-19 18:56 ` [PATCH 1/2] dt-bindings: arm: aspeed: add ASRock X470D4U BMC Tan Siewert 2025-09-19 18:56 ` [PATCH 2/2] ARM: dts: aspeed: add asrock x470d4u bmc Tan Siewert 0 siblings, 2 replies; 8+ messages in thread From: Tan Siewert @ 2025-09-19 18:56 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery Cc: Tan Siewert, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel Hi, This series adds support for the BMC of the ASRock Rack X470D4U mainboard, which uses an ASPEED AST2500. The mainboard exists in three known flavors, the "normal" X470D4U, the X470D4U2-2T (with 2x10G RJ45) and the X470D4U2/1N1 (an ODM version with 2x1G RJ45 that is now available in retail). The 1N1 version also has a 64MB BMC SPI by default, but they are all swappable. All flavors will use the 32MB flash layout which should prevent unnecessary complexity of the device tree. Please note that this board has been fully reverse-engineered. Thanks, Tan Tan Siewert (2): dt-bindings: arm: aspeed: add ASRock X470D4U BMC ARM: dts: aspeed: add asrock x470d4u bmc .../bindings/arm/aspeed/aspeed.yaml | 1 + arch/arm/boot/dts/aspeed/Makefile | 1 + .../dts/aspeed/aspeed-bmc-asrock-x470d4u.dts | 345 ++++++++++++++++++ 3 files changed, 347 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dts -- 2.50.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] dt-bindings: arm: aspeed: add ASRock X470D4U BMC 2025-09-19 18:56 [PATCH 0/2] ARM: dts: aspeed: ASRock Rack X470D4U BMC support Tan Siewert @ 2025-09-19 18:56 ` Tan Siewert 2025-09-19 18:56 ` [PATCH 2/2] ARM: dts: aspeed: add asrock x470d4u bmc Tan Siewert 1 sibling, 0 replies; 8+ messages in thread From: Tan Siewert @ 2025-09-19 18:56 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery Cc: Tan Siewert, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel Document ASRock's X470D4U BMC board compatible. Signed-off-by: Tan Siewert <tan@siewert.io> --- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml index 456dbf7b5ec8..dc0fa22db5f7 100644 --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml @@ -38,6 +38,7 @@ properties: - asrock,e3c256d4i-bmc - asrock,romed8hm3-bmc - asrock,spc621d8hm3-bmc + - asrock,x470d4u-bmc - asrock,x570d4u-bmc - bytedance,g220a-bmc - facebook,cmm-bmc -- 2.50.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM: dts: aspeed: add asrock x470d4u bmc 2025-09-19 18:56 [PATCH 0/2] ARM: dts: aspeed: ASRock Rack X470D4U BMC support Tan Siewert 2025-09-19 18:56 ` [PATCH 1/2] dt-bindings: arm: aspeed: add ASRock X470D4U BMC Tan Siewert @ 2025-09-19 18:56 ` Tan Siewert 2025-09-22 20:07 ` Rob Herring 1 sibling, 1 reply; 8+ messages in thread From: Tan Siewert @ 2025-09-19 18:56 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery Cc: Tan Siewert, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel The ASRock Rack X470D4U X470D4U is a single-socket X470-based microATX motherboard for Ryzen processors with an AST2500 BMC and either 32MB or 64MB SPI flash. This mainboard exists in three known "flavors" which only differ in the used host NIC, the BMC SPI size and some parts that may be un-populated. To keep the complexity low with the BMC SPI, use the 32MB layout regardless of the used SPI or mainboard flavor. Signed-off-by: Tan Siewert <tan@siewert.io> --- arch/arm/boot/dts/aspeed/Makefile | 1 + .../dts/aspeed/aspeed-bmc-asrock-x470d4u.dts | 345 ++++++++++++++++++ 2 files changed, 346 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dts diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile index aba7451ab749..fae97b5183e5 100644 --- a/arch/arm/boot/dts/aspeed/Makefile +++ b/arch/arm/boot/dts/aspeed/Makefile @@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-asrock-e3c256d4i.dtb \ aspeed-bmc-asrock-romed8hm3.dtb \ aspeed-bmc-asrock-spc621d8hm3.dtb \ + aspeed-bmc-asrock-x470d4u.dtb \ aspeed-bmc-asrock-x570d4u.dtb \ aspeed-bmc-asus-x4tf.dtb \ aspeed-bmc-bytedance-g220a.dtb \ diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dts new file mode 100644 index 000000000000..bae2b521f708 --- /dev/null +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dts @@ -0,0 +1,345 @@ +// SPDX-License-Identifier: GPL-2.0+ +/dts-v1/; + +#include "aspeed-g5.dtsi" +#include <dt-bindings/gpio/aspeed-gpio.h> +#include <dt-bindings/leds/common.h> +#include <dt-bindings/interrupt-controller/irq.h> + +/ { + model = "Asrock Rack X470D4U-series BMC"; + compatible = "asrock,x470d4u-bmc", "aspeed,ast2500"; + + aliases { + serial4 = &uart5; + }; + + chosen { + stdout-path = &uart5; + }; + + iio-hwmon { + compatible = "iio-hwmon"; + io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>, <&adc 4>, + <&adc 5>, <&adc 6>, <&adc 7>, <&adc 8>, <&adc 9>, + <&adc 10>, <&adc 11>, <&adc 12>; + }; + + leds { + compatible = "gpio-leds"; + + heartbeat { + /* led-heartbeat-n */ + gpios = <&gpio ASPEED_GPIO(H, 6) GPIO_ACTIVE_LOW>; + linux,default-trigger = "timer"; + }; + + systemfault { + /* led-fault-n */ + gpios = <&gpio ASPEED_GPIO(Z, 2) GPIO_ACTIVE_LOW>; + panic-indicator; + }; + + identify { + /* led-identify-n */ + gpios = <&gpio ASPEED_GPIO(D, 6) GPIO_ACTIVE_LOW>; + }; + }; + + memory@80000000 { + reg = <0x80000000 0x20000000>; + }; + + reserved-memory { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + pci_memory: region@9a000000 { + no-map; + reg = <0x9a000000 0x00010000>; /* 64K */ + }; + + video_engine_memory: jpegbuffer { + size = <0x02800000>; /* 40M */ + alignment = <0x01000000>; + compatible = "shared-dma-pool"; + reusable; + }; + + gfx_memory: framebuffer { + size = <0x01000000>; + alignment = <0x01000000>; + compatible = "shared-dma-pool"; + reusable; + }; + }; +}; + +&adc { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_adc0_default /* 3VSB */ + &pinctrl_adc1_default /* 5VSB */ + &pinctrl_adc2_default /* VCPU */ + &pinctrl_adc3_default /* VSOC */ + &pinctrl_adc4_default /* VCCM */ + &pinctrl_adc5_default /* APU-VDDP */ + &pinctrl_adc6_default /* 1V05-PROM-S5 */ + &pinctrl_adc7_default /* 2V5-PROM */ + &pinctrl_adc8_default /* 1V05-PROM-RUN */ + &pinctrl_adc9_default /* VBAT */ + &pinctrl_adc10_default /* 3V */ + &pinctrl_adc11_default /* 5V */ + &pinctrl_adc12_default>; /* 12V */ +}; + +&ehci1 { + status = "okay"; +}; + +/* + * Although some board flavors have a 64MB SPI, use the + * 32MB SPI layout to be compatible with all boards. + */ +&fmc { + status = "okay"; + flash@0 { + status = "okay"; + label = "bmc"; + m25p,fast-read; + spi-max-frequency = <10000000>; +#include "openbmc-flash-layout.dtsi" + }; +}; + +&gfx { + status = "okay"; +}; + +&gpio { + status = "okay"; + gpio-line-names = + /* A */ "input-locatorled-n", "", "", "", "", "", "", "", + /* B */ "input-bios-post-cmplt-n", "", "", "", "", "", "", "", + /* C */ "", "", "", "", "", "", "", "", + /* D */ "button-power-n", "control-power-n", "button-reset-n", + "control-reset-n", "", "", "", "", + /* E */ "", "", "", "", "", "", "", "", + /* F */ "", "", "", "", "", "", "", "", + /* G */ "output-hwm-vbat-enable", "input-id0-n", "input-id1-n", + "input-id2-n", "input-aux-smb-alert-n", "", + "input-psu-smb-alert-n", "", + /* H */ "", "", "", "", "input-mfg-mode-n", "", + "led-heartbeat-n", "input-case-open-n", + /* I */ "", "", "", "", "", "", "", "", + /* J */ "output-bmc-ready-n", "output-bios-cs-n", "", "", "", "", + "", "", + /* K */ "", "", "", "", "", "", "", "", + /* L */ "", "", "", "", "", "", "", "", + /* M */ "", "", "", "", "", "", "", "", + /* N */ "", "", "", "", "", "", "", "", + /* O */ "", "", "", "", "", "", "", "", + /* P */ "", "", "", "", "", "", "", "", + /* Q */ "", "", "", "", "input-bmc-smb-present-n", "", "", + "input-pcie-wake-n", + /* R */ "", "", "", "", "", "", "", "", + /* S */ "input-bmc-pchhot-n", "", "", "", "", "", "", "", + /* T */ "", "", "", "", "", "", "", "", + /* U */ "", "", "", "", "", "", "", "", + /* V */ "", "", "", "", "", "", "", "", + /* W */ "", "", "", "", "", "", "", "", + /* X */ "", "", "", "", "", "", "", "", + /* Y */ "input-sleep-s3-n", "input-sleep-s5-n", "", "", "", "", + "", "", + /* Z */ "", "", "led-fault-n", "output-bmc-throttle-n", "", "", + "", "", + /* AA */ "input-cpu1-thermtrip-latch-n", "", + "input-cpu1-prochot-n", "", "", "", "", "", + /* AB */ "", "input-power-good", "", "hard-power-off", "", "", "", "", + /* AC */ "", "", "", "", "", "", "", ""; +}; + +&i2c0 { + /* SMBus on auxiliary panel header (AUX_PANEL1) */ + status = "okay"; +}; + +&i2c1 { + /* Hardware monitoring SMBus */ + status = "okay"; + + w83773g@4c { + compatible = "nuvoton,w83773g"; + reg = <0x4c>; + }; +}; + +&i2c2 { + /* PSU SMBus (PSU_SMB1) */ + status = "okay"; +}; + +&i2c3 { + status = "okay"; +}; + +&i2c4 { + status = "okay"; +}; + +&i2c6 { + /* SMBus on BMC connector (BMC_SMB_1) */ + status = "okay"; +}; + +&i2c7 { + /* FRU EEPROM */ + status = "okay"; + + eeprom@57 { + compatible = "st,24c128", "atmel,24c128"; + reg = <0x57>; + pagesize = <16>; + + nvmem-layout { + compatible = "fixed-layout"; + #address-cells = <1>; + #size-cells = <1>; + + eth0_macaddress: macaddress@3f80 { + reg = <0x3f80 6>; + }; + + eth1_macaddress: macaddress@3f88 { + reg = <0x3f88 6>; + }; + }; + }; +}; + +&i2c8 { + /* SMBus on intelligent platform management bus header (IPMB_1) */ + status = "okay"; +}; + +&kcs3 { + status = "okay"; + aspeed,lpc-io-reg = <0xca2>; +}; + +&lpc_ctrl { + status = "okay"; +}; + +&lpc_snoop { + status = "okay"; + snoop-ports = <0x80>; +}; + +&mac0 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rgmii1_default &pinctrl_mdio1_default>; + + nvmem-cells = <ð0_macaddress>; + nvmem-cell-names = "mac-address"; +}; + +&mac1 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rmii2_default &pinctrl_mdio2_default>; + use-ncsi; + + nvmem-cells = <ð1_macaddress>; + nvmem-cell-names = "mac-address"; +}; + +&pwm_tacho { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pwm0_default + &pinctrl_pwm1_default + &pinctrl_pwm2_default + &pinctrl_pwm3_default + &pinctrl_pwm4_default + &pinctrl_pwm5_default>; + + fan@0 { + /* FAN1 (4-pin) */ + reg = <0x00>; + aspeed,fan-tach-ch = /bits/ 8 <0x00>; + }; + + fan@1 { + /* FAN2 (4-pin) */ + reg = <0x01>; + aspeed,fan-tach-ch = /bits/ 8 <0x01>; + }; + + fan@2 { + /* FAN3 (4-pin) */ + reg = <0x02>; + aspeed,fan-tach-ch = /bits/ 8 <0x02>; + }; + + fan@3 { + /* FAN4 (6-pin) */ + reg = <0x03>; + aspeed,fan-tach-ch = /bits/ 8 <0x03 0x0b>; + }; + + fan@4 { + /* FAN5 (6-pin) */ + reg = <0x04>; + aspeed,fan-tach-ch = /bits/ 8 <0x04 0x0d>; + }; + + fan@5 { + /* FAN6 (6-pin) */ + reg = <0x05>; + aspeed,fan-tach-ch = /bits/ 8 <0x05 0x0e>; + }; +}; + +&p2a { + status = "okay"; + memory-region = <&pci_memory>; +}; + +&spi1 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_spi1_default>; + flash@0 { + status = "okay"; + label = "bios"; + m25p,fast-read; + /* Frequency extracted from original ROM */ + spi-max-frequency = <24000000>; /* 24 MHz */ + }; +}; + +&uhci { + status = "okay"; +}; + +&vhub { + status = "okay"; +}; + +&video { + status = "okay"; + memory-region = <&video_engine_memory>; +}; + +&vuart { + status = "okay"; + aspeed,lpc-io-reg = <0x2f8>; + aspeed,lpc-interrupts = <3 IRQ_TYPE_LEVEL_HIGH>; +}; + +&uart5 { + status = "okay"; +}; -- 2.50.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] ARM: dts: aspeed: add asrock x470d4u bmc 2025-09-19 18:56 ` [PATCH 2/2] ARM: dts: aspeed: add asrock x470d4u bmc Tan Siewert @ 2025-09-22 20:07 ` Rob Herring 2025-09-23 14:48 ` Tan Siewert 0 siblings, 1 reply; 8+ messages in thread From: Rob Herring @ 2025-09-22 20:07 UTC (permalink / raw) To: Tan Siewert Cc: Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On Fri, Sep 19, 2025 at 08:56:18PM +0200, Tan Siewert wrote: > The ASRock Rack X470D4U X470D4U is a single-socket X470-based microATX > motherboard for Ryzen processors with an AST2500 BMC and either 32MB or > 64MB SPI flash. > > This mainboard exists in three known "flavors" which only differ in the > used host NIC, the BMC SPI size and some parts that may be un-populated. > > To keep the complexity low with the BMC SPI, use the 32MB layout > regardless of the used SPI or mainboard flavor. > > Signed-off-by: Tan Siewert <tan@siewert.io> > --- > arch/arm/boot/dts/aspeed/Makefile | 1 + > .../dts/aspeed/aspeed-bmc-asrock-x470d4u.dts | 345 ++++++++++++++++++ > 2 files changed, 346 insertions(+) > create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dts > > diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile > index aba7451ab749..fae97b5183e5 100644 > --- a/arch/arm/boot/dts/aspeed/Makefile > +++ b/arch/arm/boot/dts/aspeed/Makefile > @@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > aspeed-bmc-asrock-e3c256d4i.dtb \ > aspeed-bmc-asrock-romed8hm3.dtb \ > aspeed-bmc-asrock-spc621d8hm3.dtb \ > + aspeed-bmc-asrock-x470d4u.dtb \ > aspeed-bmc-asrock-x570d4u.dtb \ > aspeed-bmc-asus-x4tf.dtb \ > aspeed-bmc-bytedance-g220a.dtb \ > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dts > new file mode 100644 > index 000000000000..bae2b521f708 > --- /dev/null > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dts > @@ -0,0 +1,345 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/dts-v1/; > + > +#include "aspeed-g5.dtsi" > +#include <dt-bindings/gpio/aspeed-gpio.h> > +#include <dt-bindings/leds/common.h> > +#include <dt-bindings/interrupt-controller/irq.h> > + > +/ { > + model = "Asrock Rack X470D4U-series BMC"; > + compatible = "asrock,x470d4u-bmc", "aspeed,ast2500"; > + > + aliases { > + serial4 = &uart5; > + }; > + > + chosen { > + stdout-path = &uart5; > + }; > + > + iio-hwmon { > + compatible = "iio-hwmon"; > + io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>, <&adc 4>, > + <&adc 5>, <&adc 6>, <&adc 7>, <&adc 8>, <&adc 9>, > + <&adc 10>, <&adc 11>, <&adc 12>; > + }; > + > + leds { > + compatible = "gpio-leds"; > + > + heartbeat { led-0 This should have given you a warning. You did run "make dtbs_check" check the warnings, right? Use "function" to define the function. > + /* led-heartbeat-n */ > + gpios = <&gpio ASPEED_GPIO(H, 6) GPIO_ACTIVE_LOW>; > + linux,default-trigger = "timer"; > + }; > + > + systemfault { led-1 > + /* led-fault-n */ > + gpios = <&gpio ASPEED_GPIO(Z, 2) GPIO_ACTIVE_LOW>; > + panic-indicator; > + }; > + > + identify { led-2 > + /* led-identify-n */ > + gpios = <&gpio ASPEED_GPIO(D, 6) GPIO_ACTIVE_LOW>; > + }; > + }; > + ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] ARM: dts: aspeed: add asrock x470d4u bmc 2025-09-22 20:07 ` Rob Herring @ 2025-09-23 14:48 ` Tan Siewert 2025-09-24 1:58 ` Andrew Jeffery 2025-10-12 3:03 ` Krzysztof Kozlowski 0 siblings, 2 replies; 8+ messages in thread From: Tan Siewert @ 2025-09-23 14:48 UTC (permalink / raw) To: Rob Herring Cc: Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On 22.09.25 22:07, Rob Herring wrote: > On Fri, Sep 19, 2025 at 08:56:18PM +0200, Tan Siewert wrote: >> The ASRock Rack X470D4U X470D4U is a single-socket X470-based microATX >> motherboard for Ryzen processors with an AST2500 BMC and either 32MB or >> 64MB SPI flash. >> >> This mainboard exists in three known "flavors" which only differ in the >> used host NIC, the BMC SPI size and some parts that may be un-populated. >> >> To keep the complexity low with the BMC SPI, use the 32MB layout >> regardless of the used SPI or mainboard flavor. >> >> Signed-off-by: Tan Siewert <tan@siewert.io> >> --- >> arch/arm/boot/dts/aspeed/Makefile | 1 + >> .../dts/aspeed/aspeed-bmc-asrock-x470d4u.dts | 345 ++++++++++++++++++ >> 2 files changed, 346 insertions(+) >> create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dts >> >> diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile >> index aba7451ab749..fae97b5183e5 100644 >> --- a/arch/arm/boot/dts/aspeed/Makefile >> +++ b/arch/arm/boot/dts/aspeed/Makefile >> @@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ >> aspeed-bmc-asrock-e3c256d4i.dtb \ >> aspeed-bmc-asrock-romed8hm3.dtb \ >> aspeed-bmc-asrock-spc621d8hm3.dtb \ >> + aspeed-bmc-asrock-x470d4u.dtb \ >> aspeed-bmc-asrock-x570d4u.dtb \ >> aspeed-bmc-asus-x4tf.dtb \ >> aspeed-bmc-bytedance-g220a.dtb \ >> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dts >> new file mode 100644 >> index 000000000000..bae2b521f708 >> --- /dev/null >> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dts >> @@ -0,0 +1,345 @@ >> +// SPDX-License-Identifier: GPL-2.0+ >> +/dts-v1/; >> + >> +#include "aspeed-g5.dtsi" >> +#include <dt-bindings/gpio/aspeed-gpio.h> >> +#include <dt-bindings/leds/common.h> >> +#include <dt-bindings/interrupt-controller/irq.h> >> + >> +/ { >> + model = "Asrock Rack X470D4U-series BMC"; >> + compatible = "asrock,x470d4u-bmc", "aspeed,ast2500"; >> + >> + aliases { >> + serial4 = &uart5; >> + }; >> + >> + chosen { >> + stdout-path = &uart5; >> + }; >> + >> + iio-hwmon { >> + compatible = "iio-hwmon"; >> + io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>, <&adc 4>, >> + <&adc 5>, <&adc 6>, <&adc 7>, <&adc 8>, <&adc 9>, >> + <&adc 10>, <&adc 11>, <&adc 12>; >> + }; >> + >> + leds { >> + compatible = "gpio-leds"; >> + >> + heartbeat { > > led-0 I guess `led-heartbeat` would be fine too, right? > > This should have given you a warning. You did run "make dtbs_check" > check the warnings, right? I did and there were no warnings, even after a full clean. The full command I ran before submitting was `make dtbs_check W=1 DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml` Maybe I am missing something here? The dt-schema version I am using is `2025.9.dev1+g4b28bc79f`. > > Use "function" to define the function. Thanks for your review, Rob! I will fix the led naming in the next version. -- Tan > >> + /* led-heartbeat-n */ >> + gpios = <&gpio ASPEED_GPIO(H, 6) GPIO_ACTIVE_LOW>; >> + linux,default-trigger = "timer"; >> + }; >> + >> + systemfault { > > led-1 > >> + /* led-fault-n */ >> + gpios = <&gpio ASPEED_GPIO(Z, 2) GPIO_ACTIVE_LOW>; >> + panic-indicator; >> + }; >> + >> + identify { > > led-2 > >> + /* led-identify-n */ >> + gpios = <&gpio ASPEED_GPIO(D, 6) GPIO_ACTIVE_LOW>; >> + }; >> + }; >> + ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] ARM: dts: aspeed: add asrock x470d4u bmc 2025-09-23 14:48 ` Tan Siewert @ 2025-09-24 1:58 ` Andrew Jeffery 2025-10-12 3:03 ` Krzysztof Kozlowski 1 sibling, 0 replies; 8+ messages in thread From: Andrew Jeffery @ 2025-09-24 1:58 UTC (permalink / raw) To: Tan Siewert, Rob Herring Cc: Krzysztof Kozlowski, Conor Dooley, Joel Stanley, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On Tue, 2025-09-23 at 16:48 +0200, Tan Siewert wrote: > On 22.09.25 22:07, Rob Herring wrote: > > On Fri, Sep 19, 2025 at 08:56:18PM +0200, Tan Siewert wrote: *snip* > > > +/ { > > > + model = "Asrock Rack X470D4U-series BMC"; > > > + compatible = "asrock,x470d4u-bmc", "aspeed,ast2500"; > > > + > > > + aliases { > > > + serial4 = &uart5; > > > + }; > > > + > > > + chosen { > > > + stdout-path = &uart5; > > > + }; > > > + > > > + iio-hwmon { > > > + compatible = "iio-hwmon"; > > > + io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>, <&adc 4>, > > > + <&adc 5>, <&adc 6>, <&adc 7>, <&adc 8>, <&adc 9>, > > > + <&adc 10>, <&adc 11>, <&adc 12>; > > > + }; > > > + > > > + leds { > > > + compatible = "gpio-leds"; > > > + > > > + heartbeat { > > > > led-0 > > I guess `led-heartbeat` would be fine too, right? > > > > > This should have given you a warning. You did run "make dtbs_check" > > check the warnings, right? > > I did and there were no warnings, even after a full clean. The full > command I ran before submitting was `make dtbs_check W=1 > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml` Ah, so that's probably unhelpful, as you're excluding all the other schemas. Rather, try: make -j$(nproc) CHECK_DTBS=y aspeed/aspeed-bmc-asrock-x470d4u.dtb Running that on your series locally produces: SCHEMA Documentation/devicetree/bindings/processed-schema.json HOSTLD scripts/dtc/dtc DTC [C] arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: /ahb/apb/memory-controller@1e6e0000: failed to match any schema with compatible: ['aspeed,ast2500-sdram-edac'] arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: /ahb/apb/syscon@1e6e2000/p2a-control@2c: failed to match any schema with compatible: ['aspeed,ast2500-p2a-ctrl'] arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: /ahb/apb/display@1e6e6000: failed to match any schema with compatible: ['aspeed,ast2500-gfx', 'syscon'] arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: /ahb/apb/timer@1e782000: failed to match any schema with compatible: ['aspeed,ast2400-timer'] arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: /ahb/apb/pwm-tacho-controller@1e786000: failed to match any schema with compatible: ['aspeed,ast2500-pwm-tacho'] /home/andrew/src/kernel.org/linux/origin/build.arm.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: fan@1: aspeed,fan-tach-ch: b'\x01' is not of type 'object', 'integer', 'array', 'boolean', 'null' from schema $id: http://devicetree.org/schemas/dt-core.yaml# /home/andrew/src/kernel.org/linux/origin/build.arm.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: fan@2: aspeed,fan-tach-ch: b'\x02' is not of type 'object', 'integer', 'array', 'boolean', 'null' from schema $id: http://devicetree.org/schemas/dt-core.yaml# /home/andrew/src/kernel.org/linux/origin/build.arm.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: fan@3: aspeed,fan-tach-ch: b'\x03\x0b' is not of type 'object', 'integer', 'array', 'boolean', 'null' from schema $id: http://devicetree.org/schemas/dt-core.yaml# /home/andrew/src/kernel.org/linux/origin/build.arm.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: fan@4: aspeed,fan-tach-ch: b'\x04\r' is not of type 'object', 'integer', 'array', 'boolean', 'null' from schema $id: http://devicetree.org/schemas/dt-core.yaml# /home/andrew/src/kernel.org/linux/origin/build.arm.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: fan@5: aspeed,fan-tach-ch: b'\x05\x0e' is not of type 'object', 'integer', 'array', 'boolean', 'null' from schema $id: http://devicetree.org/schemas/dt-core.yaml# /home/andrew/src/kernel.org/linux/origin/build.arm.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: lpc@1e789000 (aspeed,ast2500-lpc-v2): lpc-snoop@90: 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/mfd/aspeed-lpc.yaml# /home/andrew/src/kernel.org/linux/origin/build.arm.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: kcs@24 (aspeed,ast2500-kcs-bmc-v2): 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# /home/andrew/src/kernel.org/linux/origin/build.arm.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: kcs@28 (aspeed,ast2500-kcs-bmc-v2): 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# /home/andrew/src/kernel.org/linux/origin/build.arm.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: kcs@2c (aspeed,ast2500-kcs-bmc-v2): 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# /home/andrew/src/kernel.org/linux/origin/build.arm.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: kcs@114 (aspeed,ast2500-kcs-bmc-v2): 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: /ahb/apb/lpc@1e789000/lhc@a0: failed to match any schema with compatible: ['aspeed,ast2500-lhc'] arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: /ahb/apb/lpc@1e789000/ibt@140: failed to match any schema with compatible: ['aspeed,ast2500-ibt-bmc'] /home/andrew/src/kernel.org/linux/origin/build.arm.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: leds (gpio-leds): 'heartbeat', 'identify', 'systemfault' do not match any of the regexes: '(^led-[0-9a-f]$|led)', '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/leds/leds-gpio.yaml# Andrew ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] ARM: dts: aspeed: add asrock x470d4u bmc 2025-09-23 14:48 ` Tan Siewert 2025-09-24 1:58 ` Andrew Jeffery @ 2025-10-12 3:03 ` Krzysztof Kozlowski 1 sibling, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2025-10-12 3:03 UTC (permalink / raw) To: Tan Siewert, Rob Herring Cc: Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On 23/09/2025 16:48, Tan Siewert wrote: > On 22.09.25 22:07, Rob Herring wrote: >> On Fri, Sep 19, 2025 at 08:56:18PM +0200, Tan Siewert wrote: >>> The ASRock Rack X470D4U X470D4U is a single-socket X470-based microATX >>> motherboard for Ryzen processors with an AST2500 BMC and either 32MB or >>> 64MB SPI flash. >>> >>> This mainboard exists in three known "flavors" which only differ in the >>> used host NIC, the BMC SPI size and some parts that may be un-populated. >>> >>> To keep the complexity low with the BMC SPI, use the 32MB layout >>> regardless of the used SPI or mainboard flavor. >>> >>> Signed-off-by: Tan Siewert <tan@siewert.io> >>> --- >>> arch/arm/boot/dts/aspeed/Makefile | 1 + >>> .../dts/aspeed/aspeed-bmc-asrock-x470d4u.dts | 345 ++++++++++++++++++ >>> 2 files changed, 346 insertions(+) >>> create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dts >>> >>> diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile >>> index aba7451ab749..fae97b5183e5 100644 >>> --- a/arch/arm/boot/dts/aspeed/Makefile >>> +++ b/arch/arm/boot/dts/aspeed/Makefile >>> @@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ >>> aspeed-bmc-asrock-e3c256d4i.dtb \ >>> aspeed-bmc-asrock-romed8hm3.dtb \ >>> aspeed-bmc-asrock-spc621d8hm3.dtb \ >>> + aspeed-bmc-asrock-x470d4u.dtb \ >>> aspeed-bmc-asrock-x570d4u.dtb \ >>> aspeed-bmc-asus-x4tf.dtb \ >>> aspeed-bmc-bytedance-g220a.dtb \ >>> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dts >>> new file mode 100644 >>> index 000000000000..bae2b521f708 >>> --- /dev/null >>> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dts >>> @@ -0,0 +1,345 @@ >>> +// SPDX-License-Identifier: GPL-2.0+ >>> +/dts-v1/; >>> + >>> +#include "aspeed-g5.dtsi" >>> +#include <dt-bindings/gpio/aspeed-gpio.h> >>> +#include <dt-bindings/leds/common.h> >>> +#include <dt-bindings/interrupt-controller/irq.h> >>> + >>> +/ { >>> + model = "Asrock Rack X470D4U-series BMC"; >>> + compatible = "asrock,x470d4u-bmc", "aspeed,ast2500"; >>> + >>> + aliases { >>> + serial4 = &uart5; >>> + }; >>> + >>> + chosen { >>> + stdout-path = &uart5; >>> + }; >>> + >>> + iio-hwmon { >>> + compatible = "iio-hwmon"; >>> + io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>, <&adc 4>, >>> + <&adc 5>, <&adc 6>, <&adc 7>, <&adc 8>, <&adc 9>, >>> + <&adc 10>, <&adc 11>, <&adc 12>; >>> + }; >>> + >>> + leds { >>> + compatible = "gpio-leds"; >>> + >>> + heartbeat { >> >> led-0 > > I guess `led-heartbeat` would be fine too, right? > >> >> This should have given you a warning. You did run "make dtbs_check" >> check the warnings, right? > > I did and there were no warnings, even after a full clean. The full > command I ran before submitting was `make dtbs_check W=1 > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml` This is not the command to run. You run `make dtbs_check W=1`. See my slides from OSSEU for introduction to Devicetree. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] ARM: dts: aspeed: add asrock x470d4u bmc
@ 2025-09-22 12:08 kernel test robot
0 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2025-09-22 12:08 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp
::::::
:::::: Manual check reason: "dtcheck: binding changes may go via different trees"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250919185621.6647-3-tan@siewert.io>
References: <20250919185621.6647-3-tan@siewert.io>
TO: Tan Siewert <tan@siewert.io>
TO: Rob Herring <robh@kernel.org>
TO: Krzysztof Kozlowski <krzk@kernel.org>
TO: Conor Dooley <conor+dt@kernel.org>
TO: Joel Stanley <joel@jms.id.au>
TO: Andrew Jeffery <andrew@codeconstruct.com.au>
CC: Tan Siewert <tan@siewert.io>
CC: devicetree@vger.kernel.org
CC: linux-arm-kernel@lists.infradead.org
CC: linux-aspeed@lists.ozlabs.org
CC: linux-kernel@vger.kernel.org
Hi Tan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on krzk/for-next krzk-dt/for-next krzk-mem-ctrl/for-next linus/master v6.17-rc7 next-20250919]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Tan-Siewert/dt-bindings-arm-aspeed-add-ASRock-X470D4U-BMC/20250920-025905
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20250919185621.6647-3-tan%40siewert.io
patch subject: [PATCH 2/2] ARM: dts: aspeed: add asrock x470d4u bmc
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: arm-randconfig-052-20250921 (https://download.01.org/0day-ci/archive/20250922/202509221943.VXrBqhlr-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.3.0
dtschema version: 2025.9.dev1+g4b28bc79f
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250922/202509221943.VXrBqhlr-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202509221943.VXrBqhlr-lkp@intel.com/
dtcheck warnings: (new ones prefixed by >>)
>> arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: /ahb/apb/memory-controller@1e6e0000: failed to match any schema with compatible: ['aspeed,ast2500-sdram-edac']
arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: /ahb/apb/syscon@1e6e2000/p2a-control@2c: failed to match any schema with compatible: ['aspeed,ast2500-p2a-ctrl']
arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: display@1e6e6000 (aspeed,ast2500-gfx): 'reg-io-width' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/gpu/aspeed,ast2400-gfx.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: display@1e6e6000 (aspeed,ast2500-gfx): 'memory-region' is a required property
from schema $id: http://devicetree.org/schemas/gpu/aspeed,ast2400-gfx.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: /ahb/apb/timer@1e782000: failed to match any schema with compatible: ['aspeed,ast2400-timer']
arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: /ahb/apb/pwm-tacho-controller@1e786000: failed to match any schema with compatible: ['aspeed,ast2500-pwm-tacho']
arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: fan@1: aspeed,fan-tach-ch: b'\x01' is not of type 'object', 'integer', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dtb: fan@2: aspeed,fan-tach-ch: b'\x02' is not of type 'object', 'integer', 'array', 'boolean', 'null'
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 8+ messages in threadend of thread, other threads:[~2025-10-12 3:03 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-09-19 18:56 [PATCH 0/2] ARM: dts: aspeed: ASRock Rack X470D4U BMC support Tan Siewert 2025-09-19 18:56 ` [PATCH 1/2] dt-bindings: arm: aspeed: add ASRock X470D4U BMC Tan Siewert 2025-09-19 18:56 ` [PATCH 2/2] ARM: dts: aspeed: add asrock x470d4u bmc Tan Siewert 2025-09-22 20:07 ` Rob Herring 2025-09-23 14:48 ` Tan Siewert 2025-09-24 1:58 ` Andrew Jeffery 2025-10-12 3:03 ` Krzysztof Kozlowski -- strict thread matches above, loose matches on Subject: below -- 2025-09-22 12:08 kernel test robot
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.