All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
Cc: krzk+dt@kernel.org, conor+dt@kernel.org, kishon@kernel.org,
	vkoul@kernel.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-phy@lists.infradead.org
Subject: Re: [PATCH 3/9] dt-bindings: phy: qcom-m31-eusb2: Add Glymur compatible
Date: Mon, 22 Sep 2025 15:14:49 -0500	[thread overview]
Message-ID: <20250922201449.GA1235521-robh@kernel.org> (raw)
In-Reply-To: <20250920032108.242643-4-wesley.cheng@oss.qualcomm.com>

On Fri, Sep 19, 2025 at 08:21:02PM -0700, Wesley Cheng wrote:
> Add the Glymur compatible to the M31 eUSB2 PHY, and use the SM8750 as
> the fallback.
> 
> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> ---
>  .../devicetree/bindings/phy/qcom,m31-eusb2-phy.yaml   | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,m31-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,m31-eusb2-phy.yaml
> index c84c62d0e8cb..b96b1ee80257 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,m31-eusb2-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,m31-eusb2-phy.yaml
> @@ -15,9 +15,12 @@ description:
>  
>  properties:
>    compatible:
> -    items:
> -      - enum:
> -          - qcom,sm8750-m31-eusb2-phy
> +    oneOf:
> +      - items:
> +          - enum:
> +              - qcom,glymur-m31-eusb2-phy
> +          - const: qcom,sm8750-m31-eusb2-phy
> +      - const: qcom,sm8750-m31-eusb2-phy
>  
>    reg:
>      maxItems: 1
> @@ -53,8 +56,6 @@ required:
>    - compatible
>    - reg
>    - "#phy-cells"
> -  - clocks
> -  - clock-names

How is it compatible if clocks aren't required now? And clocks are 
suddenly no longer required on sm8750?

>    - resets
>    - vdd-supply
>    - vdda12-supply

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
Cc: krzk+dt@kernel.org, conor+dt@kernel.org, kishon@kernel.org,
	vkoul@kernel.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-phy@lists.infradead.org
Subject: Re: [PATCH 3/9] dt-bindings: phy: qcom-m31-eusb2: Add Glymur compatible
Date: Mon, 22 Sep 2025 15:14:49 -0500	[thread overview]
Message-ID: <20250922201449.GA1235521-robh@kernel.org> (raw)
In-Reply-To: <20250920032108.242643-4-wesley.cheng@oss.qualcomm.com>

On Fri, Sep 19, 2025 at 08:21:02PM -0700, Wesley Cheng wrote:
> Add the Glymur compatible to the M31 eUSB2 PHY, and use the SM8750 as
> the fallback.
> 
> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
> ---
>  .../devicetree/bindings/phy/qcom,m31-eusb2-phy.yaml   | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,m31-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,m31-eusb2-phy.yaml
> index c84c62d0e8cb..b96b1ee80257 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,m31-eusb2-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,m31-eusb2-phy.yaml
> @@ -15,9 +15,12 @@ description:
>  
>  properties:
>    compatible:
> -    items:
> -      - enum:
> -          - qcom,sm8750-m31-eusb2-phy
> +    oneOf:
> +      - items:
> +          - enum:
> +              - qcom,glymur-m31-eusb2-phy
> +          - const: qcom,sm8750-m31-eusb2-phy
> +      - const: qcom,sm8750-m31-eusb2-phy
>  
>    reg:
>      maxItems: 1
> @@ -53,8 +56,6 @@ required:
>    - compatible
>    - reg
>    - "#phy-cells"
> -  - clocks
> -  - clock-names

How is it compatible if clocks aren't required now? And clocks are 
suddenly no longer required on sm8750?

>    - resets
>    - vdd-supply
>    - vdda12-supply

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2025-09-22 20:14 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-20  3:20 [PATCH 0/9] Introduce Glymur USB support Wesley Cheng
2025-09-20  3:20 ` Wesley Cheng
2025-09-20  3:21 ` [PATCH 1/9] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add Glymur compatible Wesley Cheng
2025-09-20  3:21   ` Wesley Cheng
2025-09-20 15:18   ` Dmitry Baryshkov
2025-09-20 15:18     ` Dmitry Baryshkov
2025-09-22 20:52     ` Wesley Cheng
2025-09-22 20:52       ` Wesley Cheng
2025-09-24 12:31       ` Konrad Dybcio
2025-09-24 12:31         ` Konrad Dybcio
2025-09-20  3:21 ` [PATCH 2/9] dt-bindings: phy: qcom,qmp-usb: Add Glymur USB UNI PHY compatible Wesley Cheng
2025-09-20  3:21   ` Wesley Cheng
2025-09-20 15:22   ` Dmitry Baryshkov
2025-09-20 15:22     ` Dmitry Baryshkov
2025-09-23  1:00     ` Wesley Cheng
2025-09-23  1:00       ` Wesley Cheng
2025-09-23  3:40       ` Dmitry Baryshkov
2025-09-23  3:40         ` Dmitry Baryshkov
2025-09-23 19:36         ` Wesley Cheng
2025-09-23 19:36           ` Wesley Cheng
2025-09-23  7:27       ` Johan Hovold
2025-09-23  7:27         ` Johan Hovold
2025-09-23 21:51         ` Wesley Cheng
2025-09-23 21:51           ` Wesley Cheng
2025-09-20  3:21 ` [PATCH 3/9] dt-bindings: phy: qcom-m31-eusb2: Add Glymur compatible Wesley Cheng
2025-09-20  3:21   ` Wesley Cheng
2025-09-22 20:14   ` Rob Herring [this message]
2025-09-22 20:14     ` Rob Herring
2025-09-23  1:02     ` Wesley Cheng
2025-09-23  1:02       ` Wesley Cheng
2025-09-24  1:00       ` Wesley Cheng
2025-09-24  1:00         ` Wesley Cheng
2025-09-20  3:21 ` [PATCH 4/9] dt-bindings: usb: qcom,snps-dwc3: " Wesley Cheng
2025-09-20  3:21   ` Wesley Cheng
2025-09-20  3:21 ` [PATCH 5/9] phy: qualcomm: Update the QMP clamp register for V6 Wesley Cheng
2025-09-20  3:21   ` Wesley Cheng
2025-09-20 15:28   ` Dmitry Baryshkov
2025-09-20 15:28     ` Dmitry Baryshkov
2025-09-20  3:21 ` [PATCH 6/9] phy: qualcomm: qmp-combo: Update QMP PHY with Glymur settings Wesley Cheng
2025-09-20  3:21   ` Wesley Cheng
2025-09-20 15:31   ` Dmitry Baryshkov
2025-09-20 15:31     ` Dmitry Baryshkov
2025-09-20 17:12   ` kernel test robot
2025-09-20 17:12     ` kernel test robot
2025-09-20  3:21 ` [PATCH 7/9] phy: qualcomm: qmp-usb: Add support for Glymur USB UNI PHY Wesley Cheng
2025-09-20  3:21   ` Wesley Cheng
2025-09-20  3:21 ` [PATCH 8/9] phy: qualcomm: m31-eusb2: Make clkref an optional resource Wesley Cheng
2025-09-20  3:21   ` Wesley Cheng
2025-09-20 15:33   ` Dmitry Baryshkov
2025-09-20 15:33     ` Dmitry Baryshkov
2025-09-20  3:21 ` [PATCH 9/9] phy: qualcomm: m31-eusb2: Make USB repeater optional Wesley Cheng
2025-09-20  3:21   ` Wesley Cheng
2025-09-20 15:42   ` Dmitry Baryshkov
2025-09-20 15:42     ` Dmitry Baryshkov
2025-09-23  1:03     ` Wesley Cheng
2025-09-23  1:03       ` Wesley Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250922201449.GA1235521-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=vkoul@kernel.org \
    --cc=wesley.cheng@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.