* [merged mm-stable] mm-damon-sysfs-set-damon_ctx-min_sz_region-only-for-paddr-use-case.patch removed from -mm tree
@ 2025-09-23 3:18 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2025-09-23 3:18 UTC (permalink / raw)
To: mm-commits, zuoze1, wangkefeng.wang, clm, sj, akpm
The quilt patch titled
Subject: mm/damon/sysfs: set damon_ctx->min_sz_region only for paddr use case
has been removed from the -mm tree. Its filename was
mm-damon-sysfs-set-damon_ctx-min_sz_region-only-for-paddr-use-case.patch
This patch was dropped because it was merged into the mm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: SeongJae Park <sj@kernel.org>
Subject: mm/damon/sysfs: set damon_ctx->min_sz_region only for paddr use case
Date: Wed, 17 Sep 2025 08:31:54 -0700
damon_ctx->addr_unit is respected only for physical address space
monitoring use case. Meanwhile, damon_ctx->min_sz_region is used by the
core layer for aligning regions, regardless of whether it is set for
physical address space monitoring or virtual address spaces monitoring.
And it is set as 'DAMON_MIN_REGION / damon_ctx->addr_unit'. Hence, if
user sets ->addr_unit on virtual address spaces monitoring mode, regions
can be unexpectedly aligned in <PAGE_SIZE granularity. It shouldn't cause
crash-like issues but make monitoring and DAMOS behavior difficult to
understand.
Fix the unexpected behavior by setting ->min_sz_region only when it is
configured for physical address space monitoring.
The issue was found from a result of Chris' experiments that thankfully
shared with me off-list.
Link: https://lkml.kernel.org/r/20250917160041.53187-1-sj@kernel.org
Fixes: d8f867fa0825 ("mm/damon: add damon_ctx->min_sz_region")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Chris Mason <clm@fb.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: ze zuo <zuoze1@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/damon/sysfs.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--- a/mm/damon/sysfs.c~mm-damon-sysfs-set-damon_ctx-min_sz_region-only-for-paddr-use-case
+++ a/mm/damon/sysfs.c
@@ -1435,7 +1435,10 @@ static int damon_sysfs_apply_inputs(stru
if (err)
return err;
ctx->addr_unit = sys_ctx->addr_unit;
- ctx->min_sz_region = max(DAMON_MIN_REGION / sys_ctx->addr_unit, 1);
+ /* addr_unit is respected by only DAMON_OPS_PADDR */
+ if (sys_ctx->ops_id == DAMON_OPS_PADDR)
+ ctx->min_sz_region = max(
+ DAMON_MIN_REGION / sys_ctx->addr_unit, 1);
err = damon_sysfs_set_attrs(ctx, sys_ctx->attrs);
if (err)
return err;
_
Patches currently in -mm which might be from sj@kernel.org are
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-09-23 3:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-23 3:18 [merged mm-stable] mm-damon-sysfs-set-damon_ctx-min_sz_region-only-for-paddr-use-case.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.