From: Jakub Kicinski <kuba@kernel.org>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: Andrew Lunn <andrew@lunn.ch>,
Michael Chan <michael.chan@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
Tariq Toukan <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
intel-wired-lan@lists.osuosl.org,
Donald Hunter <donald.hunter@gmail.com>,
Carolina Jubran <cjubran@nvidia.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, Yael Chemla <ychemla@nvidia.com>,
Dragos Tatulea <dtatulea@nvidia.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next v5 3/5] net/mlx5e: Add logic to read RS-FEC histogram bin ranges from PPHCR
Date: Tue, 23 Sep 2025 17:34:38 -0700 [thread overview]
Message-ID: <20250923173438.70295e44@kernel.org> (raw)
In-Reply-To: <20250922100741.2167024-4-vadim.fedorenko@linux.dev>
On Mon, 22 Sep 2025 10:07:39 +0000 Vadim Fedorenko wrote:
> +#define MLX5E_FEC_RS_HIST_MAX 16
I'm guessing you insist on the checks because
struct mlx5_ifc_rs_histogram_cntrs_bits hardcodes the size of the hist array as 16.
Please make this define use ARRAY_SIZE() or some such, instead of this
random looking number.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: Andrew Lunn <andrew@lunn.ch>,
Michael Chan <michael.chan@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
Tariq Toukan <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
intel-wired-lan@lists.osuosl.org,
Donald Hunter <donald.hunter@gmail.com>,
Carolina Jubran <cjubran@nvidia.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, Yael Chemla <ychemla@nvidia.com>,
Dragos Tatulea <dtatulea@nvidia.com>
Subject: Re: [PATCH net-next v5 3/5] net/mlx5e: Add logic to read RS-FEC histogram bin ranges from PPHCR
Date: Tue, 23 Sep 2025 17:34:38 -0700 [thread overview]
Message-ID: <20250923173438.70295e44@kernel.org> (raw)
In-Reply-To: <20250922100741.2167024-4-vadim.fedorenko@linux.dev>
On Mon, 22 Sep 2025 10:07:39 +0000 Vadim Fedorenko wrote:
> +#define MLX5E_FEC_RS_HIST_MAX 16
I'm guessing you insist on the checks because
struct mlx5_ifc_rs_histogram_cntrs_bits hardcodes the size of the hist array as 16.
Please make this define use ARRAY_SIZE() or some such, instead of this
random looking number.
next prev parent reply other threads:[~2025-09-24 0:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 10:07 [Intel-wired-lan] [PATCH net-next v5 0/5] add FEC bins histogram report via ethtool Vadim Fedorenko
2025-09-22 10:07 ` Vadim Fedorenko
2025-09-22 10:07 ` [Intel-wired-lan] [PATCH net-next v5 1/5] ethtool: add FEC bins histogram report Vadim Fedorenko
2025-09-22 10:07 ` Vadim Fedorenko
2025-09-24 0:27 ` [Intel-wired-lan] " Jakub Kicinski
2025-09-24 0:27 ` Jakub Kicinski
2025-09-22 10:07 ` [Intel-wired-lan] [PATCH net-next v5 2/5] net/mlx5e: Don't query FEC statistics when FEC is disabled Vadim Fedorenko
2025-09-22 10:07 ` Vadim Fedorenko
2025-09-22 10:07 ` [Intel-wired-lan] [PATCH net-next v5 3/5] net/mlx5e: Add logic to read RS-FEC histogram bin ranges from PPHCR Vadim Fedorenko
2025-09-22 10:07 ` Vadim Fedorenko
2025-09-24 0:34 ` Jakub Kicinski [this message]
2025-09-24 0:34 ` Jakub Kicinski
2025-09-22 10:07 ` [Intel-wired-lan] [PATCH net-next v5 4/5] net/mlx5e: Report RS-FEC histogram statistics via ethtool Vadim Fedorenko
2025-09-22 10:07 ` Vadim Fedorenko
2025-09-22 10:07 ` [Intel-wired-lan] [PATCH net-next v5 5/5] selftests: net-drv: stats: sanity check FEC histogram Vadim Fedorenko
2025-09-22 10:07 ` Vadim Fedorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250923173438.70295e44@kernel.org \
--to=kuba@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=donald.hunter@gmail.com \
--cc=dtatulea@nvidia.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=tariqt@nvidia.com \
--cc=vadim.fedorenko@linux.dev \
--cc=ychemla@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.