[PATCH rdma-next] RDMA/irdma: Fix SD index calculation

[PATCH rdma-next] RDMA/irdma: Fix SD index calculation

[Jacob Moroni]

In some cases, it is possible for pble_rsrc->next_fpm_addr to be
larger than u32, so remove the u32 cast to avoid unintentional
truncation.

This fixes the following error that can be observed when registering
massive memory regions:

[  447.227494] (NULL ib_device): cqp opcode = 0x1f maj_err_code = 0xffff min_err_code = 0x800c
[  447.227505] (NULL ib_device): [Update PE SDs Cmd Error][op_code=21] status=-5 waiting=1 completion_err=1 maj=0xffff min=0x800c

Fixes: e8c4dbc2fcac ("RDMA/irdma: Add PBLE resource manager")
Signed-off-by: Jacob Moroni <jmoroni@google.com>
---
 drivers/infiniband/hw/irdma/pble.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/irdma/pble.c b/drivers/infiniband/hw/irdma/pble.c
index 3091f9345..fa6325ada 100644
--- a/drivers/infiniband/hw/irdma/pble.c
+++ b/drivers/infiniband/hw/irdma/pble.c
@@ -71,7 +71,7 @@ int irdma_hmc_init_pble(struct irdma_sc_dev *dev,
 static void get_sd_pd_idx(struct irdma_hmc_pble_rsrc *pble_rsrc,
 			  struct sd_pd_idx *idx)
 {
-	idx->sd_idx = (u32)pble_rsrc->next_fpm_addr / IRDMA_HMC_DIRECT_BP_SIZE;
+	idx->sd_idx = pble_rsrc->next_fpm_addr / IRDMA_HMC_DIRECT_BP_SIZE;
 	idx->pd_idx = (u32)(pble_rsrc->next_fpm_addr / IRDMA_HMC_PAGED_BP_SIZE);
 	idx->rel_pd_idx = (idx->pd_idx % IRDMA_HMC_PD_CNT_IN_SD);
 }
-- 
2.51.0.534.gc79095c0ca-goog

RE: [PATCH rdma-next] RDMA/irdma: Fix SD index calculation

[Nikolova, Tatyana E]

> -----Original Message-----
> From: Jacob Moroni <jmoroni@google.com>
> Sent: Tuesday, September 23, 2025 2:09 PM
> To: Nikolova, Tatyana E <tatyana.e.nikolova@intel.com>
> Cc: jgg@ziepe.ca; leon@kernel.org; linux-rdma@vger.kernel.org; Jacob Moroni
> <jmoroni@google.com>
> Subject: [PATCH rdma-next] RDMA/irdma: Fix SD index calculation
> 
> In some cases, it is possible for pble_rsrc->next_fpm_addr to be larger than
> u32, so remove the u32 cast to avoid unintentional truncation.
> 
> This fixes the following error that can be observed when registering massive
> memory regions:
> 
> [  447.227494] (NULL ib_device): cqp opcode = 0x1f maj_err_code = 0xffff
> min_err_code = 0x800c [  447.227505] (NULL ib_device): [Update PE SDs Cmd
> Error][op_code=21] status=-5 waiting=1 completion_err=1 maj=0xffff
> min=0x800c
> 
> Fixes: e8c4dbc2fcac ("RDMA/irdma: Add PBLE resource manager")
> Signed-off-by: Jacob Moroni <jmoroni@google.com>
> ---

Acked-by: Tatyana Nikolova <tatyana.e.nikolova@intel.com>

Thank you

Re: [PATCH rdma-next] RDMA/irdma: Fix SD index calculation

[Leon Romanovsky]

On Tue, 23 Sep 2025 19:08:50 +0000, Jacob Moroni wrote:
> In some cases, it is possible for pble_rsrc->next_fpm_addr to be
> larger than u32, so remove the u32 cast to avoid unintentional
> truncation.
> 
> This fixes the following error that can be observed when registering
> massive memory regions:
> 
> [...]

Applied, thanks!

[1/1] RDMA/irdma: Fix SD index calculation
      https://git.kernel.org/rdma/rdma/c/8d158f47f1f33d

Best regards,
-- 
Leon Romanovsky <leon@kernel.org>