Re: [PATCH v4 07/27] hw/arm/smmuv3: Implement get_viommu_cap() callback

[Jonathan Cameron via <qemu-arm@nongnu.org>]

On Wed, 1 Oct 2025 19:36:47 +0200
Eric Auger <eric.auger@redhat.com> wrote:

> Hi Shameer,
> 
> On 9/29/25 3:36 PM, Shameer Kolothum wrote:
> > For accelerated SMMUv3, we need nested parent domain creation. Add the
> > callback support so that VFIO can create a nested parent.
> >
> > In the accelerated SMMUv3 case, the host SMMUv3 is configured in nested
> > mode (S1 + S2), and the guest owns the Stage-1 page table. Therefore, we
> > expose only Stage-1 to the guest to ensure it uses the correct page-table
> > format.
> >
> > Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>
> > Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
> > Signed-off-by: Shameer Kolothum <skolothumtho@nvidia.com>  
> Wonder if you shall keep both. I don't know the usage though but worth
> to check.

I've never found any clear guidance on what to do in this case.
Given cost of a bonus SoB that is valid given the "Nvidia" Shameer
has taken the code from the "Huawei" Shameer and moved it forwards
I'd be tempted to keep it unless anyone feels strongly about it.

Jonathan