From: Jamin Lin via <qemu-arm@nongnu.org>
To: "Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: <jamin_lin@aspeedtech.com>, <troy_lee@aspeedtech.com>
Subject: [PATCH v1 5/5] tests/functional/aarch64/test_aspeed_ast2700: Move eth2 IP check into common function
Date: Fri, 3 Oct 2025 15:21:06 +0800 [thread overview]
Message-ID: <20251003072107.3530642-6-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20251003072107.3530642-1-jamin_lin@aspeedtech.com>
The eth2 IP address check was previously only performed in
test_aarch64_ast2700a1_evb_sdk_vbootrom_v09_08. This patch moves the
check into do_ast2700_pcie_test(), ensuring it is executed consistently
across all AST2700 PCIe test runs. This avoids code duplication.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
tests/functional/aarch64/test_aspeed_ast2700.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/functional/aarch64/test_aspeed_ast2700.py b/tests/functional/aarch64/test_aspeed_ast2700.py
index 0e9f10d991..ef7ed522af 100755
--- a/tests/functional/aarch64/test_aspeed_ast2700.py
+++ b/tests/functional/aarch64/test_aspeed_ast2700.py
@@ -74,6 +74,9 @@ def do_ast2700_pcie_test(self):
'lspci -s 0002:01:00.0',
'0002:01:00.0 Ethernet controller: '
'Intel Corporation 82574L Gigabit Network Connection')
+ exec_command_and_wait_for_pattern(self,
+ 'ip addr show dev eth2',
+ 'inet 10.0.2.15/24')
def start_ast2700_test(self, name):
num_cpu = 4
@@ -153,9 +156,6 @@ def test_aarch64_ast2700a1_evb_sdk_vbootrom_v09_08(self):
self.verify_openbmc_boot_and_login('ast2700-default')
self.do_ast2700_i2c_test()
self.do_ast2700_pcie_test()
- exec_command_and_wait_for_pattern(self,
- 'ip addr show dev eth2',
- 'inet 10.0.2.15/24')
if __name__ == '__main__':
QemuSystemTest.main()
--
2.43.0
WARNING: multiple messages have this Message-ID (diff)
From: Jamin Lin via <qemu-devel@nongnu.org>
To: "Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: <jamin_lin@aspeedtech.com>, <troy_lee@aspeedtech.com>
Subject: [PATCH v1 5/5] tests/functional/aarch64/test_aspeed_ast2700: Move eth2 IP check into common function
Date: Fri, 3 Oct 2025 15:21:06 +0800 [thread overview]
Message-ID: <20251003072107.3530642-6-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20251003072107.3530642-1-jamin_lin@aspeedtech.com>
The eth2 IP address check was previously only performed in
test_aarch64_ast2700a1_evb_sdk_vbootrom_v09_08. This patch moves the
check into do_ast2700_pcie_test(), ensuring it is executed consistently
across all AST2700 PCIe test runs. This avoids code duplication.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
tests/functional/aarch64/test_aspeed_ast2700.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/functional/aarch64/test_aspeed_ast2700.py b/tests/functional/aarch64/test_aspeed_ast2700.py
index 0e9f10d991..ef7ed522af 100755
--- a/tests/functional/aarch64/test_aspeed_ast2700.py
+++ b/tests/functional/aarch64/test_aspeed_ast2700.py
@@ -74,6 +74,9 @@ def do_ast2700_pcie_test(self):
'lspci -s 0002:01:00.0',
'0002:01:00.0 Ethernet controller: '
'Intel Corporation 82574L Gigabit Network Connection')
+ exec_command_and_wait_for_pattern(self,
+ 'ip addr show dev eth2',
+ 'inet 10.0.2.15/24')
def start_ast2700_test(self, name):
num_cpu = 4
@@ -153,9 +156,6 @@ def test_aarch64_ast2700a1_evb_sdk_vbootrom_v09_08(self):
self.verify_openbmc_boot_and_login('ast2700-default')
self.do_ast2700_i2c_test()
self.do_ast2700_pcie_test()
- exec_command_and_wait_for_pattern(self,
- 'ip addr show dev eth2',
- 'inet 10.0.2.15/24')
if __name__ == '__main__':
QemuSystemTest.main()
--
2.43.0
next prev parent reply other threads:[~2025-10-03 7:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 7:21 [PATCH v1 0/5] Update to test ASPEED SDK v09.08 Jamin Lin via
2025-10-03 7:21 ` Jamin Lin via
2025-10-03 7:21 ` [PATCH v1 1/5] tests/functional/arm/test_aspeed_ast1030: Update test ASPEED SDK v03.03 Jamin Lin via
2025-10-03 7:21 ` Jamin Lin via
2025-10-03 7:21 ` [PATCH v1 2/5] tests/functional/arm/test_aspeed_ast2500: Update test ASPEED SDK v09.08 Jamin Lin via
2025-10-03 7:21 ` Jamin Lin via
2025-10-03 7:21 ` [PATCH v1 3/5] tests/functional/arm/test_aspeed_ast2600: " Jamin Lin via
2025-10-03 7:21 ` Jamin Lin via
2025-10-03 7:21 ` [PATCH v1 4/5] tests/functional/aarch64/test_aspeed_ast2700: Update test ASPEED SDK v09.08 for A1 Jamin Lin via
2025-10-03 7:21 ` Jamin Lin via
2025-10-03 7:21 ` Jamin Lin via [this message]
2025-10-03 7:21 ` [PATCH v1 5/5] tests/functional/aarch64/test_aspeed_ast2700: Move eth2 IP check into common function Jamin Lin via
2025-10-03 10:19 ` [SPAM] [PATCH v1 0/5] Update to test ASPEED SDK v09.08 Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251003072107.3530642-6-jamin_lin@aspeedtech.com \
--to=qemu-arm@nongnu.org \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=leetroy@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.