* [PATCH] drm/nouveau: Do not include drm_fb_helper.h
@ 2025-09-30 13:14 Thomas Zimmermann
2025-10-03 11:01 ` Petr Vorel
2025-10-03 11:15 ` Petr Vorel
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Zimmermann @ 2025-09-30 13:14 UTC (permalink / raw)
To: lyude, dakr, jani.nikula; +Cc: dri-devel, nouveau, Thomas Zimmermann
The driver doesn't need anything from <drm/drm_fb_helper.h>. Remove
the include directive.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index e97e39abf3a2..1d4d1bb63326 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
@@ -40,7 +40,6 @@
#include <drm/drm_atomic_helper.h>
#include <drm/drm_edid.h>
#include <drm/drm_eld.h>
-#include <drm/drm_fb_helper.h>
#include <drm/drm_fixed.h>
#include <drm/drm_probe_helper.h>
#include <drm/drm_vblank.h>
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/nouveau: Do not include drm_fb_helper.h
2025-09-30 13:14 [PATCH] drm/nouveau: Do not include drm_fb_helper.h Thomas Zimmermann
@ 2025-10-03 11:01 ` Petr Vorel
2025-10-03 11:15 ` Petr Vorel
1 sibling, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2025-10-03 11:01 UTC (permalink / raw)
To: Thomas Zimmermann; +Cc: lyude, dakr, jani.nikula, dri-devel, nouveau
Hi,
> The driver doesn't need anything from <drm/drm_fb_helper.h>. Remove
> the include directive.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
...
> +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> @@ -40,7 +40,6 @@
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_edid.h>
> #include <drm/drm_eld.h>
> -#include <drm/drm_fb_helper.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/nouveau: Do not include drm_fb_helper.h
2025-09-30 13:14 [PATCH] drm/nouveau: Do not include drm_fb_helper.h Thomas Zimmermann
2025-10-03 11:01 ` Petr Vorel
@ 2025-10-03 11:15 ` Petr Vorel
1 sibling, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2025-10-03 11:15 UTC (permalink / raw)
To: Thomas Zimmermann; +Cc: lyude, dakr, jani.nikula, dri-devel, nouveau
Hi,
> The driver doesn't need anything from <drm/drm_fb_helper.h>. Remove
> the include directive.
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/nouveau/dispnv50/disp.c | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> index e97e39abf3a2..1d4d1bb63326 100644
> --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
> +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> @@ -40,7 +40,6 @@
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_edid.h>
> #include <drm/drm_eld.h>
> -#include <drm/drm_fb_helper.h>
> #include <drm/drm_fixed.h>
> #include <drm/drm_probe_helper.h>
> #include <drm/drm_vblank.h>
it looks to me that at least these 3 aren't needed either:
#include <drm/display/drm_dp_helper.h>
#include <drm/drm_atomic.h>
#include <drm/drm_fixed.h>
But maybe I miss something obvious.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-03 11:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-30 13:14 [PATCH] drm/nouveau: Do not include drm_fb_helper.h Thomas Zimmermann
2025-10-03 11:01 ` Petr Vorel
2025-10-03 11:15 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.