All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: stephen@networkplumber.org, thomas@monjalon.net,
	Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH v3 1/7] net/ice: don't report empty queue xstats
Date: Fri,  3 Oct 2025 12:01:55 +0100	[thread overview]
Message-ID: <20251003110201.1541183-2-bruce.richardson@intel.com> (raw)
In-Reply-To: <20251003110201.1541183-1-bruce.richardson@intel.com>

The ice driver does not fill in the queue statistics in the
rte_eth_stats structure, meaning that the per-queue xstats reported are
meaningless, and always zero. Don't set the device flag
"RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS" so these zero-stats are not
automatically created by the ethdev layer.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/intel/ice/ice_ethdev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/intel/ice/ice_ethdev.c b/drivers/net/intel/ice/ice_ethdev.c
index a9a49cd924..31f1419897 100644
--- a/drivers/net/intel/ice/ice_ethdev.c
+++ b/drivers/net/intel/ice/ice_ethdev.c
@@ -2580,8 +2580,6 @@ ice_dev_init(struct rte_eth_dev *dev)
 		return 0;
 	}
 
-	dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;
-
 	ice_set_default_ptype_table(dev);
 	pci_dev = RTE_DEV_TO_PCI(dev->device);
 	intr_handle = pci_dev->intr_handle;
-- 
2.48.1


  reply	other threads:[~2025-10-03 11:02 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-23 14:12 [RFC PATCH 0/6] remove deprecated queue stats Bruce Richardson
2025-09-23 14:12 ` [RFC PATCH 1/6] net/ice: don't report empty queue xstats Bruce Richardson
2025-09-23 14:12 ` [RFC PATCH 2/6] net/ipn3ke: drop unsupported per-queue xstats Bruce Richardson
2025-09-24  1:38   ` Xu, Rosen
2025-09-23 14:12 ` [RFC PATCH 3/6] ethdev: remove queue stats from ethdev stats structure Bruce Richardson
2025-09-24  7:37   ` Morten Brørup
2025-09-24  7:42     ` Bruce Richardson
2025-09-23 14:12 ` [RFC PATCH 4/6] drivers/net: update to remove queue stats from eth stats Bruce Richardson
2025-09-24  1:39   ` Xu, Rosen
2025-09-23 14:12 ` [RFC PATCH 5/6] app: " Bruce Richardson
2025-09-23 14:12 ` [RFC PATCH 6/6] doc: update docs for ethdev changes Bruce Richardson
2025-09-23 15:04 ` [RFC PATCH 0/6] remove deprecated queue stats Stephen Hemminger
2025-09-23 15:33   ` Bruce Richardson
2025-09-29 15:00 ` [PATCH v2 " Bruce Richardson
2025-09-29 15:00   ` [PATCH v2 1/6] net/ice: don't report empty queue xstats Bruce Richardson
2025-09-29 15:00   ` [PATCH v2 2/6] net/ipn3ke: drop unsupported per-queue xstats Bruce Richardson
2025-09-29 15:00   ` [PATCH v2 3/6] ethdev: remove queue stats from ethdev stats structure Bruce Richardson
2025-09-29 15:00   ` [PATCH v2 4/6] drivers/net: update to remove queue stats from eth stats Bruce Richardson
2025-09-29 15:00   ` [PATCH v2 5/6] app: " Bruce Richardson
2025-09-29 15:00   ` [PATCH v2 6/6] doc: update docs for ethdev changes Bruce Richardson
2025-09-29 16:41   ` [PATCH v2 0/6] remove deprecated queue stats Stephen Hemminger
2025-09-29 16:50     ` Bruce Richardson
2025-10-03 11:04     ` Bruce Richardson
2025-09-29 22:57   ` Stephen Hemminger
2025-10-03 11:01 ` [PATCH v3 0/7] " Bruce Richardson
2025-10-03 11:01   ` Bruce Richardson [this message]
2025-10-03 11:01   ` [PATCH v3 2/7] net/ipn3ke: drop unsupported per-queue xstats Bruce Richardson
2025-10-03 11:01   ` [PATCH v3 3/7] ethdev: remove queue stats from ethdev stats structure Bruce Richardson
2025-10-15 22:14     ` Stephen Hemminger
2025-10-21 16:53     ` Stephen Hemminger
2025-10-03 11:01   ` [PATCH v3 4/7] drivers/net: update to remove queue stats from eth stats Bruce Richardson
2025-10-10  5:31     ` Hemant Agrawal
2025-10-03 11:01   ` [PATCH v3 5/7] app: " Bruce Richardson
2025-10-03 11:02   ` [PATCH v3 6/7] doc: update docs for ethdev changes Bruce Richardson
2025-10-03 11:02   ` [PATCH v3 7/7] ethdev: deprecate queue stats mapping functions Bruce Richardson
2025-10-15 22:16     ` Stephen Hemminger
2025-10-15 22:17   ` [PATCH v3 0/7] remove deprecated queue stats Stephen Hemminger
2025-10-16  8:12     ` Bruce Richardson
2025-10-22 16:32   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251003110201.1541183-2-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.