From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net
Subject: Re: [PATCH v3 3/7] ethdev: remove queue stats from ethdev stats structure
Date: Tue, 21 Oct 2025 09:53:16 -0700 [thread overview]
Message-ID: <20251021095316.4c459aa2@phoenix.lan> (raw)
In-Reply-To: <20251003110201.1541183-4-bruce.richardson@intel.com>
On Fri, 3 Oct 2025 12:01:57 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:
> The queue stats part of the rte_eth_stats structure has been deprecated
> for many years now, since 2020 [1]. Therefore we look to remove these
> fields from the stats structure.
>
> Unfortunately, the flag introduced by the deprecation,
> "RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS", means that for drivers using it we
> still have to return queue stats from the driver stats_get function.
> This means that we need a new parameter for those stats as part of the
> stats_get interface. The autofill flag is set for 35 drivers, which
> means that if we didn't do so, users of those 35 drivers would lose all
> ability to get per-queue stats.
>
> [1] Commit a72cb3e7656a ("doc: announce queue stats moving to xstats")
> https://github.com/DPDK/dpdk/commit/a72cb3e
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
This patch needs to be merged with next patch because each commit
must build cleanly. Committing something that doesn't build will break
future bisection.
next prev parent reply other threads:[~2025-10-21 16:53 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 14:12 [RFC PATCH 0/6] remove deprecated queue stats Bruce Richardson
2025-09-23 14:12 ` [RFC PATCH 1/6] net/ice: don't report empty queue xstats Bruce Richardson
2025-09-23 14:12 ` [RFC PATCH 2/6] net/ipn3ke: drop unsupported per-queue xstats Bruce Richardson
2025-09-24 1:38 ` Xu, Rosen
2025-09-23 14:12 ` [RFC PATCH 3/6] ethdev: remove queue stats from ethdev stats structure Bruce Richardson
2025-09-24 7:37 ` Morten Brørup
2025-09-24 7:42 ` Bruce Richardson
2025-09-23 14:12 ` [RFC PATCH 4/6] drivers/net: update to remove queue stats from eth stats Bruce Richardson
2025-09-24 1:39 ` Xu, Rosen
2025-09-23 14:12 ` [RFC PATCH 5/6] app: " Bruce Richardson
2025-09-23 14:12 ` [RFC PATCH 6/6] doc: update docs for ethdev changes Bruce Richardson
2025-09-23 15:04 ` [RFC PATCH 0/6] remove deprecated queue stats Stephen Hemminger
2025-09-23 15:33 ` Bruce Richardson
2025-09-29 15:00 ` [PATCH v2 " Bruce Richardson
2025-09-29 15:00 ` [PATCH v2 1/6] net/ice: don't report empty queue xstats Bruce Richardson
2025-09-29 15:00 ` [PATCH v2 2/6] net/ipn3ke: drop unsupported per-queue xstats Bruce Richardson
2025-09-29 15:00 ` [PATCH v2 3/6] ethdev: remove queue stats from ethdev stats structure Bruce Richardson
2025-09-29 15:00 ` [PATCH v2 4/6] drivers/net: update to remove queue stats from eth stats Bruce Richardson
2025-09-29 15:00 ` [PATCH v2 5/6] app: " Bruce Richardson
2025-09-29 15:00 ` [PATCH v2 6/6] doc: update docs for ethdev changes Bruce Richardson
2025-09-29 16:41 ` [PATCH v2 0/6] remove deprecated queue stats Stephen Hemminger
2025-09-29 16:50 ` Bruce Richardson
2025-10-03 11:04 ` Bruce Richardson
2025-09-29 22:57 ` Stephen Hemminger
2025-10-03 11:01 ` [PATCH v3 0/7] " Bruce Richardson
2025-10-03 11:01 ` [PATCH v3 1/7] net/ice: don't report empty queue xstats Bruce Richardson
2025-10-03 11:01 ` [PATCH v3 2/7] net/ipn3ke: drop unsupported per-queue xstats Bruce Richardson
2025-10-03 11:01 ` [PATCH v3 3/7] ethdev: remove queue stats from ethdev stats structure Bruce Richardson
2025-10-15 22:14 ` Stephen Hemminger
2025-10-21 16:53 ` Stephen Hemminger [this message]
2025-10-03 11:01 ` [PATCH v3 4/7] drivers/net: update to remove queue stats from eth stats Bruce Richardson
2025-10-10 5:31 ` Hemant Agrawal
2025-10-03 11:01 ` [PATCH v3 5/7] app: " Bruce Richardson
2025-10-03 11:02 ` [PATCH v3 6/7] doc: update docs for ethdev changes Bruce Richardson
2025-10-03 11:02 ` [PATCH v3 7/7] ethdev: deprecate queue stats mapping functions Bruce Richardson
2025-10-15 22:16 ` Stephen Hemminger
2025-10-15 22:17 ` [PATCH v3 0/7] remove deprecated queue stats Stephen Hemminger
2025-10-16 8:12 ` Bruce Richardson
2025-10-22 16:32 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021095316.4c459aa2@phoenix.lan \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.