From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Enzo Matsumiya <ematsumiya@suse.de>,
linux-cifs@vger.kernel.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, smfrench@gmail.com,
pc@manguebit.com, ronniesahlberg@gmail.com,
sprasad@microsoft.com, tom@talpey.com, bharathsm@microsoft.com,
henrique.carvalho@suse.com
Subject: Re: [PATCH 13/20] smb: client: actually use cached dirs on readdir
Date: Fri, 3 Oct 2025 20:26:49 +0300 [thread overview]
Message-ID: <202510032035.eEAqpgDl-lkp@intel.com> (raw)
In-Reply-To: <20250929132805.220558-14-ematsumiya@suse.de>
Hi Enzo,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Enzo-Matsumiya/smb-client-remove-cfids_invalidation_worker/20250929-213155
base: v6.17
patch link: https://lore.kernel.org/r/20250929132805.220558-14-ematsumiya%40suse.de
patch subject: [PATCH 13/20] smb: client: actually use cached dirs on readdir
config: i386-randconfig-141-20251003 (https://download.01.org/0day-ci/archive/20251003/202510032035.eEAqpgDl-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202510032035.eEAqpgDl-lkp@intel.com/
smatch warnings:
fs/smb/client/readdir.c:1119 cifs_readdir() error: uninitialized symbol 'tcon'.
vim +/tcon +1119 fs/smb/client/readdir.c
be4ccdcc2575ae fs/cifs/readdir.c Al Viro 2013-05-22 1041 int cifs_readdir(struct file *file, struct dir_context *ctx)
^1da177e4c3f41 fs/cifs/readdir.c Linus Torvalds 2005-04-16 1042 {
^1da177e4c3f41 fs/cifs/readdir.c Linus Torvalds 2005-04-16 1043 int rc = 0;
6d5786a34d98bf fs/cifs/readdir.c Pavel Shilovsky 2012-06-20 1044 unsigned int xid;
6d5786a34d98bf fs/cifs/readdir.c Pavel Shilovsky 2012-06-20 1045 int i;
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1046 struct tcon_link *tlink = NULL;
92fc65a74a2be1 fs/cifs/readdir.c Pavel Shilovsky 2012-09-18 1047 struct cifs_tcon *tcon;
ec217637e7f16d fs/smb/client/readdir.c Enzo Matsumiya 2025-09-29 1048 struct cifsFileInfo *cifsFile = NULL;
^1da177e4c3f41 fs/cifs/readdir.c Linus Torvalds 2005-04-16 1049 char *current_entry;
^1da177e4c3f41 fs/cifs/readdir.c Linus Torvalds 2005-04-16 1050 int num_to_fill = 0;
^1da177e4c3f41 fs/cifs/readdir.c Linus Torvalds 2005-04-16 1051 char *tmp_buf = NULL;
^1da177e4c3f41 fs/cifs/readdir.c Linus Torvalds 2005-04-16 1052 char *end_of_smb;
18295796a30cad fs/cifs/readdir.c Jeff Layton 2009-04-30 1053 unsigned int max_len;
f6a9bc336b600e fs/cifs/readdir.c Al Viro 2021-03-05 1054 const char *full_path;
f6a9bc336b600e fs/cifs/readdir.c Al Viro 2021-03-05 1055 void *page = alloc_dentry_path();
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1056 struct cached_fid *cfid = NULL;
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1057 struct cifs_sb_info *cifs_sb = CIFS_FILE_SB(file);
^1da177e4c3f41 fs/cifs/readdir.c Linus Torvalds 2005-04-16 1058
6d5786a34d98bf fs/cifs/readdir.c Pavel Shilovsky 2012-06-20 1059 xid = get_xid();
^1da177e4c3f41 fs/cifs/readdir.c Linus Torvalds 2005-04-16 1060
f6a9bc336b600e fs/cifs/readdir.c Al Viro 2021-03-05 1061 full_path = build_path_from_dentry(file_dentry(file), page);
f6a9bc336b600e fs/cifs/readdir.c Al Viro 2021-03-05 1062 if (IS_ERR(full_path)) {
f6a9bc336b600e fs/cifs/readdir.c Al Viro 2021-03-05 1063 rc = PTR_ERR(full_path);
d1542cf6165e52 fs/cifs/readdir.c Ronnie Sahlberg 2020-10-05 1064 goto rddir2_exit;
d1542cf6165e52 fs/cifs/readdir.c Ronnie Sahlberg 2020-10-05 1065 }
d1542cf6165e52 fs/cifs/readdir.c Ronnie Sahlberg 2020-10-05 1066
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1067 if (file->private_data == NULL) {
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1068 tlink = cifs_sb_tlink(cifs_sb);
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1069 if (IS_ERR(tlink))
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1070 goto cache_not_found;
tcon is not initialized yet. private_data is NULL.
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1071 tcon = tlink_tcon(tlink);
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1072 } else {
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1073 cifsFile = file->private_data;
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1074 tcon = tlink_tcon(cifsFile->tlink);
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1075 }
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1076
7d24f0ff5dad1f fs/smb/client/readdir.c Enzo Matsumiya 2025-09-29 1077 rc = open_cached_dir(xid, tcon, full_path, cifs_sb, &cfid);
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1078 cifs_put_tlink(tlink);
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1079 if (rc)
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1080 goto cache_not_found;
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1081
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1082 mutex_lock(&cfid->dirents.de_mutex);
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1083 /*
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1084 * If this was reading from the start of the directory
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1085 * we need to initialize scanning and storing the
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1086 * directory content.
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1087 */
72dd7961a4bb4f fs/smb/client/readdir.c Bharath SM 2025-06-11 1088 if (ctx->pos == 0 && cfid->dirents.file == NULL) {
72dd7961a4bb4f fs/smb/client/readdir.c Bharath SM 2025-06-11 1089 cfid->dirents.file = file;
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1090 cfid->dirents.pos = 2;
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1091 }
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1092 /*
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1093 * If we already have the entire directory cached then
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1094 * we can just serve the cache.
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1095 */
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1096 if (cfid->dirents.is_valid) {
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1097 if (!dir_emit_dots(file, ctx)) {
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1098 mutex_unlock(&cfid->dirents.de_mutex);
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1099 goto rddir2_exit;
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1100 }
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1101 emit_cached_dirents(&cfid->dirents, ctx);
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1102 mutex_unlock(&cfid->dirents.de_mutex);
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1103 goto rddir2_exit;
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1104 }
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1105 mutex_unlock(&cfid->dirents.de_mutex);
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1106
ec217637e7f16d fs/smb/client/readdir.c Enzo Matsumiya 2025-09-29 1107 /* keep our cfid ref, but check if still valid after network calls */
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1108 cache_not_found:
6221ddd0f5e2dd fs/cifs/readdir.c Suresh Jayaraman 2010-10-01 1109 /*
6221ddd0f5e2dd fs/cifs/readdir.c Suresh Jayaraman 2010-10-01 1110 * Ensure FindFirst doesn't fail before doing filldir() for '.' and
6221ddd0f5e2dd fs/cifs/readdir.c Suresh Jayaraman 2010-10-01 1111 * '..'. Otherwise we won't be able to notify VFS in case of failure.
6221ddd0f5e2dd fs/cifs/readdir.c Suresh Jayaraman 2010-10-01 1112 */
6221ddd0f5e2dd fs/cifs/readdir.c Suresh Jayaraman 2010-10-01 1113 if (file->private_data == NULL) {
ec217637e7f16d fs/smb/client/readdir.c Enzo Matsumiya 2025-09-29 1114 rc = initiate_cifs_search(xid, file, full_path, cfid);
f96637be081141 fs/cifs/readdir.c Joe Perches 2013-05-04 1115 cifs_dbg(FYI, "initiate cifs search rc %d\n", rc);
6221ddd0f5e2dd fs/cifs/readdir.c Suresh Jayaraman 2010-10-01 1116 if (rc)
6221ddd0f5e2dd fs/cifs/readdir.c Suresh Jayaraman 2010-10-01 1117 goto rddir2_exit;
ec217637e7f16d fs/smb/client/readdir.c Enzo Matsumiya 2025-09-29 1118
ec217637e7f16d fs/smb/client/readdir.c Enzo Matsumiya 2025-09-29 @1119 if (tcon->status != TID_GOOD || (cfid && !cfid_is_valid(cfid))) {
^^^^^^^^^^^^
Uninitialized?
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH 13/20] smb: client: actually use cached dirs on readdir
Date: Fri, 3 Oct 2025 20:44:28 +0800 [thread overview]
Message-ID: <202510032035.eEAqpgDl-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250929132805.220558-14-ematsumiya@suse.de>
References: <20250929132805.220558-14-ematsumiya@suse.de>
TO: Enzo Matsumiya <ematsumiya@suse.de>
TO: linux-cifs@vger.kernel.org
CC: smfrench@gmail.com
CC: pc@manguebit.com
CC: ronniesahlberg@gmail.com
CC: sprasad@microsoft.com
CC: tom@talpey.com
CC: bharathsm@microsoft.com
CC: henrique.carvalho@suse.com
Hi Enzo,
kernel test robot noticed the following build warnings:
[auto build test WARNING on v6.17]
[also build test WARNING on linus/master]
[cannot apply to cifs/for-next next-20251002]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Enzo-Matsumiya/smb-client-remove-cfids_invalidation_worker/20250929-213155
base: v6.17
patch link: https://lore.kernel.org/r/20250929132805.220558-14-ematsumiya%40suse.de
patch subject: [PATCH 13/20] smb: client: actually use cached dirs on readdir
:::::: branch date: 4 days ago
:::::: commit date: 4 days ago
config: i386-randconfig-141-20251003 (https://download.01.org/0day-ci/archive/20251003/202510032035.eEAqpgDl-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202510032035.eEAqpgDl-lkp@intel.com/
smatch warnings:
fs/smb/client/readdir.c:1119 cifs_readdir() error: uninitialized symbol 'tcon'.
vim +/tcon +1119 fs/smb/client/readdir.c
^1da177e4c3f41 fs/cifs/readdir.c Linus Torvalds 2005-04-16 1040
be4ccdcc2575ae fs/cifs/readdir.c Al Viro 2013-05-22 1041 int cifs_readdir(struct file *file, struct dir_context *ctx)
^1da177e4c3f41 fs/cifs/readdir.c Linus Torvalds 2005-04-16 1042 {
^1da177e4c3f41 fs/cifs/readdir.c Linus Torvalds 2005-04-16 1043 int rc = 0;
6d5786a34d98bf fs/cifs/readdir.c Pavel Shilovsky 2012-06-20 1044 unsigned int xid;
6d5786a34d98bf fs/cifs/readdir.c Pavel Shilovsky 2012-06-20 1045 int i;
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1046 struct tcon_link *tlink = NULL;
92fc65a74a2be1 fs/cifs/readdir.c Pavel Shilovsky 2012-09-18 1047 struct cifs_tcon *tcon;
ec217637e7f16d fs/smb/client/readdir.c Enzo Matsumiya 2025-09-29 1048 struct cifsFileInfo *cifsFile = NULL;
^1da177e4c3f41 fs/cifs/readdir.c Linus Torvalds 2005-04-16 1049 char *current_entry;
^1da177e4c3f41 fs/cifs/readdir.c Linus Torvalds 2005-04-16 1050 int num_to_fill = 0;
^1da177e4c3f41 fs/cifs/readdir.c Linus Torvalds 2005-04-16 1051 char *tmp_buf = NULL;
^1da177e4c3f41 fs/cifs/readdir.c Linus Torvalds 2005-04-16 1052 char *end_of_smb;
18295796a30cad fs/cifs/readdir.c Jeff Layton 2009-04-30 1053 unsigned int max_len;
f6a9bc336b600e fs/cifs/readdir.c Al Viro 2021-03-05 1054 const char *full_path;
f6a9bc336b600e fs/cifs/readdir.c Al Viro 2021-03-05 1055 void *page = alloc_dentry_path();
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1056 struct cached_fid *cfid = NULL;
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1057 struct cifs_sb_info *cifs_sb = CIFS_FILE_SB(file);
^1da177e4c3f41 fs/cifs/readdir.c Linus Torvalds 2005-04-16 1058
6d5786a34d98bf fs/cifs/readdir.c Pavel Shilovsky 2012-06-20 1059 xid = get_xid();
^1da177e4c3f41 fs/cifs/readdir.c Linus Torvalds 2005-04-16 1060
f6a9bc336b600e fs/cifs/readdir.c Al Viro 2021-03-05 1061 full_path = build_path_from_dentry(file_dentry(file), page);
f6a9bc336b600e fs/cifs/readdir.c Al Viro 2021-03-05 1062 if (IS_ERR(full_path)) {
f6a9bc336b600e fs/cifs/readdir.c Al Viro 2021-03-05 1063 rc = PTR_ERR(full_path);
d1542cf6165e52 fs/cifs/readdir.c Ronnie Sahlberg 2020-10-05 1064 goto rddir2_exit;
d1542cf6165e52 fs/cifs/readdir.c Ronnie Sahlberg 2020-10-05 1065 }
d1542cf6165e52 fs/cifs/readdir.c Ronnie Sahlberg 2020-10-05 1066
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1067 if (file->private_data == NULL) {
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1068 tlink = cifs_sb_tlink(cifs_sb);
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1069 if (IS_ERR(tlink))
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1070 goto cache_not_found;
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1071 tcon = tlink_tcon(tlink);
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1072 } else {
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1073 cifsFile = file->private_data;
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1074 tcon = tlink_tcon(cifsFile->tlink);
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1075 }
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1076
7d24f0ff5dad1f fs/smb/client/readdir.c Enzo Matsumiya 2025-09-29 1077 rc = open_cached_dir(xid, tcon, full_path, cifs_sb, &cfid);
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1078 cifs_put_tlink(tlink);
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1079 if (rc)
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1080 goto cache_not_found;
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1081
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1082 mutex_lock(&cfid->dirents.de_mutex);
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1083 /*
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1084 * If this was reading from the start of the directory
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1085 * we need to initialize scanning and storing the
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1086 * directory content.
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1087 */
72dd7961a4bb4f fs/smb/client/readdir.c Bharath SM 2025-06-11 1088 if (ctx->pos == 0 && cfid->dirents.file == NULL) {
72dd7961a4bb4f fs/smb/client/readdir.c Bharath SM 2025-06-11 1089 cfid->dirents.file = file;
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1090 cfid->dirents.pos = 2;
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1091 }
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1092 /*
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1093 * If we already have the entire directory cached then
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1094 * we can just serve the cache.
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1095 */
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1096 if (cfid->dirents.is_valid) {
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1097 if (!dir_emit_dots(file, ctx)) {
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1098 mutex_unlock(&cfid->dirents.de_mutex);
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1099 goto rddir2_exit;
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1100 }
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1101 emit_cached_dirents(&cfid->dirents, ctx);
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1102 mutex_unlock(&cfid->dirents.de_mutex);
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1103 goto rddir2_exit;
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1104 }
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1105 mutex_unlock(&cfid->dirents.de_mutex);
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1106
ec217637e7f16d fs/smb/client/readdir.c Enzo Matsumiya 2025-09-29 1107 /* keep our cfid ref, but check if still valid after network calls */
d87c48ce4d8951 fs/cifs/readdir.c Ronnie Sahlberg 2022-05-10 1108 cache_not_found:
6221ddd0f5e2dd fs/cifs/readdir.c Suresh Jayaraman 2010-10-01 1109 /*
6221ddd0f5e2dd fs/cifs/readdir.c Suresh Jayaraman 2010-10-01 1110 * Ensure FindFirst doesn't fail before doing filldir() for '.' and
6221ddd0f5e2dd fs/cifs/readdir.c Suresh Jayaraman 2010-10-01 1111 * '..'. Otherwise we won't be able to notify VFS in case of failure.
6221ddd0f5e2dd fs/cifs/readdir.c Suresh Jayaraman 2010-10-01 1112 */
6221ddd0f5e2dd fs/cifs/readdir.c Suresh Jayaraman 2010-10-01 1113 if (file->private_data == NULL) {
ec217637e7f16d fs/smb/client/readdir.c Enzo Matsumiya 2025-09-29 1114 rc = initiate_cifs_search(xid, file, full_path, cfid);
f96637be081141 fs/cifs/readdir.c Joe Perches 2013-05-04 1115 cifs_dbg(FYI, "initiate cifs search rc %d\n", rc);
6221ddd0f5e2dd fs/cifs/readdir.c Suresh Jayaraman 2010-10-01 1116 if (rc)
6221ddd0f5e2dd fs/cifs/readdir.c Suresh Jayaraman 2010-10-01 1117 goto rddir2_exit;
ec217637e7f16d fs/smb/client/readdir.c Enzo Matsumiya 2025-09-29 1118
ec217637e7f16d fs/smb/client/readdir.c Enzo Matsumiya 2025-09-29 @1119 if (tcon->status != TID_GOOD || (cfid && !cfid_is_valid(cfid))) {
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next parent reply other threads:[~2025-10-03 17:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 12:44 kernel test robot [this message]
2025-10-03 17:26 ` [PATCH 13/20] smb: client: actually use cached dirs on readdir Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2025-10-03 17:04 [PATCH 16/20] smb: client: add is_dir argument to query_path_info kernel test robot
2025-10-03 17:20 ` Dan Carpenter
2025-09-29 13:27 [PATCH 00/20] smb: client: cached dir fixes and improvements Enzo Matsumiya
2025-09-29 13:27 ` [PATCH 01/20] smb: client: remove cfids_invalidation_worker Enzo Matsumiya
2025-09-29 13:27 ` [PATCH 02/20] smb: client: remove cached_dir_offload_close/close_work Enzo Matsumiya
2025-09-29 13:27 ` [PATCH 03/20] smb: client: remove cached_dir_put_work/put_work Enzo Matsumiya
2025-09-29 13:27 ` [PATCH 04/20] smb: client: remove cached_fids->dying list Enzo Matsumiya
2025-09-29 13:27 ` [PATCH 05/20] smb: client: remove cached_fid->on_list Enzo Matsumiya
2025-09-29 13:27 ` [PATCH 06/20] smb: client: merge {close,invalidate}_all_cached_dirs() Enzo Matsumiya
2025-09-29 13:27 ` [PATCH 07/20] smb: client: merge free_cached_dir in release callback Enzo Matsumiya
2025-09-29 13:27 ` [PATCH 08/20] smb: client: split find_or_create_cached_dir() Enzo Matsumiya
2025-09-29 13:27 ` [PATCH 09/20] smb: client: enhance cached dir lookups Enzo Matsumiya
2025-09-29 13:27 ` [PATCH 10/20] smb: client: refactor dropping cached dirs Enzo Matsumiya
2025-09-29 13:27 ` [PATCH 11/20] smb: client: simplify cached_fid state checking Enzo Matsumiya
2025-09-29 13:27 ` [PATCH 12/20] smb: client: prevent lease breaks of cached parents when opening children Enzo Matsumiya
2025-09-29 14:23 ` Steve French
2025-09-29 17:17 ` Enzo Matsumiya
2025-09-29 13:27 ` [PATCH 13/20] smb: client: actually use cached dirs on readdir Enzo Matsumiya
2025-09-29 13:27 ` [PATCH 14/20] smb: client: wait for concurrent caching of dirents in cifs_readdir() Enzo Matsumiya
2025-09-29 13:28 ` [PATCH 15/20] smb: client: remove cached_dirent->fattr Enzo Matsumiya
2025-09-29 13:28 ` [PATCH 16/20] smb: client: add is_dir argument to query_path_info Enzo Matsumiya
2025-09-29 13:28 ` [PATCH 17/20] smb: client: use cached dir on queryfs/smb2_compound_op Enzo Matsumiya
2025-09-29 14:26 ` Steve French
2025-09-29 13:28 ` [PATCH 18/20] smb: client: fix dentry revalidation of cached root Enzo Matsumiya
2025-09-29 13:28 ` [PATCH 19/20] smb: client: rework cached dirs synchronization Enzo Matsumiya
2025-09-30 19:02 ` kernel test robot
2025-09-29 13:28 ` [PATCH 20/20] smb: client: cleanup open_cached_dir() Enzo Matsumiya
2025-09-29 14:05 ` [PATCH 00/20] smb: client: cached dir fixes and improvements Steve French
2025-09-29 14:44 ` Enzo Matsumiya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202510032035.eEAqpgDl-lkp@intel.com \
--to=dan.carpenter@linaro.org \
--cc=bharathsm@microsoft.com \
--cc=ematsumiya@suse.de \
--cc=henrique.carvalho@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=pc@manguebit.com \
--cc=ronniesahlberg@gmail.com \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.