From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: Eddie James <eajames@linux.ibm.com>
Cc: <linux-hwmon@vger.kernel.org>, <linux-iio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-aspeed@lists.ozlabs.org>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<andrew@codeconstruct.com.au>, <joel@jms.id.au>,
<linux@roeck-us.net>, <chanh@os.amperecomputing.com>,
<jic23@kernel.org>, <dlechner@baylibre.com>, <nuno.sa@analog.com>,
<andy@kernel.org>
Subject: Re: [PATCH v7 RESEND 3/7] dt-bindings: iio: Add Infineon DPS310 sensor documentation
Date: Tue, 7 Oct 2025 16:48:48 +0100 [thread overview]
Message-ID: <20251007164848.00004d96@huawei.com> (raw)
In-Reply-To: <8ab87732-71e1-4101-9aed-14f68c27fea1@linux.ibm.com>
On Mon, 6 Oct 2025 08:44:55 -0500
Eddie James <eajames@linux.ibm.com> wrote:
> On 10/3/25 9:01 AM, Jonathan Cameron wrote:
> > On Wed, 1 Oct 2025 09:44:37 -0500
> > Eddie James <eajames@linux.ibm.com> wrote:
> >
> >> The DPS310 is a barometric pressure and temperature sensor with
> >> an I2C interface. Remove it from trivial-devices.yaml and add its
> >> own documentation.
> > Hi Eddie,
> >
> > Why? I guess you need the #io-channel-cells which trivial devices
> > doesn't allow because you have a consumer driver?
>
>
> Correct.
>
>
> >
> > Obviously the binding patch shouldn't mention that, but it could call
> > out that there can be such consumers.
>
>
> OK, I can add that.
>
>
> >
> > I'd also expect to see some supplies even if the driver doesn't yet
> > explicitly handle them.
>
>
> You mean in the example section? Sure. I'll send a patch separately
> since the rest is merged
Supplies need listing as actual properties (+ in the example)
From a binding point of view they are 'required' if the power needs
to be turned on for the chip to work. On actual DT files they might
not be there if a fixed supply is in use and someone didn't other providing
it. In those cases the regulator code provides a fake regulator to make
everything work.
>
>
> Thanks,
>
> Eddie
>
>
> >
> > Jonathan
> >
> >> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> >> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> >> ---
> >> .../iio/pressure/infineon,dps310.yaml | 44 +++++++++++++++++++
> >> .../devicetree/bindings/trivial-devices.yaml | 2 -
> >> MAINTAINERS | 1 +
> >> 3 files changed, 45 insertions(+), 2 deletions(-)
> >> create mode 100644 Documentation/devicetree/bindings/iio/pressure/infineon,dps310.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/iio/pressure/infineon,dps310.yaml b/Documentation/devicetree/bindings/iio/pressure/infineon,dps310.yaml
> >> new file mode 100644
> >> index 0000000000000..7c0782e2a821b
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/iio/pressure/infineon,dps310.yaml
> >> @@ -0,0 +1,44 @@
> >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/iio/pressure/infineon,dps310.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Infineon DPS310 barometric pressure and temperature sensor
> >> +
> >> +maintainers:
> >> + - Eddie James <eajames@linux.ibm.com>
> >> +
> >> +description:
> >> + The DPS310 is a barometric pressure and temperature sensor with an I2C
> >> + interface.
> >> +
> >> +properties:
> >> + compatible:
> >> + enum:
> >> + - infineon,dps310
> >> +
> >> + reg:
> >> + maxItems: 1
> >> +
> >> + "#io-channel-cells":
> >> + const: 0
> >> +
> >> +required:
> >> + - compatible
> >> + - reg
> >> +
> >> +additionalProperties: false
> >> +
> >> +examples:
> >> + - |
> >> + i2c {
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> +
> >> + pressure-sensor@76 {
> >> + compatible = "infineon,dps310";
> >> + reg = <0x76>;
> >> + #io-channel-cells = <0>;
> >> + };
> >> + };
> >> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> >> index 7609acaa752d5..a72b7fabc7034 100644
> >> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> >> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> >> @@ -127,8 +127,6 @@ properties:
> >> - ibm,cffps2
> >> # IBM On-Chip Controller hwmon device
> >> - ibm,p8-occ-hwmon
> >> - # Infineon barometric pressure and temperature sensor
> >> - - infineon,dps310
> >> # Infineon IR36021 digital POL buck controller
> >> - infineon,ir36021
> >> # Infineon IRPS5401 Voltage Regulator (PMIC)
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index 0c8281ea4cc64..92b9854a0e07d 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -12191,6 +12191,7 @@ INFINEON DPS310 Driver
> >> M: Eddie James <eajames@linux.ibm.com>
> >> L: linux-iio@vger.kernel.org
> >> S: Maintained
> >> +F: Documentation/devicetree/bindings/iio/pressure/infineon,dps310.yaml
> >> F: drivers/iio/pressure/dps310.c
> >>
> >> INFINEON PEB2466 ASoC CODEC
> >
next prev parent reply other threads:[~2025-10-07 15:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 14:44 [PATCH v7 RESEND 0/7] ARM: dts: aspeed: Add Balcones system Eddie James
2025-10-01 14:44 ` [PATCH v7 RESEND 1/7] dt-bindings: arm: aspeed: add IBM Balcones board Eddie James
2025-10-01 14:44 ` [PATCH v7 RESEND 2/7] dt-bindings: arm: aspeed: add IBM Bonnell board Eddie James
2025-10-01 14:44 ` [PATCH v7 RESEND 3/7] dt-bindings: iio: Add Infineon DPS310 sensor documentation Eddie James
2025-10-03 14:01 ` Jonathan Cameron
2025-10-06 13:44 ` Eddie James
2025-10-07 15:48 ` Jonathan Cameron [this message]
2025-10-01 14:44 ` [PATCH v7 RESEND 4/7] dt-bindings: hwmon: Move max31785 compatibles to max31790 document Eddie James
2025-10-01 14:56 ` Guenter Roeck
2025-10-02 21:37 ` Guenter Roeck
2025-10-01 14:44 ` [PATCH v7 RESEND 5/7] dt-bindings: hwmon: max31790: Use addressed fan nodes Eddie James
2025-10-02 21:38 ` Guenter Roeck
2025-10-01 14:44 ` [PATCH v7 RESEND 6/7] ARM: dts: aspeed: Add Balcones system Eddie James
2025-10-01 14:44 ` [PATCH v7 RESEND 7/7] ARM: dts: aspeed: Fix max31785 fan properties Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251007164848.00004d96@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=andrew@codeconstruct.com.au \
--cc=andy@kernel.org \
--cc=chanh@os.amperecomputing.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=eajames@linux.ibm.com \
--cc=jic23@kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.