[PATCH] ptp: netc: Add dependency on NXP_ENETC4

[PATCH] ptp: netc: Add dependency on NXP_ENETC4

[Peter Robinson]

The NETC V4 Timer PTP IP works with the associated NIC
so depend on it, plus compile test, and default it on if
the NIC is enabled similar to the other PTP modules.

Fixes: 87a201d59963e ("ptp: netc: add NETC V4 Timer PTP driver support")
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 drivers/ptp/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
index 5f8ea34d11d6d..a5542751216d6 100644
--- a/drivers/ptp/Kconfig
+++ b/drivers/ptp/Kconfig
@@ -255,6 +255,8 @@ config PTP_S390
 
 config PTP_NETC_V4_TIMER
 	tristate "NXP NETC V4 Timer PTP Driver"
+	depends on NXP_ENETC4 || COMPILE_TEST
+	default y if NXP_ENETC4
 	depends on PTP_1588_CLOCK
 	depends on PCI_MSI
 	help
-- 
2.51.0

Re: [PATCH] ptp: netc: Add dependency on NXP_ENETC4

[Vadim Fedorenko]

On 05/10/2025 21:49, Peter Robinson wrote:
> The NETC V4 Timer PTP IP works with the associated NIC
> so depend on it, plus compile test, and default it on if
> the NIC is enabled similar to the other PTP modules.
> 
> Fixes: 87a201d59963e ("ptp: netc: add NETC V4 Timer PTP driver support")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>   drivers/ptp/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
> index 5f8ea34d11d6d..a5542751216d6 100644
> --- a/drivers/ptp/Kconfig
> +++ b/drivers/ptp/Kconfig
> @@ -255,6 +255,8 @@ config PTP_S390
>   
>   config PTP_NETC_V4_TIMER
>   	tristate "NXP NETC V4 Timer PTP Driver"
> +	depends on NXP_ENETC4 || COMPILE_TEST
> +	default y if NXP_ENETC4
>   	depends on PTP_1588_CLOCK
>   	depends on PCI_MSI
>   	help

LGTM,
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>

Re: [PATCH] ptp: netc: Add dependency on NXP_ENETC4

[Jakub Kicinski]

On Sun,  5 Oct 2025 21:49:42 +0100 Peter Robinson wrote:
> The NETC V4 Timer PTP IP works with the associated NIC
> so depend on it, plus compile test, and default it on if
> the NIC is enabled similar to the other PTP modules.
> 
> Fixes: 87a201d59963e ("ptp: netc: add NETC V4 Timer PTP driver support")

You put a Fixes tag here, suggesting this is a fix.
What bug is it fixing? Seems like an improvement to the default 
kconfig behavior, TBH. If it is a bug fix please explain in the
commit message more. If not please drop the Fixes tag and repost
next week. Also..
 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>  drivers/ptp/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
> index 5f8ea34d11d6d..a5542751216d6 100644
> --- a/drivers/ptp/Kconfig
> +++ b/drivers/ptp/Kconfig
> @@ -255,6 +255,8 @@ config PTP_S390
>  
>  config PTP_NETC_V4_TIMER
>  	tristate "NXP NETC V4 Timer PTP Driver"
> +	depends on NXP_ENETC4 || COMPILE_TEST

.. why? Does the clock driver not work at all without the networking
driver? Or you just think that they go together?

> +	default y if NXP_ENETC4

Isn't this better written as:

	default NXP_ENETC4

?

>  	depends on PTP_1588_CLOCK
>  	depends on PCI_MSI
>  	help

Re: [PATCH] ptp: netc: Add dependency on NXP_ENETC4

[Peter Robinson]

On Wed, 8 Oct 2025 at 02:19, Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Sun,  5 Oct 2025 21:49:42 +0100 Peter Robinson wrote:
> > The NETC V4 Timer PTP IP works with the associated NIC
> > so depend on it, plus compile test, and default it on if
> > the NIC is enabled similar to the other PTP modules.
> >
> > Fixes: 87a201d59963e ("ptp: netc: add NETC V4 Timer PTP driver support")
>
> You put a Fixes tag here, suggesting this is a fix.
> What bug is it fixing? Seems like an improvement to the default
> kconfig behavior, TBH. If it is a bug fix please explain in the
> commit message more. If not please drop the Fixes tag and repost
> next week. Also..

I don't believe it works without the associated hardware so it seems
like a bug to me, There's likely nuance and opinion. I labelled as a
fix so it lands into the same kernel release as opposed to the next
one.

> > Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> > ---
> >  drivers/ptp/Kconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
> > index 5f8ea34d11d6d..a5542751216d6 100644
> > --- a/drivers/ptp/Kconfig
> > +++ b/drivers/ptp/Kconfig
> > @@ -255,6 +255,8 @@ config PTP_S390
> >
> >  config PTP_NETC_V4_TIMER
> >       tristate "NXP NETC V4 Timer PTP Driver"
> > +     depends on NXP_ENETC4 || COMPILE_TEST
>
> .. why? Does the clock driver not work at all without the networking
> driver? Or you just think that they go together?

It is my understanding that it doesn't, it's also the way the
PTP_1588_CLOCK_QORIQ does it, hence i did that way.

> > +     default y if NXP_ENETC4
>
> Isn't this better written as:
>
>         default NXP_ENETC4

I did it the same way as the other HW drivers such as
PTP_1588_CLOCK_QORIQ and PTP_1588_CLOCK_DTE did in that Kconfig file
for consistency

> ?
>
> >       depends on PTP_1588_CLOCK
> >       depends on PCI_MSI
> >       help
>

RE: [PATCH] ptp: netc: Add dependency on NXP_ENETC4

[Wei Fang]

> > > The NETC V4 Timer PTP IP works with the associated NIC
> > > so depend on it, plus compile test, and default it on if
> > > the NIC is enabled similar to the other PTP modules.
> > >
> > > Fixes: 87a201d59963e ("ptp: netc: add NETC V4 Timer PTP driver support")
> >
> > You put a Fixes tag here, suggesting this is a fix.
> > What bug is it fixing? Seems like an improvement to the default
> > kconfig behavior, TBH. If it is a bug fix please explain in the
> > commit message more. If not please drop the Fixes tag and repost
> > next week. Also..
> 
> I don't believe it works without the associated hardware so it seems
> like a bug to me, There's likely nuance and opinion. I labelled as a
> fix so it lands into the same kernel release as opposed to the next
> one.
> 

The NETC timer and ENETC are two PCIe devices, and the timer
provides PHC for ENETC to use. From hardware perspective, the
timer is PHC supplier and ENETC is the consumer, the timer should
work properly even if ENETC is not working. For example, the timer
can still provide PPS event, outputs periodic pulse signal captures
external timestamps and so on.