All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Roy Luo <royluo@google.com>
Cc: "Vinod Koul" <vkoul@kernel.org>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Thinh Nguyen" <Thinh.Nguyen@synopsys.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Peter Griffin" <peter.griffin@linaro.org>,
	"André Draszik" <andre.draszik@linaro.org>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"Joy Chakraborty" <joychakr@google.com>,
	"Naveen Kumar" <mnkumar@google.com>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v1 3/4] usb: dwc3: Add Google SoC USB PHY driver
Date: Tue, 7 Oct 2025 07:51:27 +0200	[thread overview]
Message-ID: <2025100735-gulf-error-2ce2@gregkh> (raw)
In-Reply-To: <20251006232125.1833979-4-royluo@google.com>

On Mon, Oct 06, 2025 at 11:21:24PM +0000, Roy Luo wrote:
> Support the USB PHY found on Google Tensor SoCs.

That's great, but that's not what your subject line says (it says "usb:
dwc3")

> This particular USB PHY supports both high-speed and super-speed
> operations, and is paired with the SNPS DWC3 controller that's also
> integrated on the SoCs.
> This initial patch specifically adds functionality for high-speed.
> 
> Co-developed-by: Joy Chakraborty <joychakr@google.com>
> Signed-off-by: Joy Chakraborty <joychakr@google.com>
> Co-developed-by: Naveen Kumar <mnkumar@google.com>
> Signed-off-by: Naveen Kumar <mnkumar@google.com>
> Signed-off-by: Roy Luo <royluo@google.com>
> ---
>  drivers/phy/Kconfig                 |   1 +
>  drivers/phy/Makefile                |   1 +
>  drivers/phy/google/Kconfig          |  15 ++
>  drivers/phy/google/Makefile         |   2 +
>  drivers/phy/google/phy-google-usb.c | 286 ++++++++++++++++++++++++++++

And as others said, you don't need a whole new directory for one single
.c file.

thanks,

greg k-h


WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Roy Luo <royluo@google.com>
Cc: "Vinod Koul" <vkoul@kernel.org>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Thinh Nguyen" <Thinh.Nguyen@synopsys.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Peter Griffin" <peter.griffin@linaro.org>,
	"André Draszik" <andre.draszik@linaro.org>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"Joy Chakraborty" <joychakr@google.com>,
	"Naveen Kumar" <mnkumar@google.com>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v1 3/4] usb: dwc3: Add Google SoC USB PHY driver
Date: Tue, 7 Oct 2025 07:51:27 +0200	[thread overview]
Message-ID: <2025100735-gulf-error-2ce2@gregkh> (raw)
In-Reply-To: <20251006232125.1833979-4-royluo@google.com>

On Mon, Oct 06, 2025 at 11:21:24PM +0000, Roy Luo wrote:
> Support the USB PHY found on Google Tensor SoCs.

That's great, but that's not what your subject line says (it says "usb:
dwc3")

> This particular USB PHY supports both high-speed and super-speed
> operations, and is paired with the SNPS DWC3 controller that's also
> integrated on the SoCs.
> This initial patch specifically adds functionality for high-speed.
> 
> Co-developed-by: Joy Chakraborty <joychakr@google.com>
> Signed-off-by: Joy Chakraborty <joychakr@google.com>
> Co-developed-by: Naveen Kumar <mnkumar@google.com>
> Signed-off-by: Naveen Kumar <mnkumar@google.com>
> Signed-off-by: Roy Luo <royluo@google.com>
> ---
>  drivers/phy/Kconfig                 |   1 +
>  drivers/phy/Makefile                |   1 +
>  drivers/phy/google/Kconfig          |  15 ++
>  drivers/phy/google/Makefile         |   2 +
>  drivers/phy/google/phy-google-usb.c | 286 ++++++++++++++++++++++++++++

And as others said, you don't need a whole new directory for one single
.c file.

thanks,

greg k-h

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  parent reply	other threads:[~2025-10-07  5:51 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-06 23:21 [PATCH v1 0/4] Add Google Tensor SoC USB support Roy Luo
2025-10-06 23:21 ` Roy Luo
2025-10-06 23:21 ` [PATCH v1 1/4] usb: dwc3: Add Google SoC DWC3 glue driver Roy Luo
2025-10-06 23:21   ` Roy Luo
2025-10-07  0:46   ` Krzysztof Kozlowski
2025-10-07  0:46     ` Krzysztof Kozlowski
2025-10-07 18:08     ` Roy Luo
2025-10-07 18:08       ` Roy Luo
2025-10-11  3:39   ` kernel test robot
2025-10-11  3:39     ` kernel test robot
2025-10-06 23:21 ` [PATCH v1 2/4] dt-bindings: usb: dwc3: Add Google SoC DWC3 USB Roy Luo
2025-10-06 23:21   ` Roy Luo
2025-10-07  0:44   ` Krzysztof Kozlowski
2025-10-07  0:44     ` Krzysztof Kozlowski
2025-10-07  9:09     ` Peter Griffin
2025-10-07  9:09       ` Peter Griffin
2025-10-07 14:18       ` Krzysztof Kozlowski
2025-10-07 14:18         ` Krzysztof Kozlowski
2025-10-07 18:49         ` Roy Luo
2025-10-07 18:49           ` Roy Luo
2025-10-06 23:21 ` [PATCH v1 3/4] usb: dwc3: Add Google SoC USB PHY driver Roy Luo
2025-10-06 23:21   ` Roy Luo
2025-10-07  0:42   ` Krzysztof Kozlowski
2025-10-07  0:42     ` Krzysztof Kozlowski
2025-10-07  5:51   ` Greg Kroah-Hartman [this message]
2025-10-07  5:51     ` Greg Kroah-Hartman
2025-10-07 18:57     ` Roy Luo
2025-10-07 18:57       ` Roy Luo
2025-10-06 23:21 ` [PATCH v1 4/4] dt-bindings: phy: google: Add Google SoC USB PHY Roy Luo
2025-10-06 23:21   ` Roy Luo
2025-10-07  0:45   ` Krzysztof Kozlowski
2025-10-07  0:45     ` Krzysztof Kozlowski
2025-10-07 19:04     ` Roy Luo
2025-10-07 19:04       ` Roy Luo
2025-10-07  1:06 ` [PATCH v1 0/4] Add Google Tensor SoC USB support Krzysztof Kozlowski
2025-10-07  1:06   ` Krzysztof Kozlowski
2025-10-07 18:03   ` Roy Luo
2025-10-07 18:03     ` Roy Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025100735-gulf-error-2ce2@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=andre.draszik@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joychakr@google.com \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mnkumar@google.com \
    --cc=p.zabel@pengutronix.de \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=royluo@google.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.