All of lore.kernel.org
 help / color / mirror / Atom feed
* [nftables PATCH] doc: fix tcpdump example
@ 2025-10-13 17:17 georg
  2025-10-13 19:19 ` Fernando Fernandez Mancera
  0 siblings, 1 reply; 3+ messages in thread
From: georg @ 2025-10-13 17:17 UTC (permalink / raw)
  To: netfilter-devel; +Cc: Georg Pfuetzenreuter

From: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>

The expression needs to be enclosed in a single string and combined with
a logical AND to have the desired effect.

Fixes: 1188a69604c3 ("src: introduce SYNPROXY matching")
Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
---
 doc/statements.txt | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/doc/statements.txt b/doc/statements.txt
index 6226713ba389..834f95fbb2a8 100644
--- a/doc/statements.txt
+++ b/doc/statements.txt
@@ -691,8 +691,7 @@ needed for selective acknowledgement and window scaling).
 ---------------------------------------
 Determine tcp options used by backend, from an external system
 
-              tcpdump -pni eth0 -c 1 'tcp[tcpflags] == (tcp-syn|tcp-ack)'
-                  port 80 &
+              tcpdump -pni eth0 -c 1 'tcp[tcpflags] == (tcp-syn|tcp-ack) && port 80' &
               telnet 192.0.2.42 80
               18:57:24.693307 IP 192.0.2.42.80 > 192.0.2.43.48757:
                   Flags [S.], seq 360414582, ack 788841994, win 14480,
-- 
2.50.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [nftables PATCH] doc: fix tcpdump example
  2025-10-13 17:17 [nftables PATCH] doc: fix tcpdump example georg
@ 2025-10-13 19:19 ` Fernando Fernandez Mancera
  2025-10-13 19:43   ` Florian Westphal
  0 siblings, 1 reply; 3+ messages in thread
From: Fernando Fernandez Mancera @ 2025-10-13 19:19 UTC (permalink / raw)
  To: georg, netfilter-devel; +Cc: Georg Pfuetzenreuter



On 10/13/25 7:17 PM, georg@syscid.com wrote:
> From: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
> 
> The expression needs to be enclosed in a single string and combined with
> a logical AND to have the desired effect.
> 
> Fixes: 1188a69604c3 ("src: introduce SYNPROXY matching")
> Signed-off-by: Georg Pfuetzenreuter <mail@georg-pfuetzenreuter.net>
> ---
>   doc/statements.txt | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)

Thank you Georg!

Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [nftables PATCH] doc: fix tcpdump example
  2025-10-13 19:19 ` Fernando Fernandez Mancera
@ 2025-10-13 19:43   ` Florian Westphal
  0 siblings, 0 replies; 3+ messages in thread
From: Florian Westphal @ 2025-10-13 19:43 UTC (permalink / raw)
  To: Fernando Fernandez Mancera; +Cc: georg, netfilter-devel, Georg Pfuetzenreuter

Fernando Fernandez Mancera <fmancera@suse.de> wrote:
> > The expression needs to be enclosed in a single string and combined with
> > a logical AND to have the desired effect.
> Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>

Applied, thanks everyone.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-10-13 19:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-13 17:17 [nftables PATCH] doc: fix tcpdump example georg
2025-10-13 19:19 ` Fernando Fernandez Mancera
2025-10-13 19:43   ` Florian Westphal

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.