From: Leon Romanovsky <leon@kernel.org>
To: Saeed Mahameed <saeed@kernel.org>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
Jason Gunthorpe <jgg@nvidia.com>,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
Tariq Toukan <tariqt@nvidia.com>,
Adithya Jayachandran <ajayachandra@nvidia.com>,
Mark Bloch <mbloch@nvidia.com>
Subject: Re: [PATCH mlx5-next] {rdma,net}/mlx5: Query vports mac address from device
Date: Sun, 19 Oct 2025 15:59:23 +0300 [thread overview]
Message-ID: <20251019125923.GI6199@unreal> (raw)
In-Reply-To: <20251016014055.2040934-1-saeed@kernel.org>
On Wed, Oct 15, 2025 at 06:40:55PM -0700, Saeed Mahameed wrote:
> From: Adithya Jayachandran <ajayachandra@nvidia.com>
>
> Before this patch during either switchdev or legacy mode enablement we
> cleared the mac address of vports between changes. This change allows us
> to preserve the vports mac address between eswitch mode changes.
>
> Signed-off-by: Adithya Jayachandran <ajayachandra@nvidia.com>
> Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
> Reviewed-by: Mark Bloch <mbloch@nvidia.com>
> ---
> drivers/infiniband/hw/mlx5/main.c | 2 +-
> .../net/ethernet/mellanox/mlx5/core/eswitch.c | 20 ++++++----------
> .../mellanox/mlx5/core/eswitch_offloads.c | 3 +++
> .../net/ethernet/mellanox/mlx5/core/vport.c | 24 +++++++++----------
> include/linux/mlx5/vport.h | 3 ++-
> 5 files changed, 25 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
> index fc1e86f6c409..90daa58126f4 100644
> --- a/drivers/infiniband/hw/mlx5/main.c
> +++ b/drivers/infiniband/hw/mlx5/main.c
> @@ -842,7 +842,7 @@ static int mlx5_query_node_guid(struct mlx5_ib_dev *dev,
> break;
>
> case MLX5_VPORT_ACCESS_METHOD_NIC:
> - err = mlx5_query_nic_vport_node_guid(dev->mdev, &tmp);
> + err = mlx5_query_nic_vport_node_guid(dev->mdev, 0, false, &tmp);
> break;
IB changes are pretty straightforward.
Thanks,
Acked-by: Leon Romanovsky <leon@kernel.org> # RDMA
next prev parent reply other threads:[~2025-10-19 12:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 1:40 [PATCH mlx5-next] {rdma,net}/mlx5: Query vports mac address from device Saeed Mahameed
2025-10-19 12:59 ` Leon Romanovsky [this message]
2025-10-21 23:47 ` Jakub Kicinski
2025-10-22 2:12 ` Saeed Mahameed
2025-10-23 0:10 ` Jakub Kicinski
2025-10-25 3:21 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251019125923.GI6199@unreal \
--to=leon@kernel.org \
--cc=ajayachandra@nvidia.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.