From: Jakub Kicinski <kuba@kernel.org>
To: Saeed Mahameed <saeed@kernel.org>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Jason Gunthorpe <jgg@nvidia.com>,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
Tariq Toukan <tariqt@nvidia.com>,
Adithya Jayachandran <ajayachandra@nvidia.com>,
Mark Bloch <mbloch@nvidia.com>
Subject: Re: [PATCH mlx5-next] {rdma,net}/mlx5: Query vports mac address from device
Date: Wed, 22 Oct 2025 17:10:33 -0700 [thread overview]
Message-ID: <20251022171033.43ae5dc8@kernel.org> (raw)
In-Reply-To: <aPg9hQjpXeR-mJG2@x130>
On Tue, 21 Oct 2025 19:12:21 -0700 Saeed Mahameed wrote:
> On 21 Oct 16:47, Jakub Kicinski wrote:
> >On Wed, 15 Oct 2025 18:40:55 -0700 Saeed Mahameed wrote:
> >> Before this patch during either switchdev or legacy mode enablement we
> >> cleared the mac address of vports between changes. This change allows us
> >> to preserve the vports mac address between eswitch mode changes.
> >
> >Not knowing what exactly a vport is I can't tell whether this preserves
> >MAC addrs of reprs, the uplink, something else?
>
> vport == vf or sf, so VF/SF permanent mac address. It can be set either by
> iproute vf interface or devlink function interface. For no obvious reason
> we reset it to 0 on switchdev legacy mode changes.. this patch is fixing
> that.
>
> Of course vport holds more information than just the mac address, e.g GUID,
> mtu, promisc mode, mulitcast mode, and other stuff.
SG! Would be good to incorporate that into the commit msg if possible.
next prev parent reply other threads:[~2025-10-23 0:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 1:40 [PATCH mlx5-next] {rdma,net}/mlx5: Query vports mac address from device Saeed Mahameed
2025-10-19 12:59 ` Leon Romanovsky
2025-10-21 23:47 ` Jakub Kicinski
2025-10-22 2:12 ` Saeed Mahameed
2025-10-23 0:10 ` Jakub Kicinski [this message]
2025-10-25 3:21 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251022171033.43ae5dc8@kernel.org \
--to=kuba@kernel.org \
--cc=ajayachandra@nvidia.com \
--cc=jgg@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.