From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCHv4 net-next 1/4] net: add a common function to compute features from lowers devices
Date: Sun, 19 Oct 2025 13:52:57 +0800 [thread overview]
Message-ID: <202510191336.5MademAX-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20251014080217.47988-2-liuhangbin@gmail.com>
References: <20251014080217.47988-2-liuhangbin@gmail.com>
TO: Hangbin Liu <liuhangbin@gmail.com>
TO: netdev@vger.kernel.org
CC: Jay Vosburgh <jv@jvosburgh.net>
CC: Andrew Lunn <andrew+netdev@lunn.ch>
CC: Eric Dumazet <edumazet@google.com>
CC: Jakub Kicinski <kuba@kernel.org>
CC: Paolo Abeni <pabeni@redhat.com>
CC: Sabrina Dubroca <sdubroca@redhat.com>
CC: Jiri Pirko <jiri@resnulli.us>
CC: Simon Horman <horms@kernel.org>
CC: Ido Schimmel <idosch@nvidia.com>
CC: Shuah Khan <skhan@linuxfoundation.org>
CC: Stanislav Fomichev <sdf@fomichev.me>
CC: Kuniyuki Iwashima <kuniyu@google.com>
CC: Alexander Lobakin <aleksander.lobakin@intel.com>
CC: bridge@lists.linux.dev
CC: linux-kselftest@vger.kernel.org
CC: Hangbin Liu <liuhangbin@gmail.com>
Hi Hangbin,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Hangbin-Liu/net-add-a-common-function-to-compute-features-from-lowers-devices/20251014-160824
base: net-next/main
patch link: https://lore.kernel.org/r/20251014080217.47988-2-liuhangbin%40gmail.com
patch subject: [PATCHv4 net-next 1/4] net: add a common function to compute features from lowers devices
:::::: branch date: 5 days ago
:::::: commit date: 5 days ago
config: i386-randconfig-141-20251015 (https://download.01.org/0day-ci/archive/20251019/202510191336.5MademAX-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202510191336.5MademAX-lkp@intel.com/
New smatch warnings:
net/core/dev.c:12676 netdev_compute_features_from_lowers() error: uninitialized symbol 'max_headroom'.
net/core/dev.c:12678 netdev_compute_features_from_lowers() error: uninitialized symbol 'max_tailroom'.
Old smatch warnings:
net/core/dev.c:12703 netdev_compute_features_from_lowers() error: uninitialized symbol 'max_headroom'.
net/core/dev.c:12704 netdev_compute_features_from_lowers() error: uninitialized symbol 'max_tailroom'.
vim +/max_headroom +12676 net/core/dev.c
93045b1e9511f0f Hangbin Liu 2025-10-14 12666
93045b1e9511f0f Hangbin Liu 2025-10-14 12667 mpls_features = netdev_increment_features(mpls_features,
93045b1e9511f0f Hangbin Liu 2025-10-14 12668 lower_dev->mpls_features,
93045b1e9511f0f Hangbin Liu 2025-10-14 12669 VIRTUAL_DEV_MPLS_FEATURES);
93045b1e9511f0f Hangbin Liu 2025-10-14 12670
93045b1e9511f0f Hangbin Liu 2025-10-14 12671 dst_release_flag &= lower_dev->priv_flags;
93045b1e9511f0f Hangbin Liu 2025-10-14 12672
93045b1e9511f0f Hangbin Liu 2025-10-14 12673 if (update_header) {
93045b1e9511f0f Hangbin Liu 2025-10-14 12674 max_header_len = max_t(unsigned short, max_header_len,
93045b1e9511f0f Hangbin Liu 2025-10-14 12675 lower_dev->hard_header_len);
93045b1e9511f0f Hangbin Liu 2025-10-14 @12676 max_headroom = max_t(unsigned short, max_headroom,
93045b1e9511f0f Hangbin Liu 2025-10-14 12677 lower_dev->needed_headroom);
93045b1e9511f0f Hangbin Liu 2025-10-14 @12678 max_tailroom = max_t(unsigned short, max_tailroom,
93045b1e9511f0f Hangbin Liu 2025-10-14 12679 lower_dev->needed_tailroom);
93045b1e9511f0f Hangbin Liu 2025-10-14 12680 }
93045b1e9511f0f Hangbin Liu 2025-10-14 12681
93045b1e9511f0f Hangbin Liu 2025-10-14 12682 tso_max_size = min(tso_max_size, lower_dev->tso_max_size);
93045b1e9511f0f Hangbin Liu 2025-10-14 12683 tso_max_segs = min(tso_max_segs, lower_dev->tso_max_segs);
93045b1e9511f0f Hangbin Liu 2025-10-14 12684 }
93045b1e9511f0f Hangbin Liu 2025-10-14 12685
93045b1e9511f0f Hangbin Liu 2025-10-14 12686 dev->gso_partial_features = gso_partial_features;
93045b1e9511f0f Hangbin Liu 2025-10-14 12687 dev->vlan_features = vlan_features;
93045b1e9511f0f Hangbin Liu 2025-10-14 12688 dev->hw_enc_features = enc_features | NETIF_F_GSO_ENCAP_ALL |
93045b1e9511f0f Hangbin Liu 2025-10-14 12689 NETIF_F_HW_VLAN_CTAG_TX |
93045b1e9511f0f Hangbin Liu 2025-10-14 12690 NETIF_F_HW_VLAN_STAG_TX;
93045b1e9511f0f Hangbin Liu 2025-10-14 12691 #ifdef CONFIG_XFRM_OFFLOAD
93045b1e9511f0f Hangbin Liu 2025-10-14 12692 dev->hw_enc_features |= xfrm_features;
93045b1e9511f0f Hangbin Liu 2025-10-14 12693 #endif
93045b1e9511f0f Hangbin Liu 2025-10-14 12694 dev->mpls_features = mpls_features;
93045b1e9511f0f Hangbin Liu 2025-10-14 12695
93045b1e9511f0f Hangbin Liu 2025-10-14 12696 dev->priv_flags &= ~IFF_XMIT_DST_RELEASE;
93045b1e9511f0f Hangbin Liu 2025-10-14 12697 if ((dev->priv_flags & IFF_XMIT_DST_RELEASE_PERM) &&
93045b1e9511f0f Hangbin Liu 2025-10-14 12698 dst_release_flag == (IFF_XMIT_DST_RELEASE | IFF_XMIT_DST_RELEASE_PERM))
93045b1e9511f0f Hangbin Liu 2025-10-14 12699 dev->priv_flags |= IFF_XMIT_DST_RELEASE;
93045b1e9511f0f Hangbin Liu 2025-10-14 12700
93045b1e9511f0f Hangbin Liu 2025-10-14 12701 if (update_header) {
93045b1e9511f0f Hangbin Liu 2025-10-14 12702 dev->hard_header_len = max_header_len;
93045b1e9511f0f Hangbin Liu 2025-10-14 12703 dev->needed_headroom = max_headroom;
93045b1e9511f0f Hangbin Liu 2025-10-14 12704 dev->needed_tailroom = max_tailroom;
93045b1e9511f0f Hangbin Liu 2025-10-14 12705 }
93045b1e9511f0f Hangbin Liu 2025-10-14 12706
93045b1e9511f0f Hangbin Liu 2025-10-14 12707 netif_set_tso_max_segs(dev, tso_max_segs);
93045b1e9511f0f Hangbin Liu 2025-10-14 12708 netif_set_tso_max_size(dev, tso_max_size);
93045b1e9511f0f Hangbin Liu 2025-10-14 12709
93045b1e9511f0f Hangbin Liu 2025-10-14 12710 netdev_change_features(dev);
93045b1e9511f0f Hangbin Liu 2025-10-14 12711 }
93045b1e9511f0f Hangbin Liu 2025-10-14 12712 EXPORT_SYMBOL(netdev_compute_features_from_lowers);
93045b1e9511f0f Hangbin Liu 2025-10-14 12713
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2025-10-19 5:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-19 5:52 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-10-16 23:51 [PATCHv4 net-next 1/4] net: add a common function to compute features from lowers devices kernel test robot
2025-10-14 8:02 [PATCHv4 net-next 0/4] net: common feature compute for upper interface Hangbin Liu
2025-10-14 8:02 ` [PATCHv4 net-next 1/4] net: add a common function to compute features from lowers devices Hangbin Liu
2025-10-14 9:40 ` Jiri Pirko
2025-10-15 1:25 ` Hangbin Liu
2025-10-16 11:27 ` Jiri Pirko
2025-10-16 12:38 ` Hangbin Liu
2025-10-16 13:24 ` Jiri Pirko
2025-10-17 2:53 ` Hangbin Liu
2025-10-14 14:02 ` Simon Horman
2025-10-15 3:03 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202510191336.5MademAX-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.