* [PATCH v2] mfd: da9063: occupy second I2C address, too
@ 2025-10-07 15:40 Wolfram Sang
2025-10-21 11:08 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2025-10-07 15:40 UTC (permalink / raw)
To: linux-renesas-soc
Cc: linux-kernel, Wolfram Sang, Peter Rosin, Bartosz Golaszewski,
Kieran Bingham, Support Opensource, Lee Jones
The second address can be used as a shortcut to access register pages
2+3. The driver does not use this feature yet. The second address should
still be marked as used, otherwise userspace could interfere with the
driver.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Peter Rosin <peda@axentia.se>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
Change since v1: reworded commit message
drivers/mfd/da9063-i2c.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c
index 1ec9ab56442d..12f3dd927aba 100644
--- a/drivers/mfd/da9063-i2c.c
+++ b/drivers/mfd/da9063-i2c.c
@@ -469,6 +469,8 @@ static int da9063_i2c_probe(struct i2c_client *i2c)
}
}
+ devm_i2c_new_dummy_device(&i2c->dev, i2c->adapter, i2c->addr + 1);
+
return da9063_device_init(da9063, i2c->irq);
}
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mfd: da9063: occupy second I2C address, too
2025-10-07 15:40 [PATCH v2] mfd: da9063: occupy second I2C address, too Wolfram Sang
@ 2025-10-21 11:08 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2025-10-21 11:08 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-renesas-soc, linux-kernel, Peter Rosin, Bartosz Golaszewski,
Kieran Bingham, Support Opensource
On Tue, 07 Oct 2025, Wolfram Sang wrote:
> The second address can be used as a shortcut to access register pages
> 2+3. The driver does not use this feature yet. The second address should
> still be marked as used, otherwise userspace could interfere with the
> driver.
Perfect. Thanks for updating.
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Reviewed-by: Peter Rosin <peda@axentia.se>
> Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
>
> Change since v1: reworded commit message
>
> drivers/mfd/da9063-i2c.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c
> index 1ec9ab56442d..12f3dd927aba 100644
> --- a/drivers/mfd/da9063-i2c.c
> +++ b/drivers/mfd/da9063-i2c.c
> @@ -469,6 +469,8 @@ static int da9063_i2c_probe(struct i2c_client *i2c)
> }
> }
>
> + devm_i2c_new_dummy_device(&i2c->dev, i2c->adapter, i2c->addr + 1);
I still think we need a simple comment to explain why we're obtaining
and seemingly not using the address.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-21 11:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-07 15:40 [PATCH v2] mfd: da9063: occupy second I2C address, too Wolfram Sang
2025-10-21 11:08 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.