From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Theodore Ts'o <tytso@mit.edu>,
zlang@redhat.com, fstests@vger.kernel.org,
linux-xfs@vger.kernel.org,
linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 6/8] common/filter: fix _filter_file_attributes to handle xfs file flags
Date: Tue, 21 Oct 2025 07:47:50 -0700 [thread overview]
Message-ID: <20251021144750.GG3356773@frogsfrogsfrogs> (raw)
In-Reply-To: <aPcadbSFFBj4Do4c@infradead.org>
On Mon, Oct 20, 2025 at 10:30:29PM -0700, Christoph Hellwig wrote:
> On Mon, Oct 20, 2025 at 09:37:13AM -0700, Darrick J. Wong wrote:
> > [add tytso and linux-ext4]
> >
> > I think we should standardize on the VFS (aka file_getattr) flag values,
> > which means the xfs version more or less wins.
>
> Ok, I'm more than confused than before. Shouldn't we simply use
> separate filters for FS_IOC_GETFLAGS vs FS_IOC_FSGETXATTR?
Yeah. I was going to just provide both versions, but then I went down
the rabbithole of navelgazing about "Is upstream going to accept a
helper for the ext4 lsattr flags even though there are no users?" and
then wandered off to tackle actual useful things like mount/unmount
races in fuse. :P
--D
next prev parent reply other threads:[~2025-10-21 14:47 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 16:36 [PATCHSET] fstests: more random fixes for v2025.10.05 Darrick J. Wong
2025-10-15 16:36 ` [PATCH 1/8] generic/427: try to ensure there's some free space before we do the aio test Darrick J. Wong
2025-10-17 4:18 ` Christoph Hellwig
2025-10-20 14:16 ` Zorro Lang
2025-10-20 18:35 ` Darrick J. Wong
2025-10-15 16:37 ` [PATCH 2/8] common/rc: fix _require_xfs_io_shutdown Darrick J. Wong
2025-10-17 4:18 ` Christoph Hellwig
2025-10-24 7:31 ` Nirjhar Roy (IBM)
2025-10-24 22:08 ` Darrick J. Wong
2025-10-30 6:31 ` Nirjhar Roy (IBM)
2025-10-15 16:37 ` [PATCH 3/8] generic/742: avoid infinite loop if no fiemap results Darrick J. Wong
2025-10-17 4:19 ` Christoph Hellwig
2025-10-15 16:37 ` [PATCH 4/8] generic/{482,757}: skip test if there are no FUA writes Darrick J. Wong
2025-10-17 4:22 ` Christoph Hellwig
2025-10-17 16:24 ` Darrick J. Wong
2025-10-20 6:59 ` Christoph Hellwig
2025-10-15 16:38 ` [PATCH 5/8] generic/772: actually check for file_getattr special file support Darrick J. Wong
2025-10-17 4:23 ` Christoph Hellwig
2025-10-17 17:46 ` Zorro Lang
2025-10-17 22:54 ` Darrick J. Wong
2025-10-18 7:57 ` Zorro Lang
2025-10-20 16:26 ` Darrick J. Wong
2025-10-24 7:44 ` Nirjhar Roy (IBM)
2025-10-24 22:10 ` Darrick J. Wong
2025-10-30 6:05 ` Nirjhar Roy (IBM)
2025-10-30 16:33 ` Darrick J. Wong
2025-10-15 16:38 ` [PATCH 6/8] common/filter: fix _filter_file_attributes to handle xfs file flags Darrick J. Wong
2025-10-17 4:23 ` Christoph Hellwig
2025-10-17 16:22 ` Darrick J. Wong
2025-10-20 7:01 ` Christoph Hellwig
2025-10-20 16:37 ` Darrick J. Wong
2025-10-21 5:30 ` Christoph Hellwig
2025-10-21 14:47 ` Darrick J. Wong [this message]
2025-10-15 16:38 ` [PATCH 7/8] common/attr: fix _require_noattr2 Darrick J. Wong
2025-10-17 4:24 ` Christoph Hellwig
2025-10-17 17:13 ` Zorro Lang
2025-10-17 22:55 ` Darrick J. Wong
2025-10-18 14:43 ` Zorro Lang
2025-10-20 16:27 ` Darrick J. Wong
2025-10-24 9:01 ` Nirjhar Roy (IBM)
2025-10-24 22:15 ` Darrick J. Wong
2025-10-30 6:02 ` Nirjhar Roy (IBM)
2025-10-15 16:38 ` [PATCH 8/8] common: fix _require_xfs_io_command pwrite -A for various blocksizes Darrick J. Wong
2025-10-17 4:24 ` Christoph Hellwig
2025-10-24 9:18 ` Nirjhar Roy (IBM)
2025-10-24 22:16 ` Darrick J. Wong
2025-10-30 6:03 ` Nirjhar Roy (IBM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021144750.GG3356773@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.