From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
zlang@redhat.com, fstests@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 6/8] common/filter: fix _filter_file_attributes to handle xfs file flags
Date: Mon, 20 Oct 2025 00:01:21 -0700 [thread overview]
Message-ID: <aPXeQW0ISn6_aCoP@infradead.org> (raw)
In-Reply-To: <20251017162218.GD6178@frogsfrogsfrogs>
On Fri, Oct 17, 2025 at 09:22:18AM -0700, Darrick J. Wong wrote:
> > What XFS flags end up in lsattr?
>
> Assuming you're asking which XFS flags are reported by ext4 lsattr...
>
> append, noatime, nodump, immutable, projinherit, fsdax
>
> Unless you meant src/file_attr.c? In which case theyr'e
I'm actually not sure. I was just surprised about the flags showing
up.
>
> > Is this coordinated with the official
> > registry in ext4?
>
> Only informally by Ted and I talking on Thursdays.
>
> The problem here is that _filter_file_attributes ... probably ought to
> say which domain (ext4 lsattr or xfs_io lsattr) it's actually filtering.
Oooh. That explains my confusion.
> Right now the only users of this helper are using it to filter
> src/file_attr.c output (aka xfs_io lsattr) so I think I should change
> the patch to document that.
Yes, please. And we really need to figure out central authoritisied
to document the lsattr and fsxattr domain flags.
next prev parent reply other threads:[~2025-10-20 7:01 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 16:36 [PATCHSET] fstests: more random fixes for v2025.10.05 Darrick J. Wong
2025-10-15 16:36 ` [PATCH 1/8] generic/427: try to ensure there's some free space before we do the aio test Darrick J. Wong
2025-10-17 4:18 ` Christoph Hellwig
2025-10-20 14:16 ` Zorro Lang
2025-10-20 18:35 ` Darrick J. Wong
2025-10-15 16:37 ` [PATCH 2/8] common/rc: fix _require_xfs_io_shutdown Darrick J. Wong
2025-10-17 4:18 ` Christoph Hellwig
2025-10-24 7:31 ` Nirjhar Roy (IBM)
2025-10-24 22:08 ` Darrick J. Wong
2025-10-30 6:31 ` Nirjhar Roy (IBM)
2025-10-15 16:37 ` [PATCH 3/8] generic/742: avoid infinite loop if no fiemap results Darrick J. Wong
2025-10-17 4:19 ` Christoph Hellwig
2025-10-15 16:37 ` [PATCH 4/8] generic/{482,757}: skip test if there are no FUA writes Darrick J. Wong
2025-10-17 4:22 ` Christoph Hellwig
2025-10-17 16:24 ` Darrick J. Wong
2025-10-20 6:59 ` Christoph Hellwig
2025-10-15 16:38 ` [PATCH 5/8] generic/772: actually check for file_getattr special file support Darrick J. Wong
2025-10-17 4:23 ` Christoph Hellwig
2025-10-17 17:46 ` Zorro Lang
2025-10-17 22:54 ` Darrick J. Wong
2025-10-18 7:57 ` Zorro Lang
2025-10-20 16:26 ` Darrick J. Wong
2025-10-24 7:44 ` Nirjhar Roy (IBM)
2025-10-24 22:10 ` Darrick J. Wong
2025-10-30 6:05 ` Nirjhar Roy (IBM)
2025-10-30 16:33 ` Darrick J. Wong
2025-10-15 16:38 ` [PATCH 6/8] common/filter: fix _filter_file_attributes to handle xfs file flags Darrick J. Wong
2025-10-17 4:23 ` Christoph Hellwig
2025-10-17 16:22 ` Darrick J. Wong
2025-10-20 7:01 ` Christoph Hellwig [this message]
2025-10-20 16:37 ` Darrick J. Wong
2025-10-21 5:30 ` Christoph Hellwig
2025-10-21 14:47 ` Darrick J. Wong
2025-10-15 16:38 ` [PATCH 7/8] common/attr: fix _require_noattr2 Darrick J. Wong
2025-10-17 4:24 ` Christoph Hellwig
2025-10-17 17:13 ` Zorro Lang
2025-10-17 22:55 ` Darrick J. Wong
2025-10-18 14:43 ` Zorro Lang
2025-10-20 16:27 ` Darrick J. Wong
2025-10-24 9:01 ` Nirjhar Roy (IBM)
2025-10-24 22:15 ` Darrick J. Wong
2025-10-30 6:02 ` Nirjhar Roy (IBM)
2025-10-15 16:38 ` [PATCH 8/8] common: fix _require_xfs_io_command pwrite -A for various blocksizes Darrick J. Wong
2025-10-17 4:24 ` Christoph Hellwig
2025-10-24 9:18 ` Nirjhar Roy (IBM)
2025-10-24 22:16 ` Darrick J. Wong
2025-10-30 6:03 ` Nirjhar Roy (IBM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPXeQW0ISn6_aCoP@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.