All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: arnd@kernel.org, brauner@kernel.org, jack@suse.cz,
	regressions@lists.linux.dev, arnd@arndb.de,
	linux-kernel@vger.kernel.org, lkft-triage@lists.linaro.org,
	ltp@lists.linux.it, benjamin.copeland@linaro.org,
	linux-fsdevel@vger.kernel.org, aalbersh@kernel.org,
	lkft@linaro.org, dan.carpenter@linaro.org,
	viro@zeniv.linux.org.uk
Subject: Re: [LTP] [PATCH v2] ioctl_pidfd05: accept both EINVAL and ENOTTY as valid errors
Date: Fri, 24 Oct 2025 10:15:56 +0200	[thread overview]
Message-ID: <20251024081556.GA570960@pevik> (raw)
In-Reply-To: <CADYN=9J1xAgctUqwptD5C3Ss9aJZvZQ2ep=Ck2zP6X+ZrKe81Q@mail.gmail.com>

Hi all,

> On Thu, 23 Oct 2025 at 18:44, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:

> > Newer kernels (since ~v6.18-rc1) return ENOTTY instead of EINVAL when
> > invoking ioctl(pidfd, PIDFD_GET_INFO_SHORT, info_invalid). Update the
> > test to accept both EINVAL and ENOTTY as valid errors to ensure
> > compatibility across different kernel versions.

I dared to add a commit which caused the change (found by Cyril Hrubis):
3c17001b21b9f ("pidfs: validate extensible ioctls")

and merged!

Thanks for fix and review!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
	ltp@lists.linux.it, lkft@linaro.org, arnd@kernel.org,
	dan.carpenter@linaro.org, jack@suse.cz, brauner@kernel.org,
	chrubis@suse.cz, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, regressions@lists.linux.dev,
	aalbersh@kernel.org, arnd@arndb.de, viro@zeniv.linux.org.uk,
	benjamin.copeland@linaro.org, andrea.cervesato@suse.com,
	lkft-triage@lists.linaro.org, Avinesh Kumar <akumar@suse.de>
Subject: Re: [PATCH v2] ioctl_pidfd05: accept both EINVAL and ENOTTY as valid errors
Date: Fri, 24 Oct 2025 10:15:56 +0200	[thread overview]
Message-ID: <20251024081556.GA570960@pevik> (raw)
In-Reply-To: <CADYN=9J1xAgctUqwptD5C3Ss9aJZvZQ2ep=Ck2zP6X+ZrKe81Q@mail.gmail.com>

Hi all,

> On Thu, 23 Oct 2025 at 18:44, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:

> > Newer kernels (since ~v6.18-rc1) return ENOTTY instead of EINVAL when
> > invoking ioctl(pidfd, PIDFD_GET_INFO_SHORT, info_invalid). Update the
> > test to accept both EINVAL and ENOTTY as valid errors to ensure
> > compatibility across different kernel versions.

I dared to add a commit which caused the change (found by Cyril Hrubis):
3c17001b21b9f ("pidfs: validate extensible ioctls")

and merged!

Thanks for fix and review!

Kind regards,
Petr

  reply	other threads:[~2025-10-24  8:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-23 16:44 [LTP] [PATCH v2] ioctl_pidfd05: accept both EINVAL and ENOTTY as valid errors Naresh Kamboju
2025-10-23 16:44 ` Naresh Kamboju
2025-10-23 19:20 ` [LTP] " Anders Roxell
2025-10-23 19:20   ` Anders Roxell
2025-10-24  8:15   ` Petr Vorel [this message]
2025-10-24  8:15     ` Petr Vorel
2025-10-23 20:02 ` [LTP] " Avinesh Kumar
2025-10-23 20:02   ` Avinesh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251024081556.GA570960@pevik \
    --to=pvorel@suse.cz \
    --cc=aalbersh@kernel.org \
    --cc=anders.roxell@linaro.org \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=benjamin.copeland@linaro.org \
    --cc=brauner@kernel.org \
    --cc=dan.carpenter@linaro.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkft-triage@lists.linaro.org \
    --cc=lkft@linaro.org \
    --cc=ltp@lists.linux.it \
    --cc=regressions@lists.linux.dev \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.