All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: "Luis Claudio R. Goncalves" <lgoncalv@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Clark Williams <clrkwllms@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>, Tejun Heo <tj@kernel.org>,
	David Vernet <dvernet@meta.com>, Barret Rhoden <brho@google.com>,
	Josh Don <joshdon@google.com>, Crystal Wood <crwood@redhat.com>,
	linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev,
	Juri Lelli <juri.lelli@redhat.com>,
	Ben Segall <bsegall@google.com>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Ingo Molnar <mingo@redhat.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Wander Lairson Costa <wander@redhat.com>
Subject: Re: usage of DEFINE_WAIT_OVERRIDE_MAP(LD_WAIT_SLEEP)
Date: Fri, 24 Oct 2025 12:26:16 +0200	[thread overview]
Message-ID: <20251024102616.GD771@redhat.com> (raw)
In-Reply-To: <20251023192353.Wkng87fi@linutronix.de>

On 10/23, Sebastian Andrzej Siewior wrote:
>
> On 2025-10-23 17:53:40 [+0200], Oleg Nesterov wrote:
> > Sebastian,
> Hi Oleg,
>
> > sorry. I guess this is my fault, but I can't understand your reply...
> > Could you spell please?
>
> So you refer to this:
> | /* PREEMPT_RT kernels map spinlock to rt_mutex */
> | #include <linux/rtmutex.h>
> |
> | typedef struct spinlock {
> | 	struct rt_mutex_base	lock;
> | #ifdef CONFIG_DEBUG_LOCK_ALLOC
> | 	struct lockdep_map	dep_map;
> | #endif
> | } spinlock_t;
>
> spinlock_t on PREEMPT_RT does not use (struct) rt_mutex as the comment
> claims. It uses just the basic building block which is "struct
> rt_mutex_base". This requires linux/rtmutex.h.
>
> spinlock_t on PREEMPT_RT uses LD_WAIT_CONFIG via SPIN_DEP_MAP_INIT as
> !PREEMPT_RT. Nothing changes here.

Ah, indeed, I was confused and didn't even bother to read the definitions
below, spinlock->dep_map is initialized by the same SPIN_DEP_MAP_INIT()...

Sebastian, thanks for correcting me! Sorry, I could not carefully read
your emails yesterday.

Oleg.


  reply	other threads:[~2025-10-24 10:27 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-07 14:03 [PATCH v6] sched: do not call __put_task_struct() on rt if pi_blocked_on is set Luis Claudio R. Goncalves
2025-07-10 16:19 ` Valentin Schneider
2025-07-14 14:15 ` Sebastian Andrzej Siewior
2025-07-16 10:19 ` [tip: sched/core] sched: Do " tip-bot2 for Luis Claudio R. Goncalves
2025-07-28 20:14 ` [PATCH v6] sched: do " Oleg Nesterov
2025-07-29  7:33   ` Luis Claudio R. Goncalves
2025-07-29 11:47     ` Oleg Nesterov
2025-07-29 12:45       ` Luis Claudio R. Goncalves
2025-07-29 13:09         ` Oleg Nesterov
2025-08-01 10:24           ` Oleg Nesterov
2025-08-01 10:51             ` Luis Claudio R. Goncalves
2025-08-11 10:59             ` Sebastian Andrzej Siewior
2025-08-11 11:06               ` Oleg Nesterov
2025-08-11 12:16                 ` Sebastian Andrzej Siewior
2025-08-11 12:19                   ` Oleg Nesterov
2025-08-11 12:27                     ` Sebastian Andrzej Siewior
2025-10-20 14:53               ` usage of DEFINE_WAIT_OVERRIDE_MAP(LD_WAIT_SLEEP) Oleg Nesterov
2025-10-23 13:53                 ` Sebastian Andrzej Siewior
2025-10-23 15:29                   ` Oleg Nesterov
2025-10-23 15:37                     ` Sebastian Andrzej Siewior
2025-10-23 15:53                       ` Oleg Nesterov
2025-10-23 19:23                         ` Sebastian Andrzej Siewior
2025-10-24 10:26                           ` Oleg Nesterov [this message]
2025-10-24 10:39                             ` Sebastian Andrzej Siewior
2025-10-24 15:19                               ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251024102616.GD771@redhat.com \
    --to=oleg@redhat.com \
    --cc=bigeasy@linutronix.de \
    --cc=brho@google.com \
    --cc=bsegall@google.com \
    --cc=clrkwllms@kernel.org \
    --cc=crwood@redhat.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=dvernet@meta.com \
    --cc=joshdon@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=lgoncalv@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=wander@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.