All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Gopi Krishna Menon <krishnagopi487@gmail.com>
Cc: jirislaby@kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	david.hunter.linux@gmail.com, xandfury@gmail.com,
	skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev,
	khalid@kernel.org
Subject: Re: [PATCH v2] selftests: tty: add tty_tiocsti_test to .gitignore
Date: Sun, 26 Oct 2025 10:35:46 +0100	[thread overview]
Message-ID: <2025102634-relive-glutinous-df0c@gregkh> (raw)
In-Reply-To: <20251026092341.2896-1-krishnagopi487@gmail.com>

On Sun, Oct 26, 2025 at 02:52:32PM +0530, Gopi Krishna Menon wrote:
> Building the tty selftests generates the tty_tiocsti_test binary, which
> appears as untracked file in git. As mentioned in the kselftest
> documentation, all the generated objects must be placed inside
> .gitignore. This prevents the generated objects from accidentally
> getting staged and keeps the working tree clean.
> 
> Add the tty_tiocsti_test binary to .gitignore to avoid accidentally
> staging the build artifact and maintain a clean working tree.
> 
> Link: https://docs.kernel.org/dev-tools/kselftest.html#contributing-new-tests-details
> 
> Suggested-by: David Hunter <david.hunter.linux@gmail.com>
> Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
> ---
> Changelog:
> - Improve the commit wording and explain clearly why this change is needed.

What commit id does this fix?

thanks,

greg k-h

  reply	other threads:[~2025-10-26  9:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-24 16:19 [PATCH] selftests: tty: add tty_tiocsti_test to .gitignore Gopi Krishna Menon
2025-10-26  2:56 ` David Hunter
2025-10-26  7:25   ` [PATCH v2] " Gopi Krishna Menon
2025-10-26  8:35     ` Greg KH
2025-10-26  9:22       ` Gopi Krishna Menon
2025-10-26  9:35         ` Greg KH [this message]
2025-10-26 10:00           ` [PATCH v3] " Gopi Krishna Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025102634-relive-glutinous-df0c@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=david.hunter.linux@gmail.com \
    --cc=jirislaby@kernel.org \
    --cc=khalid@kernel.org \
    --cc=krishnagopi487@gmail.com \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=xandfury@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.