From: David Hunter <david.hunter.linux@gmail.com>
To: Gopi Krishna Menon <krishnagopi487@gmail.com>, shuah@kernel.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev,
khalid@kernel.org
Subject: Re: [PATCH] selftests: tty: add tty_tiocsti_test to .gitignore
Date: Sat, 25 Oct 2025 22:56:32 -0400 [thread overview]
Message-ID: <d1a483dd-5405-4e8b-8a38-816d49fffbc3@gmail.com> (raw)
In-Reply-To: <20251024161909.327158-1-krishnagopi487@gmail.com>
On 10/24/25 12:19, Gopi Krishna Menon wrote:
> Add the tty_tiocsti_test binary to .gitignore to avoid accidentally
> staging the build artifact.
>
Why do we want to ignore building this artifact? When submitting a
patch, it is important to list "why" something is needed. Not just what
is done.
> Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
> ---
> tools/testing/selftests/tty/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/tty/.gitignore b/tools/testing/selftests/tty/.gitignore
> index fe70462a4aad..2453685d2493 100644
> --- a/tools/testing/selftests/tty/.gitignore
> +++ b/tools/testing/selftests/tty/.gitignore
> @@ -1,2 +1,3 @@
> # SPDX-License-Identifier: GPL-2.0-only
> +tty_tiocsti_test
> tty_tstamp_update
Thanks,
David Hunter
next prev parent reply other threads:[~2025-10-26 2:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 16:19 [PATCH] selftests: tty: add tty_tiocsti_test to .gitignore Gopi Krishna Menon
2025-10-26 2:56 ` David Hunter [this message]
2025-10-26 7:25 ` [PATCH v2] " Gopi Krishna Menon
2025-10-26 8:35 ` Greg KH
2025-10-26 9:22 ` Gopi Krishna Menon
2025-10-26 9:35 ` Greg KH
2025-10-26 10:00 ` [PATCH v3] " Gopi Krishna Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1a483dd-5405-4e8b-8a38-816d49fffbc3@gmail.com \
--to=david.hunter.linux@gmail.com \
--cc=khalid@kernel.org \
--cc=krishnagopi487@gmail.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.