From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-iio@vger.kernel.org, chrome-platform@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Benson Leung" <bleung@chromium.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
Subject: [PATCH v1 5/6] iio: frequency: ad9523: Convert to use PI definition
Date: Mon, 27 Oct 2025 15:34:54 +0100 [thread overview]
Message-ID: <20251027143850.2070427-6-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20251027143850.2070427-1-andriy.shevchenko@linux.intel.com>
Convert to use PI definition instead of open coded value of it.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/iio/frequency/ad9523.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c
index 63c485e9e44c..fab1671d9212 100644
--- a/drivers/iio/frequency/ad9523.c
+++ b/drivers/iio/frequency/ad9523.c
@@ -15,6 +15,7 @@
#include <linux/err.h>
#include <linux/module.h>
#include <linux/delay.h>
+#include <linux/units.h>
#include <linux/iio/iio.h>
#include <linux/iio/sysfs.h>
@@ -652,7 +653,7 @@ static int ad9523_read_raw(struct iio_dev *indio_dev,
AD9523_CLK_DIST_DIV_REV(ret);
return IIO_VAL_INT;
case IIO_CHAN_INFO_PHASE:
- code = (AD9523_CLK_DIST_DIV_PHASE_REV(ret) * 3141592) /
+ code = (AD9523_CLK_DIST_DIV_PHASE_REV(ret) * DIV_ROUND_UP_ULL(PI, 1000)) /
AD9523_CLK_DIST_DIV_REV(ret);
*val = code / 1000000;
*val2 = code % 1000000;
@@ -701,7 +702,7 @@ static int ad9523_write_raw(struct iio_dev *indio_dev,
break;
case IIO_CHAN_INFO_PHASE:
code = val * 1000000 + val2 % 1000000;
- tmp = (code * AD9523_CLK_DIST_DIV_REV(ret)) / 3141592;
+ tmp = (code * AD9523_CLK_DIST_DIV_REV(reg)) / DIV_ROUND_UP_ULL(PI, 1000);
tmp = clamp(tmp, 0, 63);
reg &= ~AD9523_CLK_DIST_DIV_PHASE(~0);
reg |= AD9523_CLK_DIST_DIV_PHASE(tmp);
--
2.50.1
next prev parent reply other threads:[~2025-10-27 14:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 14:34 [PATCH v1 0/6] iio: Introduce and use value of π Andy Shevchenko
2025-10-27 14:34 ` [PATCH v1 1/6] media: vidtv: Rename PI definition to PI_SAMPLES Andy Shevchenko
2025-10-30 7:24 ` Hans Verkuil
2025-10-27 14:34 ` [PATCH v1 2/6] units: Add value of π * 10⁹ Andy Shevchenko
2025-10-27 14:52 ` Jonathan Cameron
2025-10-27 14:59 ` David Lechner
2025-10-28 8:09 ` Andy Shevchenko
2025-10-27 19:30 ` David Laight
2025-10-28 8:08 ` Andy Shevchenko
2025-10-28 9:27 ` David Laight
2025-10-27 14:34 ` [PATCH v1 3/6] media: dvb-frontends: atbm8830: Convert to use PI definition Andy Shevchenko
2025-10-30 7:26 ` Hans Verkuil
2025-10-27 14:34 ` [PATCH v1 4/6] iio: cros_ec_sensors: " Andy Shevchenko
2025-10-27 14:34 ` Andy Shevchenko [this message]
2025-10-27 14:34 ` [PATCH v1 6/6] iio: position: iqs624-pos: " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251027143850.2070427-6-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dlechner@baylibre.com \
--cc=dwlsalmeida@gmail.com \
--cc=groeck@chromium.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.